# git rev-parse -q --verify 03891f9c853d5c4473224478a1e03ea00d70ff8d^{commit} 03891f9c853d5c4473224478a1e03ea00d70ff8d already have revision, skipping fetch # git checkout -q -f -B kisskb 03891f9c853d5c4473224478a1e03ea00d70ff8d # git clean -qxdf # git log -1 commit 03891f9c853d5c4473224478a1e03ea00d70ff8d Merge: 47c62e4 385277b Author: Linus Torvalds Date: Mon Jan 11 22:25:00 2016 -0800 Merge tag 'dm-4.5-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm Pull device mapper updates from Mike Snitzer: - The most significant set of changes this cycle is the Forward Error Correction (FEC) support that has been added to the DM verity target. Google uses DM verity on all Android devices and it is believed that this FEC support will enable DM verity to recover from storage failures seen since DM verity was first deployed as part of Android. - A stable fix for a race in the destruction of DM thin pool's workqueue - A stable fix for hung IO if a DM snapshot copy hit an error - A few small cleanups in DM core and DM persistent data. - A couple DM thinp range discard improvements (address atomicity of finding a range and the efficiency of discarding a partially mapped thin device) - Add ability to debug DM bufio leaks by recording stack trace when a buffer is allocated. Upon detected leak the recorded stack is dumped. * tag 'dm-4.5-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm: dm snapshot: fix hung bios when copy error occurs dm thin: bump thin and thin-pool target versions dm thin: fix race condition when destroying thin pool workqueue dm space map metadata: remove unused variable in brb_pop() dm verity: add ignore_zero_blocks feature dm verity: add support for forward error correction dm verity: factor out verity_for_bv_block() dm verity: factor out structures and functions useful to separate object dm verity: move dm-verity.c to dm-verity-target.c dm verity: separate function for parsing opt args dm verity: clean up duplicate hashing code dm btree: factor out need_insert() helper dm bufio: use BUG_ON instead of conditional call to BUG dm bufio: store stacktrace in buffers to help find buffer leaks dm bufio: return NULL to improve code clarity dm block manager: cleanup code that prints stacktrace dm: don't save and restore bi_private dm thin metadata: make dm_thin_find_mapped_range() atomic dm thin metadata: speed up discard of partially mapped volumes # < /opt/cross/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 03891f9c853d5c4473224478a1e03ea00d70ff8d # < make -j 240 ARCH=powerpc O=/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc CROSS_COMPILE=/opt/cross/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- allnoconfig # make -j 240 ARCH=powerpc O=/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc CROSS_COMPILE=/opt/cross/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- make[1]: Entering directory `/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc' GEN ./Makefile scripts/kconfig/conf --silentoldconfig Kconfig make[1]: Leaving directory `/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc' make[1]: Entering directory `/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc' CHK include/config/kernel.release GEN ./Makefile WRAP arch/powerpc/include/generated/asm/clkdev.h WRAP arch/powerpc/include/generated/asm/div64.h WRAP arch/powerpc/include/generated/asm/irq_regs.h WRAP arch/powerpc/include/generated/asm/irq_work.h WRAP arch/powerpc/include/generated/asm/local64.h WRAP arch/powerpc/include/generated/asm/mcs_spinlock.h CHK include/generated/uapi/linux/version.h WRAP arch/powerpc/include/generated/asm/preempt.h WRAP arch/powerpc/include/generated/asm/rwsem.h WRAP arch/powerpc/include/generated/asm/vtime.h UPD include/generated/uapi/linux/version.h UPD include/config/kernel.release Using /home/kisskb/slave/src as source for kernel CHK include/generated/utsrelease.h UPD include/generated/utsrelease.h HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/flattree.o CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/data.o CC scripts/mod/devicetable-offsets.s HOSTCC scripts/dtc/livetree.o CHK include/generated/timeconst.h CC kernel/bounds.s HOSTCC scripts/dtc/treesource.o HOSTCC scripts/dtc/srcpos.o HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o UPD include/generated/timeconst.h SHIPPED scripts/dtc/dtc-parser.tab.h SHIPPED scripts/dtc/dtc-lexer.lex.c SHIPPED scripts/dtc/dtc-parser.tab.c HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o CHK include/generated/bounds.h UPD include/generated/bounds.h CC arch/powerpc/kernel/asm-offsets.s GEN scripts/mod/devicetable-offsets.h MKELF scripts/mod/elfconfig.h HOSTCC scripts/mod/modpost.o HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o CHK include/generated/asm-offsets.h UPD include/generated/asm-offsets.h CALL /home/kisskb/slave/src/scripts/checksyscalls.sh HOSTLD scripts/dtc/dtc HOSTLD scripts/mod/modpost LD usr/built-in.o CC init/main.o CHK include/generated/compile.h CC init/do_mounts.o CC init/noinitramfs.o CC init/init_task.o UPD include/generated/compile.h AS arch/powerpc/lib/string.o CC arch/powerpc/mm/fault.o LD arch/powerpc/sysdev/built-in.o CC arch/powerpc/mm/mem.o CC arch/powerpc/lib/alloc.o CC init/version.o CC arch/powerpc/mm/pgtable.o AS arch/powerpc/lib/crtsavres.o CC arch/powerpc/lib/ppc_ksyms.o LD arch/powerpc/platforms/built-in.o CC arch/powerpc/mm/mmap.o CC arch/powerpc/lib/code-patching.o CC arch/powerpc/lib/feature-fixups.o CC arch/powerpc/mm/init_32.o AS arch/powerpc/lib/div64.o AS arch/powerpc/lib/copy_32.o CC arch/powerpc/kernel/cputable.o CC arch/powerpc/mm/pgtable_32.o CC arch/powerpc/kernel/ptrace.o LD arch/powerpc/math-emu/built-in.o CC arch/powerpc/kernel/syscalls.o AS arch/powerpc/mm/hash_low_32.o CC arch/powerpc/mm/ppc_mmu_32.o AS arch/powerpc/lib/checksum_32.o CC arch/powerpc/kernel/irq.o CC arch/powerpc/mm/tlb_hash32.o CC arch/powerpc/kernel/align.o CC arch/powerpc/mm/mmu_context_hash32.o CC arch/powerpc/kernel/signal_32.o LD arch/powerpc/crypto/built-in.o CC arch/powerpc/kernel/pmc.o CC arch/powerpc/kernel/vdso.o CPP arch/powerpc/kernel/systbl_chk.i CC arch/powerpc/mm/hugetlbpage.o CC arch/powerpc/kernel/idle.o CC arch/powerpc/kernel/process.o LD arch/powerpc/net/built-in.o CC arch/powerpc/kernel/signal.o CC arch/powerpc/kernel/sysfs.o CC arch/powerpc/kernel/cacheinfo.o CC arch/powerpc/kernel/time.o CC arch/powerpc/kernel/prom.o CC arch/powerpc/kernel/traps.o CC arch/powerpc/kernel/setup-common.o CC arch/powerpc/kernel/udbg.o AS arch/powerpc/kernel/misc.o CC arch/powerpc/kernel/io.o LD certs/built-in.o CC arch/powerpc/kernel/dma.o AS arch/powerpc/kernel/misc_32.o CC arch/powerpc/kernel/of_platform.o CC arch/powerpc/kernel/prom_parse.o AS arch/powerpc/kernel/idle_6xx.o AS arch/powerpc/kernel/l2cr_6xx.o AS arch/powerpc/kernel/cpu_setup_6xx.o AS arch/powerpc/kernel/entry_32.o CC arch/powerpc/kernel/setup_32.o CC arch/powerpc/kernel/pci_32.o CC arch/powerpc/kernel/pci-common.o CC arch/powerpc/kernel/pci_of_scan.o CC arch/powerpc/kernel/iomap.o AS arch/powerpc/kernel/head_32.o LDS arch/powerpc/kernel/vmlinux.lds AS arch/powerpc/kernel/fpu.o CALL /home/kisskb/slave/src/arch/powerpc/kernel/systbl_chk.sh LD ipc/built-in.o LDS arch/powerpc/kernel/vdso32/vdso32.lds VDSO32A arch/powerpc/kernel/vdso32/sigtramp.o VDSO32A arch/powerpc/kernel/vdso32/gettimeofday.o VDSO32A arch/powerpc/kernel/vdso32/datapage.o VDSO32A arch/powerpc/kernel/vdso32/cacheflush.o AS arch/powerpc/kernel/systbl.o VDSO32A arch/powerpc/kernel/vdso32/note.o CC security/commoncap.o LD crypto/built-in.o CC security/min_addr.o LD block/built-in.o VDSO32L arch/powerpc/kernel/vdso32/vdso32.so.dbg CC kernel/fork.o OBJCOPY arch/powerpc/kernel/vdso32/vdso32.so CC kernel/exec_domain.o AS arch/powerpc/kernel/vdso32/vdso32_wrapper.o CC mm/filemap.o CC kernel/panic.o CC kernel/cpu.o CC kernel/exit.o CC mm/mempool.o LD arch/powerpc/kernel/vdso32/built-in.o LD arch/powerpc/lib/built-in.o CC mm/page-writeback.o CC mm/swap.o CC kernel/capability.o CC kernel/ptrace.o CC mm/truncate.o CC mm/mmu_context.o CC kernel/kthread.o CC kernel/sysctl_binary.o CC mm/shmem.o CC kernel/params.o CC mm/util.o CC mm/vmscan.o CC kernel/signal.o CC kernel/task_work.o CC fs/read_write.o CC mm/page_alloc.o CC kernel/kmod.o LD sound/built-in.o CC mm/readahead.o CC kernel/resource.o CC kernel/workqueue.o CC mm/mmzone.o CC mm/vmstat.o CC kernel/sysctl.o CC mm/mm_init.o CC kernel/softirq.o CC kernel/pid.o CC fs/file_table.o CC kernel/sys.o CC mm/oom_kill.o CC fs/open.o CC mm/percpu.o CC kernel/extable.o CC kernel/user.o CC mm/maccess.o CC mm/slab_common.o CC mm/backing-dev.o CC fs/super.o CC fs/char_dev.o CC kernel/sys_ni.o CC fs/stat.o CC kernel/nsproxy.o CC kernel/notifier.o CC fs/pipe.o CC mm/compaction.o CC fs/exec.o CC kernel/ksysfs.o CC fs/namei.o CC fs/fcntl.o CC kernel/cred.o CC mm/vmacache.o CC fs/ioctl.o CC kernel/reboot.o CC fs/readdir.o LD firmware/built-in.o CC kernel/async.o CC mm/interval_tree.o CC kernel/range.o CC fs/select.o CC kernel/smpboot.o CC mm/list_lru.o CC mm/workingset.o CC fs/dcache.o CC mm/debug.o LD net/built-in.o CC fs/inode.o LD kernel/livepatch/built-in.o CC fs/attr.o CC mm/gup.o CC kernel/dma.o CC kernel/locking/mutex.o CC kernel/up.o CC mm/highmem.o CC kernel/printk/printk.o CC fs/bad_inode.o CC kernel/elfcore.o CC kernel/power/qos.o CC fs/file.o CC kernel/rcu/update.o CC kernel/locking/semaphore.o CC mm/memory.o CC mm/mincore.o CC fs/filesystems.o CC kernel/memremap.o CC kernel/irq/irqdesc.o CC kernel/locking/rwsem.o CC kernel/locking/percpu-rwsem.o CC kernel/rcu/sync.o CC kernel/locking/rwsem-xadd.o CC mm/mlock.o CC kernel/irq/handle.o CC fs/namespace.o CC fs/seq_file.o CC kernel/rcu/tiny.o LD arch/powerpc/mm/built-in.o LD virt/lib/built-in.o CC mm/mmap.o CC kernel/irq/manage.o CC fs/xattr.o CC fs/libfs.o CC kernel/irq/spurious.o CC mm/mprotect.o CC kernel/sched/core.o CC mm/mremap.o CC kernel/sched/loadavg.o CC fs/fs-writeback.o CC kernel/irq/resend.o CC kernel/irq/chip.o CC kernel/sched/clock.o CC mm/msync.o LD virt/built-in.o CC kernel/time/time.o CC fs/pnode.o CC mm/rmap.o CC kernel/irq/dummychip.o CC kernel/sched/cputime.o CC kernel/time/timer.o CC kernel/irq/devres.o CC fs/sync.o CC fs/splice.o CC kernel/sched/idle_task.o CC kernel/time/hrtimer.o CC kernel/irq/irqdomain.o CC mm/vmalloc.o CC kernel/time/itimer.o CC lib/lockref.o CC fs/utimes.o CC kernel/sched/fair.o CC kernel/sched/rt.o CC fs/stack.o CC lib/bcd.o CC lib/div64.o CC fs/fs_struct.o CC kernel/time/posix-timers.o CC mm/pagewalk.o CC kernel/sched/deadline.o CC kernel/time/posix-cpu-timers.o CC mm/pgtable-generic.o CC fs/statfs.o CC kernel/sched/stop_task.o CC kernel/time/timekeeping.o CC fs/fs_pin.o CC lib/parser.o CC kernel/sched/wait.o CC lib/halfmd4.o CC mm/init-mm.o CC lib/sort.o CC mm/nobootmem.o CC lib/debug_locks.o CC fs/no-block.o CC kernel/sched/idle.o LD init/mounts.o CC kernel/sched/completion.o CC fs/nsfs.o CC lib/random32.o CC mm/memblock.o CC kernel/time/clocksource.o CC kernel/time/ntp.o CC lib/bust_spinlocks.o CC mm/dmapool.o CC kernel/time/jiffies.o CC lib/kasprintf.o LD fs/devpts/built-in.o CC mm/slub.o LD fs/exofs/built-in.o CC kernel/time/timer_list.o CC kernel/time/timeconv.o LD init/built-in.o CC kernel/time/timecounter.o CC lib/bitmap.o CC lib/gcd.o CC kernel/time/posix-clock.o CC fs/binfmt_elf.o CC kernel/time/alarmtimer.o LD fs/quota/built-in.o CC lib/lcm.o CC lib/scatterlist.o CC kernel/time/clockevents.o CC lib/list_sort.o CC kernel/time/tick-common.o CC lib/uuid.o CC fs/ramfs/inode.o CC lib/flex_array.o CC lib/clz_ctz.o CC lib/iov_iter.o CC fs/ramfs/file-mmu.o CC lib/bsearch.o CC lib/find_bit.o LD fs/notify/dnotify/built-in.o CC lib/llist.o CC lib/memweight.o LD fs/notify/fanotify/built-in.o LD fs/notify/inotify/built-in.o CC lib/kfifo.o CC lib/percpu-refcount.o CC lib/percpu_ida.o CC lib/rhashtable.o CC lib/reciprocal_div.o CC lib/once.o CC lib/string_helpers.o LD fs/notify/built-in.o CC lib/hexdump.o CC lib/kstrtox.o CC lib/pci_iomap.o LD kernel/rcu/built-in.o CC lib/iomap_copy.o CC lib/devres.o CC lib/hweight.o CC lib/bitrev.o HOSTCC lib/gen_crc32table CC lib/syscall.o CC lib/atomic64.o CC lib/strncpy_from_user.o CC lib/strnlen_user.o LD drivers/amba/built-in.o CC lib/argv_split.o LD drivers/auxdisplay/built-in.o CC lib/cmdline.o LD drivers/block/built-in.o CC lib/ctype.o LD drivers/bus/built-in.o LD drivers/cdrom/built-in.o CC lib/decompress.o CC lib/dec_and_lock.o CC lib/dump_stack.o CC lib/earlycpio.o LD kernel/locking/built-in.o CC lib/extable.o CC lib/fdt.o CC lib/fdt_empty_tree.o CC lib/fdt_ro.o LD drivers/clocksource/built-in.o LD drivers/firewire/built-in.o LD security/built-in.o CC lib/fdt_rw.o CC lib/fdt_strerror.o CC drivers/char/mem.o LD drivers/gpio/built-in.o CC lib/fdt_sw.o CC drivers/char/random.o CC drivers/char/misc.o CC lib/fdt_wip.o CC lib/flex_proportions.o CC lib/idr.o LD drivers/char/agp/built-in.o CC lib/int_sqrt.o LD drivers/clk/bcm/built-in.o LD drivers/firmware/broadcom/built-in.o CC lib/ioremap.o LD drivers/hwtracing/intel_th/built-in.o CC lib/irq_regs.o CC lib/is_single_threaded.o LD drivers/idle/built-in.o CC drivers/base/component.o LD drivers/firmware/built-in.o CC lib/klist.o LD drivers/hsi/controllers/built-in.o LD drivers/lguest/built-in.o LD drivers/leds/built-in.o LD drivers/hsi/clients/built-in.o LD drivers/clk/built-in.o CC lib/kobject.o LD kernel/power/built-in.o CC drivers/base/core.o LD drivers/gpu/vga/built-in.o LD drivers/macintosh/built-in.o CC drivers/base/bus.o CC drivers/irqchip/irqchip.o LD drivers/mfd/built-in.o LD drivers/i2c/algos/built-in.o LD drivers/i2c/busses/built-in.o LD drivers/hsi/built-in.o CC lib/kobject_uevent.o LD drivers/i2c/muxes/built-in.o CC drivers/base/driver.o CC drivers/base/syscore.o CC drivers/base/class.o LD drivers/nfc/built-in.o CC lib/md5.o CC drivers/base/dd.o CC drivers/base/platform.o CC lib/nmi_backtrace.o LD drivers/net/built-in.o CC lib/plist.o LD drivers/mmc/built-in.o CC lib/proportions.o CC drivers/base/cpu.o CC lib/radix-tree.o CC lib/ratelimit.o LD drivers/platform/built-in.o LD drivers/pwm/built-in.o LD drivers/i2c/built-in.o CC drivers/base/firmware.o LD drivers/soc/built-in.o CC drivers/base/init.o LD drivers/gpu/drm/bridge/built-in.o CC lib/rbtree.o LD kernel/printk/built-in.o CC lib/seq_buf.o LD drivers/misc/cb710/built-in.o LD drivers/misc/eeprom/built-in.o CC drivers/of/base.o LD drivers/nvme/host/built-in.o LD drivers/gpu/drm/tilcdc/built-in.o CC drivers/base/map.o CC lib/sha1.o LD drivers/gpu/drm/i2c/built-in.o CC drivers/of/device.o LD drivers/misc/lis3lv02d/built-in.o CC drivers/base/devres.o CC drivers/of/platform.o LD drivers/video/backlight/built-in.o CC drivers/base/attribute_container.o LD drivers/misc/ti-st/built-in.o LD drivers/gpu/drm/panel/built-in.o CC drivers/of/fdt.o CC drivers/base/transport_class.o LD arch/powerpc/kernel/built-in.o LD drivers/usb/host/built-in.o CC drivers/of/fdt_address.o LD drivers/tty/ipwireless/built-in.o CC lib/show_mem.o CC drivers/of/address.o LD drivers/misc/mic/bus/built-in.o CC lib/string.o LD drivers/nvme/built-in.o CC drivers/of/irq.o CC drivers/base/topology.o LD drivers/media/firewire/built-in.o CC lib/timerqueue.o CC drivers/of/of_pci.o CC drivers/base/container.o CC lib/vsprintf.o LD drivers/tty/serial/built-in.o LD drivers/tty/vt/built-in.o LD drivers/usb/built-in.o CC drivers/base/property.o LD drivers/misc/mic/built-in.o LD drivers/gpu/drm/built-in.o CC drivers/base/cacheinfo.o GEN lib/crc32table.h LD drivers/media/i2c/soc_camera/built-in.o CC drivers/of/of_pci_irq.o CC drivers/of/of_reserved_mem.o LD drivers/tty/built-in.o LD drivers/media/tuners/built-in.o CC drivers/base/dma-mapping.o LD drivers/base/power/built-in.o LD drivers/misc/built-in.o LD drivers/media/mmc/siano/built-in.o LD drivers/media/i2c/built-in.o CC lib/crc32.o LD drivers/media/common/b2c2/built-in.o LD drivers/media/platform/omap/built-in.o LD drivers/media/rc/keymaps/built-in.o LD drivers/media/common/saa7146/built-in.o LD fs/ramfs/ramfs.o CC drivers/video/fbdev/core/fb_notify.o LD drivers/media/mmc/built-in.o LD drivers/media/common/siano/built-in.o LD drivers/media/rc/built-in.o LD drivers/media/platform/built-in.o LD fs/ramfs/built-in.o CC drivers/pci/access.o LD drivers/media/common/built-in.o LD drivers/video/fbdev/omap2/displays-new/built-in.o CC drivers/pci/bus.o CC drivers/pci/probe.o LD drivers/gpu/built-in.o CC drivers/pci/host-bridge.o CC drivers/pci/remove.o CC drivers/pci/pci.o LD drivers/media/usb/dvb-usb/built-in.o LD drivers/video/fbdev/omap2/dss/built-in.o LD drivers/media/usb/s2255/built-in.o LD drivers/media/usb/b2c2/built-in.o LD drivers/media/usb/dvb-usb-v2/built-in.o LD drivers/media/usb/siano/built-in.o LD drivers/media/usb/ttusb-budget/built-in.o LD drivers/media/usb/stkwebcam/built-in.o CC drivers/pci/pci-driver.o LD drivers/media/usb/zr364xx/built-in.o LD drivers/video/fbdev/omap2/built-in.o CC drivers/pci/search.o LD drivers/media/usb/ttusb-dec/built-in.o LD drivers/media/pci/ddbridge/built-in.o CC drivers/pci/pci-sysfs.o LD drivers/media/pci/mantis/built-in.o LD drivers/media/pci/netup_unidvb/built-in.o LD drivers/media/usb/built-in.o LD drivers/media/pci/dm1105/built-in.o CC drivers/pci/rom.o LD drivers/media/pci/b2c2/built-in.o LD drivers/media/pci/pluto2/built-in.o LD drivers/media/pci/pt1/built-in.o LD kernel/irq/built-in.o CC drivers/pci/setup-res.o LD drivers/media/pci/ngene/built-in.o LD drivers/media/pci/saa7146/built-in.o LD drivers/media/pci/pt3/built-in.o LD drivers/media/pci/smipcie/built-in.o LD drivers/media/pci/ttpci/built-in.o CC drivers/pci/irq.o LD drivers/media/pci/built-in.o CC drivers/pci/vpd.o LD drivers/media/built-in.o CC drivers/pci/setup-bus.o LD drivers/irqchip/built-in.o CC drivers/pci/vc.o CC drivers/pci/syscall.o CC drivers/pci/of.o LD drivers/pci/host/built-in.o LD drivers/video/fbdev/core/built-in.o LD drivers/video/fbdev/built-in.o LD drivers/video/built-in.o LD drivers/char/built-in.o LD drivers/base/built-in.o LD drivers/of/built-in.o LD kernel/time/built-in.o LD lib/built-in.o LD kernel/sched/built-in.o LD kernel/built-in.o LD mm/built-in.o LD fs/built-in.o AR lib/lib.a LD drivers/pci/built-in.o LD drivers/built-in.o LINK vmlinux LD vmlinux.o MODPOST vmlinux.o GEN .version CHK include/generated/compile.h UPD include/generated/compile.h CC init/version.o LD init/built-in.o LD vmlinux SYSMAP System.map /opt/cross/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-strip -s -R .comment vmlinux -o arch/powerpc/boot/vmlinux.strip make[1]: Leaving directory `/home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc' Completed OK # rm -rf /home/kisskb/slave/build/linus_powerpc-allnoconfig_powerpc # Build took: 0:00:18.791590