Buildresult: powerpc-next/44x/akebono_defconfig/powerpc-gcc4.6 built on Sep 1 2017, 23:43

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Sep 1 2017, 23:43
Duration:	0:00:12.453192
Builder:	ka3
Revision:	powerpc: Rewrite local_t using soft_irq (`eca4a2c7ace942cafbbcf47f860b2062bb4347c4)`
Target:	powerpc-next/44x/akebono_defconfig/powerpc-gcc4.6
Branch:	powerpc-next
Compiler:	powerpc-gcc4.6 (powerpc-linux-gcc (GCC) 4.6.3)
Config:	44x/akebono_defconfig (download)
Log:	Download original Possible errors /home/kisskb/slave/src/arch/powerpc/xmon/xmon.c:3009:2: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration] cc1: all warnings being treated as errors make[2]: * [arch/powerpc/xmon/xmon.o] Error 1 make[1]: * [arch/powerpc/xmon] Error 2 make: *** [sub-make] Error 2 No warnings found in log. Full Log # git rev-parse -q --verify eca4a2c7ace942cafbbcf47f860b2062bb4347c4^{commit} eca4a2c7ace942cafbbcf47f860b2062bb4347c4 already have revision, skipping fetch # git checkout -q -f -B kisskb eca4a2c7ace942cafbbcf47f860b2062bb4347c4 # git clean -qxdf # git log -1 commit eca4a2c7ace942cafbbcf47f860b2062bb4347c4 Author: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> Date: Sun Aug 20 23:28:31 2017 +0530 powerpc: Rewrite local_t using soft_irq Local atomic operations are fast and highly reentrant per CPU counters. Used for percpu variable updates. Local atomic operations only guarantee variable modification atomicity wrt the CPU which owns the data and these needs to be executed in a preemption safe way. Here is the design of this patch. Since local_* operations are only need to be atomic to interrupts (IIUC), we have two options. Either replay the "op" if interrupted or replay the interrupt after the "op". Initial patchset posted was based on implementing local_* operation based on CR5 which replay's the "op". Patchset had issues in case of rewinding the address pointor from an array. This make the slow path really slow. Since CR5 based implementation proposed using __ex_table to find the rewind addressr, this rasied concerns about size of __ex_table and vmlinux. https://lists.ozlabs.org/pipermail/linuxppc-dev/2014-December/123115.html But this patch uses, powerpc_local_irq_pmu_save to soft_disable interrupts (including PMIs). After finishing the "op", powerpc_local_irq_pmu_restore() called and correspondingly interrupts are replayed if any occured. patch re-write the current local_* functions to use arch_local_irq_disable. Base flow for each function is: { powerpc_local_irq_pmu_save(flags) load .. store powerpc_local_irq_pmu_restore(flags) } Reason for the approach is that, currently l[w/d]arx/st[w/d]cx. instruction pair is used for local_* operations, which are heavy on cycle count and they dont support a local variant. So to see whether the new implementation helps, used a modified version of Rusty's benchmark code on local_t. https://lkml.org/lkml/2008/12/16/450 Modifications to Rusty's benchmark code: - Executed only local_t test Here are the values with the patch. Time in ns per iteration Local_t Without Patch With Patch _inc 38 10 _add 38 10 _read 4 4 _add_return 38 10 Currently only asm/local.h has been rewritten, and also the entire change is tested only in PPC64 (pseries guest) and PPC64 host (LE) Patch convert the inline asm implementation of the local_t to C. Also removed the local_dec_if_positive since there are no users for this. Reviewed-by: Nicholas Piggin <npiggin@gmail.com> Signed-off-by: Madhavan Srinivasan <maddy@linux.vnet.ibm.com> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 eca4a2c7ace942cafbbcf47f860b2062bb4347c4 # < make -j 10 ARCH=powerpc O=/home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- 44x/akebono_defconfig # make -j 10 ARCH=powerpc O=/home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- make[1]: Entering directory '/home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc' GEN ./Makefile scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config/kernel.release GEN ./Makefile WRAP arch/powerpc/include/generated/uapi/asm/param.h WRAP arch/powerpc/include/generated/uapi/asm/poll.h WRAP arch/powerpc/include/generated/uapi/asm/resource.h WRAP arch/powerpc/include/generated/uapi/asm/sockios.h WRAP arch/powerpc/include/generated/uapi/asm/statfs.h CHK include/generated/uapi/linux/version.h UPD include/generated/uapi/linux/version.h UPD include/config/kernel.release Using /home/kisskb/slave/src as source for kernel WRAP arch/powerpc/include/generated/asm/clkdev.h WRAP arch/powerpc/include/generated/asm/div64.h WRAP arch/powerpc/include/generated/asm/export.h WRAP arch/powerpc/include/generated/asm/irq_regs.h WRAP arch/powerpc/include/generated/asm/irq_work.h WRAP arch/powerpc/include/generated/asm/local64.h WRAP arch/powerpc/include/generated/asm/mcs_spinlock.h WRAP arch/powerpc/include/generated/asm/preempt.h WRAP arch/powerpc/include/generated/asm/rwsem.h WRAP arch/powerpc/include/generated/asm/vtime.h CHK include/generated/utsrelease.h WRAP arch/powerpc/include/generated/asm/msi.h UPD include/generated/utsrelease.h HOSTCC scripts/dtc/dtc.o HOSTCC scripts/dtc/flattree.o CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig HOSTCC scripts/kallsyms HOSTCC scripts/sortextable CC scripts/mod/devicetable-offsets.s HOSTCC scripts/dtc/fstree.o HOSTCC scripts/dtc/data.o CHK scripts/mod/devicetable-offsets.h UPD scripts/mod/devicetable-offsets.h MKELF scripts/mod/elfconfig.h HOSTCC scripts/mod/modpost.o HOSTCC scripts/dtc/livetree.o HOSTCC scripts/dtc/treesource.o HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o CC kernel/bounds.s CHK include/generated/timeconst.h UPD include/generated/timeconst.h CHK include/generated/bounds.h UPD include/generated/bounds.h HOSTCC scripts/dtc/srcpos.o CC arch/powerpc/kernel/asm-offsets.s HOSTCC scripts/dtc/checks.o HOSTCC scripts/dtc/util.o SHIPPED scripts/dtc/dtc-lexer.lex.c SHIPPED scripts/dtc/dtc-parser.tab.h SHIPPED scripts/dtc/dtc-parser.tab.c HOSTCC scripts/dtc/dtc-lexer.lex.o HOSTCC scripts/dtc/dtc-parser.tab.o CHK include/generated/asm-offsets.h UPD include/generated/asm-offsets.h CALL /home/kisskb/slave/src/scripts/checksyscalls.sh HOSTLD scripts/dtc/dtc HOSTLD scripts/mod/modpost CC init/main.o HOSTCC usr/gen_init_cpio CHK include/generated/compile.h CC init/do_mounts.o CC init/do_mounts_rd.o CC init/do_mounts_initrd.o CC init/initramfs.o CC init/init_task.o UPD include/generated/compile.h CC arch/powerpc/mm/fault.o CC arch/powerpc/kernel/cputable.o AS arch/powerpc/lib/string.o CC arch/powerpc/lib/alloc.o GEN usr/initramfs_data.cpio AS usr/initramfs_data.o AR usr/built-in.o CC arch/powerpc/lib/code-patching.o CC arch/powerpc/kernel/ptrace.o CC arch/powerpc/kernel/syscalls.o CC arch/powerpc/kernel/irq.o CC arch/powerpc/kernel/align.o CC arch/powerpc/mm/mem.o CC arch/powerpc/mm/pgtable.o CC arch/powerpc/mm/mmap.o CC arch/powerpc/lib/feature-fixups.o CC arch/powerpc/sysdev/mpic.o AS arch/powerpc/platforms/44x/misc_44x.o CC arch/powerpc/platforms/4xx/uic.o CC arch/powerpc/platforms/44x/machine_check.o CC init/version.o AS arch/powerpc/lib/div64.o AS arch/powerpc/lib/copy_32.o CC arch/powerpc/mm/init_32.o AS arch/powerpc/lib/crtsavres.o AR arch/powerpc/math-emu/built-in.o AS arch/powerpc/lib/checksum_32.o CC arch/powerpc/lib/checksum_wrappers.o AS arch/powerpc/crypto/sha1-powerpc-asm.o CC arch/powerpc/crypto/sha1.o CC arch/powerpc/platforms/4xx/machine_check.o AR init/mounts.o AR init/built-in.o CC arch/powerpc/platforms/4xx/soc.o CC arch/powerpc/platforms/4xx/pci.o CC arch/powerpc/kernel/signal_32.o CC arch/powerpc/platforms/44x/idle.o CC arch/powerpc/platforms/44x/ppc476.o CC arch/powerpc/lib/sstep.o AR arch/powerpc/net/built-in.o CC arch/powerpc/sysdev/mpic_msi.o CC arch/powerpc/mm/pgtable_32.o CC arch/powerpc/mm/init-common.o CC arch/powerpc/mm/mmu_context.o AR arch/powerpc/crypto/sha1-powerpc.o AR arch/powerpc/crypto/built-in.o CC arch/powerpc/mm/mmu_context_nohash.o AR arch/powerpc/platforms/44x/built-in.o CC arch/powerpc/platforms/4xx/hsta_msi.o CC arch/powerpc/kernel/pmc.o CC arch/powerpc/mm/tlb_nohash.o AS arch/powerpc/lib/ldstfp.o CC arch/powerpc/kernel/vdso.o AS arch/powerpc/lib/quad.o CC arch/powerpc/sysdev/mpic_u3msi.o CC arch/powerpc/kernel/process.o CC arch/powerpc/sysdev/msi_bitmap.o AS arch/powerpc/mm/tlb_nohash_low.o CC arch/powerpc/mm/44x_mmu.o CPP arch/powerpc/kernel/systbl_chk.i AS arch/powerpc/sysdev/dcr-low.o CC arch/powerpc/xmon/xmon.o CC arch/powerpc/xmon/nonstdio.o CC arch/powerpc/mm/hugetlbpage.o AS arch/powerpc/xmon/spr_access.o CC arch/powerpc/kernel/idle.o CC arch/powerpc/mm/highmem.o CC arch/powerpc/sysdev/indirect_pci.o AR arch/powerpc/lib/built-in.o CC arch/powerpc/sysdev/dcr.o /home/kisskb/slave/src/arch/powerpc/xmon/xmon.c: In function 'show_pte': /home/kisskb/slave/src/arch/powerpc/xmon/xmon.c:3009:2: error: implicit declaration of function 'kmap_atomic' [-Werror=implicit-function-declaration] CC arch/powerpc/xmon/ppc-dis.o CC arch/powerpc/perf/callchain.o cc1: all warnings being treated as errors /home/kisskb/slave/src/scripts/Makefile.build:302: recipe for target 'arch/powerpc/xmon/xmon.o' failed make[2]: * [arch/powerpc/xmon/xmon.o] Error 1 make[2]: * Waiting for unfinished jobs.... CC arch/powerpc/perf/perf_regs.o /home/kisskb/slave/src/Makefile:1019: recipe for target 'arch/powerpc/xmon' failed make[1]: * [arch/powerpc/xmon] Error 2 make[1]: * Waiting for unfinished jobs.... CC arch/powerpc/kernel/signal.o CC arch/powerpc/kernel/sysfs.o CC arch/powerpc/kernel/cacheinfo.o CC arch/powerpc/kernel/time.o CC arch/powerpc/kernel/prom.o AR arch/powerpc/mm/built-in.o CC arch/powerpc/kernel/traps.o AR arch/powerpc/sysdev/built-in.o CC arch/powerpc/kernel/setup-common.o CC arch/powerpc/kernel/udbg.o AR arch/powerpc/platforms/4xx/built-in.o AR arch/powerpc/platforms/built-in.o AS arch/powerpc/kernel/misc.o CC arch/powerpc/kernel/io.o AR arch/powerpc/perf/built-in.o CC arch/powerpc/kernel/dma.o AS arch/powerpc/kernel/misc_32.o CC arch/powerpc/kernel/of_platform.o CC arch/powerpc/kernel/prom_parse.o CC arch/powerpc/kernel/trace/trace_clock.o CC arch/powerpc/kernel/proc_powerpc.o AR arch/powerpc/kernel/trace/built-in.o CC arch/powerpc/kernel/smp-tbsync.o LDS arch/powerpc/kernel/vdso32/vdso32.lds VDSO32A arch/powerpc/kernel/vdso32/sigtramp.o CC arch/powerpc/kernel/module.o VDSO32A arch/powerpc/kernel/vdso32/gettimeofday.o VDSO32A arch/powerpc/kernel/vdso32/datapage.o VDSO32A arch/powerpc/kernel/vdso32/cacheflush.o VDSO32A arch/powerpc/kernel/vdso32/note.o VDSO32L arch/powerpc/kernel/vdso32/vdso32.so.dbg OBJCOPY arch/powerpc/kernel/vdso32/vdso32.so AS arch/powerpc/kernel/vdso32/vdso32_wrapper.o AR arch/powerpc/kernel/vdso32/built-in.o CC arch/powerpc/kernel/module_32.o AS arch/powerpc/kernel/cpu_setup_44x.o AS arch/powerpc/kernel/entry_32.o CC arch/powerpc/kernel/setup_32.o CC arch/powerpc/kernel/smp.o CC arch/powerpc/kernel/uprobes.o CC arch/powerpc/kernel/legacy_serial.o CC arch/powerpc/kernel/udbg_16550.o CC arch/powerpc/kernel/stacktrace.o CC arch/powerpc/kernel/dma-swiotlb.o CC arch/powerpc/kernel/pci_32.o CC arch/powerpc/kernel/pci-common.o CC arch/powerpc/kernel/pci_of_scan.o CC arch/powerpc/kernel/msi.o CC arch/powerpc/kernel/iomap.o AS arch/powerpc/kernel/ppc_save_regs.o AS arch/powerpc/kernel/head_44x.o LDS arch/powerpc/kernel/vmlinux.lds AS arch/powerpc/kernel/fpu.o CALL /home/kisskb/slave/src/arch/powerpc/kernel/systbl_chk.sh AS arch/powerpc/kernel/systbl.o AR arch/powerpc/kernel/built-in.o make[1]: Leaving directory '/home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc' Makefile:145: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -j 10 ARCH=powerpc O=/home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /home/kisskb/slave/build/powerpc-next_44x_akebono_defconfig_powerpc # Build took: 0:00:12.453192

© Michael Ellerman 2006-2018.