# git rev-parse -q --verify 020aae3ee58c1af0e7ffc4e2cc9fe4dc630338cb^{commit} 020aae3ee58c1af0e7ffc4e2cc9fe4dc630338cb already have revision, skipping fetch # git checkout -q -f -B kisskb 020aae3ee58c1af0e7ffc4e2cc9fe4dc630338cb # git clean -qxdf # git log -1 commit 020aae3ee58c1af0e7ffc4e2cc9fe4dc630338cb Author: Roberto Sassu Date: Tue Nov 7 11:37:07 2017 +0100 ima: do not update security.ima if appraisal status is not INTEGRITY_PASS Commit b65a9cfc2c38 ("Untangling ima mess, part 2: deal with counters") moved the call of ima_file_check() from may_open() to do_filp_open() at a point where the file descriptor is already opened. This breaks the assumption made by IMA that file descriptors being closed belong to files whose access was granted by ima_file_check(). The consequence is that security.ima and security.evm are updated with good values, regardless of the current appraisal status. For example, if a file does not have security.ima, IMA will create it after opening the file for writing, even if access is denied. Access to the file will be allowed afterwards. Avoid this issue by checking the appraisal status before updating security.ima. Cc: stable@vger.kernel.org Signed-off-by: Roberto Sassu Signed-off-by: Mimi Zohar Signed-off-by: James Morris # < /opt/cross/kisskb/gcc-4.6.3-nolibc/hppa-linux/bin/hppa-linux-gcc --version # < git log --format=%s --max-count=1 020aae3ee58c1af0e7ffc4e2cc9fe4dc630338cb # < make -j 40 ARCH=parisc O=/home/kisskb/slave/build/linus_parisc-allnoconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/hppa-linux/bin/hppa-linux- allnoconfig # make -j 40 ARCH=parisc O=/home/kisskb/slave/build/linus_parisc-allnoconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/hppa-linux/bin/hppa-linux- make[1]: Entering directory '/home/kisskb/slave/build/linus_parisc-allnoconfig_parisc' GEN ./Makefile scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config/kernel.release GEN ./Makefile UPD include/config/kernel.release WRAP arch/parisc/include/generated/uapi/asm/kvm_para.h WRAP arch/parisc/include/generated/uapi/asm/auxvec.h WRAP arch/parisc/include/generated/uapi/asm/param.h WRAP arch/parisc/include/generated/uapi/asm/poll.h WRAP arch/parisc/include/generated/uapi/asm/resource.h CHK include/generated/uapi/linux/version.h UPD include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h UPD include/generated/utsrelease.h Using /home/kisskb/slave/src as source for kernel WRAP arch/parisc/include/generated/asm/barrier.h WRAP arch/parisc/include/generated/asm/clkdev.h WRAP arch/parisc/include/generated/asm/current.h WRAP arch/parisc/include/generated/asm/device.h WRAP arch/parisc/include/generated/asm/div64.h WRAP arch/parisc/include/generated/asm/emergency-restart.h WRAP arch/parisc/include/generated/asm/exec.h WRAP arch/parisc/include/generated/asm/hw_irq.h WRAP arch/parisc/include/generated/asm/irq_regs.h WRAP arch/parisc/include/generated/asm/irq_work.h WRAP arch/parisc/include/generated/asm/kdebug.h WRAP arch/parisc/include/generated/asm/kprobes.h WRAP arch/parisc/include/generated/asm/local.h WRAP arch/parisc/include/generated/asm/mcs_spinlock.h WRAP arch/parisc/include/generated/asm/local64.h WRAP arch/parisc/include/generated/asm/mm-arch-hooks.h WRAP arch/parisc/include/generated/asm/preempt.h WRAP arch/parisc/include/generated/asm/percpu.h WRAP arch/parisc/include/generated/asm/seccomp.h WRAP arch/parisc/include/generated/asm/segment.h WRAP arch/parisc/include/generated/asm/topology.h WRAP arch/parisc/include/generated/asm/trace_clock.h WRAP arch/parisc/include/generated/asm/user.h WRAP arch/parisc/include/generated/asm/vga.h WRAP arch/parisc/include/generated/asm/word-at-a-time.h WRAP arch/parisc/include/generated/asm/xor.h HOSTCC scripts/sortextable CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig CC scripts/mod/devicetable-offsets.s CHK scripts/mod/devicetable-offsets.h UPD scripts/mod/devicetable-offsets.h MKELF scripts/mod/elfconfig.h HOSTCC scripts/mod/modpost.o HOSTCC scripts/mod/file2alias.o HOSTCC scripts/mod/sumversion.o HOSTLD scripts/mod/modpost CC kernel/bounds.s CHK include/generated/timeconst.h UPD include/generated/timeconst.h CHK include/generated/bounds.h UPD include/generated/bounds.h CC arch/parisc/kernel/asm-offsets.s CHK include/generated/asm-offsets.h UPD include/generated/asm-offsets.h CALL /home/kisskb/slave/src/scripts/checksyscalls.sh CC init/main.o CHK include/generated/compile.h CC init/do_mounts.o CC init/noinitramfs.o CC init/calibrate.o CC init/init_task.o AR usr/built-in.o CC arch/parisc/mm/init.o CC arch/parisc/mm/fault.o CC arch/parisc/mm/ioremap.o CC arch/parisc/kernel/cache.o AS arch/parisc/kernel/pacache.o CC arch/parisc/kernel/setup.o CC arch/parisc/kernel/pdt.o CC arch/parisc/kernel/traps.o UPD include/generated/compile.h CC arch/parisc/kernel/time.o CC arch/parisc/kernel/irq.o CC arch/parisc/kernel/pa7300lc.o CC arch/parisc/math-emu/frnd.o AS arch/parisc/kernel/syscall.o AS arch/parisc/kernel/entry.o CC arch/parisc/math-emu/driver.o CC arch/parisc/kernel/sys_parisc.o CC arch/parisc/math-emu/fpudispatch.o CC arch/parisc/math-emu/decode_exc.o CC arch/parisc/kernel/ptrace.o CC arch/parisc/math-emu/sfmpy.o CC arch/parisc/kernel/inventory.o CC arch/parisc/math-emu/dfmpy.o CC arch/parisc/math-emu/dfsqrt.o CC arch/parisc/kernel/drivers.o CC arch/parisc/kernel/hardware.o CC arch/parisc/math-emu/dfadd.o CC arch/parisc/kernel/signal.o CC arch/parisc/math-emu/sfsqrt.o CC arch/parisc/kernel/firmware.o AS arch/parisc/kernel/hpmc.o CC init/version.o AS arch/parisc/kernel/real2.o CC arch/parisc/math-emu/denormal.o CC kernel/fork.o AR certs/built-in.o CC arch/parisc/kernel/parisc_ksyms.o CC arch/parisc/math-emu/fmpyfadd.o CC kernel/exec_domain.o CC kernel/panic.o CC kernel/cpu.o CC kernel/exit.o CC arch/parisc/kernel/unaligned.o CC arch/parisc/math-emu/sfadd.o CC arch/parisc/kernel/process.o CC arch/parisc/math-emu/dfsub.o CC arch/parisc/math-emu/sfsub.o CC arch/parisc/math-emu/fcnvfxt.o CC arch/parisc/kernel/processor.o CC arch/parisc/math-emu/fcnvff.o CC arch/parisc/math-emu/fcnvxf.o CC arch/parisc/math-emu/fcnvfx.o CC arch/parisc/math-emu/fcnvuf.o CC arch/parisc/math-emu/fcnvfu.o CC arch/parisc/math-emu/fcnvfut.o CC mm/filemap.o CC mm/mempool.o CC mm/oom_kill.o CC mm/maccess.o CC arch/parisc/kernel/pdc_cons.o CC arch/parisc/kernel/pdc_chassis.o CC arch/parisc/kernel/unwind.o CC arch/parisc/kernel/pci-dma.o AS arch/parisc/kernel/head.o CC arch/parisc/math-emu/dfdiv.o CC arch/parisc/math-emu/sfdiv.o LDS arch/parisc/kernel/vmlinux.lds CC mm/page_alloc.o CC arch/parisc/math-emu/dfrem.o CC fs/open.o AR ipc/built-in.o CC kernel/softirq.o CC security/commoncap.o CC fs/read_write.o CC fs/file_table.o CC security/min_addr.o CC fs/super.o CC arch/parisc/math-emu/sfrem.o CC mm/page-writeback.o CC arch/parisc/math-emu/dfcmp.o CC fs/char_dev.o CC fs/stat.o CC fs/exec.o CC mm/readahead.o CC fs/pipe.o CC arch/parisc/math-emu/sfcmp.o CC fs/namei.o CC mm/swap.o CC mm/truncate.o CC fs/fcntl.o CC mm/vmscan.o CC mm/shmem.o CC fs/ioctl.o CC mm/util.o CC mm/mmzone.o CC mm/vmstat.o CC fs/readdir.o CC fs/select.o CC fs/dcache.o CC fs/inode.o CC fs/attr.o CC fs/bad_inode.o AR arch/parisc/mm/built-in.o CC fs/file.o AR init/mounts.o CC fs/filesystems.o AR init/built-in.o AR block/built-in.o AR crypto/built-in.o CC mm/backing-dev.o AR drivers/amba/built-in.o AR sound/built-in.o AR drivers/auxdisplay/built-in.o CC kernel/resource.o CC drivers/base/component.o AR arch/parisc/kernel/built-in.o CC mm/mm_init.o CC fs/namespace.o AR firmware/built-in.o CC fs/seq_file.o AR drivers/block/built-in.o AR net/built-in.o CC drivers/base/core.o CC drivers/base/bus.o AR arch/parisc/math-emu/built-in.o CC drivers/base/dd.o CC drivers/base/syscore.o CC mm/mmu_context.o CC drivers/base/driver.o CC drivers/base/class.o CC lib/lockref.o CC lib/bcd.o CC fs/xattr.o CC lib/div64.o AR drivers/bus/built-in.o CC fs/libfs.o AR drivers/cdrom/built-in.o CC kernel/sysctl.o CC lib/sort.o CC fs/fs-writeback.o CC kernel/sysctl_binary.o CC fs/pnode.o CC lib/parser.o CC lib/debug_locks.o CC lib/random32.o CC lib/bust_spinlocks.o CC fs/splice.o CC drivers/base/platform.o AR security/built-in.o CC arch/parisc/lib/iomap.o CC arch/parisc/lib/bitops.o CC arch/parisc/lib/checksum.o CC arch/parisc/lib/delay.o CC mm/percpu.o CC arch/parisc/lib/io.o CC drivers/base/cpu.o CC kernel/capability.o AS arch/parisc/lib/lusercopy.o CC drivers/base/firmware.o CC drivers/base/init.o CC drivers/base/map.o CC drivers/base/devres.o CC drivers/base/attribute_container.o CC lib/kasprintf.o CC arch/parisc/lib/memcpy.o CC lib/bitmap.o CC lib/scatterlist.o CC lib/gcd.o CC fs/sync.o CC fs/utimes.o CC arch/parisc/lib/memset.o CC fs/stack.o CC fs/fs_struct.o CC fs/statfs.o CC fs/fs_pin.o CC fs/nsfs.o CC drivers/base/transport_class.o CC lib/lcm.o CC drivers/base/topology.o CC fs/no-block.o AR fs/devpts/built-in.o CC lib/list_sort.o CC mm/slab_common.o CC mm/compaction.o CC mm/vmacache.o CC mm/swap_slots.o CC mm/interval_tree.o CC mm/list_lru.o CC mm/workingset.o CC mm/debug.o CC mm/gup.o CC kernel/ptrace.o CC drivers/base/container.o CC lib/uuid.o CC lib/flex_array.o CC drivers/base/property.o AR fs/exofs/built-in.o CC mm/highmem.o CC arch/parisc/lib/ucmpdi2.o AR fs/notify/fanotify/built-in.o AR fs/notify/dnotify/built-in.o AR fs/notify/inotify/built-in.o AR fs/quota/built-in.o CC lib/iov_iter.o AR fs/notify/built-in.o CC fs/ramfs/inode.o CC fs/ramfs/file-mmu.o CC lib/clz_ctz.o AR virt/lib/built-in.o AR virt/built-in.o CC lib/bsearch.o CC drivers/char/mem.o CC drivers/char/random.o CC drivers/char/misc.o CC lib/find_bit.o AR drivers/char/agp/built-in.o CC mm/memory.o CC mm/mincore.o CC lib/llist.o CC mm/mlock.o CC drivers/base/cacheinfo.o AR drivers/char/ipmi/built-in.o AR drivers/base/power/built-in.o AR drivers/clk/bcm/built-in.o CC drivers/base/dma-mapping.o AR drivers/base/test/built-in.o CC mm/mmap.o AR drivers/clk/imgtec/built-in.o AR arch/parisc/lib/lib.a AR drivers/clocksource/built-in.o AR drivers/firewire/built-in.o EXPORTS arch/parisc/lib/lib-ksyms.o CC kernel/user.o AR drivers/clk/mvebu/built-in.o CC mm/mprotect.o AR drivers/clk/renesas/built-in.o AR drivers/clk/ti/built-in.o CC lib/memweight.o CC lib/kfifo.o AR drivers/firmware/broadcom/built-in.o AR drivers/clk/built-in.o AR arch/parisc/lib/built-in.o AR drivers/hwtracing/intel_th/built-in.o AR drivers/gpu/drm/amd/lib/built-in.o AR drivers/firmware/meson/built-in.o AR drivers/gpu/drm/hisilicon/built-in.o AR drivers/gpu/drm/bridge/synopsys/built-in.o AR drivers/firmware/tegra/built-in.o AR drivers/gpu/drm/i2c/built-in.o AR drivers/gpu/drm/tilcdc/built-in.o AR drivers/firmware/built-in.o AR drivers/gpu/drm/bridge/built-in.o AR drivers/gpu/drm/omapdrm/displays/built-in.o CC kernel/signal.o AR drivers/gpu/drm/panel/built-in.o AR drivers/idle/built-in.o AR drivers/gpu/drm/omapdrm/dss/built-in.o CC kernel/sys.o CC lib/percpu-refcount.o AR drivers/i2c/algos/built-in.o AR drivers/gpu/drm/omapdrm/built-in.o AR drivers/irqchip/built-in.o AR drivers/macintosh/built-in.o AR drivers/gpu/drm/built-in.o AR drivers/mfd/built-in.o AR drivers/gpu/vga/built-in.o AR drivers/media/common/b2c2/built-in.o AR drivers/i2c/busses/built-in.o AR drivers/media/common/saa7146/built-in.o AR drivers/gpu/built-in.o AR drivers/mmc/built-in.o AR drivers/media/common/siano/built-in.o AR drivers/media/common/v4l2-tpg/built-in.o AR drivers/i2c/muxes/built-in.o AR drivers/misc/cb710/built-in.o AR drivers/media/common/built-in.o AR drivers/i2c/built-in.o AR drivers/misc/eeprom/built-in.o CC lib/percpu_ida.o AR drivers/nfc/built-in.o AR drivers/misc/lis3lv02d/built-in.o AR drivers/net/phy/built-in.o AR drivers/media/firewire/built-in.o CC drivers/parisc/power.o AR drivers/nvme/host/built-in.o AR drivers/net/built-in.o AR drivers/misc/ti-st/built-in.o AR drivers/media/i2c/soc_camera/built-in.o CC mm/mremap.o AR drivers/media/mmc/siano/built-in.o AR drivers/misc/mic/bus/built-in.o AR drivers/media/pci/b2c2/built-in.o AR drivers/media/mmc/built-in.o AR drivers/media/i2c/built-in.o AR drivers/misc/mic/built-in.o AR drivers/nvme/target/built-in.o AR drivers/media/pci/ddbridge/built-in.o CC mm/msync.o AR drivers/nvme/built-in.o AR drivers/media/platform/blackfin/built-in.o AR drivers/misc/built-in.o AR drivers/media/spi/built-in.o AR drivers/media/rc/keymaps/built-in.o AR drivers/media/pci/dm1105/built-in.o CC lib/rhashtable.o AR drivers/media/platform/davinci/built-in.o AR drivers/media/platform/meson/built-in.o AR drivers/media/rc/built-in.o AR drivers/pci/dwc/built-in.o AR drivers/media/pci/mantis/built-in.o AR drivers/media/platform/omap/built-in.o CC kernel/umh.o CC kernel/workqueue.o CC kernel/pid.o AR drivers/media/platform/stm32/built-in.o CC lib/reciprocal_div.o CC kernel/task_work.o CC mm/page_vma_mapped.o CC kernel/extable.o AR drivers/media/platform/built-in.o AR drivers/media/pci/netup_unidvb/built-in.o AR drivers/platform/built-in.o AR drivers/media/pci/ngene/built-in.o AR drivers/media/tuners/built-in.o AR drivers/power/built-in.o CC lib/once.o AR drivers/media/pci/pluto2/built-in.o CC kernel/params.o AR drivers/media/pci/pt1/built-in.o CC kernel/kthread.o AR drivers/media/pci/pt3/built-in.o AR drivers/media/pci/saa7146/built-in.o AR drivers/media/pci/smipcie/built-in.o CC kernel/sys_ni.o AR drivers/media/pci/ttpci/built-in.o AR drivers/media/usb/b2c2/built-in.o AR drivers/media/pci/built-in.o AR fs/ramfs/ramfs.o AR drivers/media/usb/dvb-usb/built-in.o AR fs/ramfs/built-in.o AR drivers/media/usb/dvb-usb-v2/built-in.o AR drivers/media/usb/s2255/built-in.o CC kernel/nsproxy.o AR drivers/media/usb/siano/built-in.o AR drivers/media/usb/stkwebcam/built-in.o CC lib/refcount.o AR drivers/ptp/built-in.o AR drivers/media/usb/ttusb-budget/built-in.o AR drivers/media/usb/ttusb-dec/built-in.o CC mm/pagewalk.o CC lib/usercopy.o CC mm/pgtable-generic.o AR drivers/media/usb/zr364xx/built-in.o AR drivers/pwm/built-in.o AR drivers/media/usb/built-in.o CC mm/rmap.o CC lib/errseq.o CC lib/string_helpers.o AR drivers/media/built-in.o CC drivers/rtc/rtc-lib.o CC mm/vmalloc.o CC mm/init-mm.o CC mm/nobootmem.o CC lib/hexdump.o CC mm/memblock.o AR drivers/parisc/built-in.o CC lib/kstrtox.o AR drivers/soc/bcm/built-in.o AR drivers/soc/fsl/built-in.o CC drivers/rtc/class.o CC kernel/notifier.o AR drivers/soc/mediatek/built-in.o CC lib/pci_iomap.o AR drivers/soc/renesas/built-in.o AR drivers/soc/built-in.o CC lib/iomap_copy.o CC drivers/tty/tty_io.o CC mm/dmapool.o CC drivers/tty/n_tty.o CC kernel/ksysfs.o CC mm/slub.o CC drivers/tty/tty_ioctl.o CC lib/devres.o CC drivers/tty/tty_ldisc.o CC drivers/tty/tty_buffer.o CC lib/hweight.o CC lib/syscall.o CC lib/atomic64.o AR fs/built-in.o CC lib/strncpy_from_user.o CC kernel/cred.o CC drivers/tty/tty_port.o AR drivers/base/built-in.o CC kernel/reboot.o CC kernel/async.o CC lib/argv_split.o CC drivers/tty/tty_mutex.o CC drivers/tty/tty_ldsem.o CC drivers/rtc/interface.o AR drivers/char/built-in.o CC kernel/range.o AR drivers/video/backlight/built-in.o AR drivers/video/fbdev/core/built-in.o CC lib/bug.o CC drivers/rtc/rtc-generic.o CC drivers/tty/tty_baudrate.o AR drivers/video/fbdev/omap2/omapfb/displays/built-in.o AR drivers/video/fbdev/omap2/omapfb/dss/built-in.o CC lib/chacha20.o AR drivers/video/fbdev/omap2/omapfb/built-in.o CC drivers/tty/tty_jobctrl.o AR drivers/video/fbdev/omap2/built-in.o CC drivers/tty/n_null.o AR drivers/video/fbdev/built-in.o CC kernel/smpboot.o CC kernel/ucount.o AR drivers/video/built-in.o CC lib/cmdline.o CC kernel/irq/irqdesc.o AR kernel/livepatch/built-in.o AR drivers/tty/ipwireless/built-in.o AR drivers/tty/serial/built-in.o CC lib/ctype.o AR drivers/tty/vt/built-in.o CC lib/dec_and_lock.o CC lib/decompress.o CC kernel/locking/mutex.o CC kernel/locking/semaphore.o CC kernel/locking/rwsem.o CC lib/dump_stack.o CC kernel/locking/percpu-rwsem.o CC kernel/locking/rwsem-spinlock.o CC lib/earlycpio.o CC lib/extable.o CC kernel/irq/handle.o CC lib/flex_proportions.o CC kernel/irq/manage.o CC lib/idr.o CC lib/int_sqrt.o CC lib/ioremap.o CC kernel/power/qos.o CC kernel/irq/spurious.o CC kernel/irq/resend.o CC kernel/irq/chip.o CC kernel/irq/dummychip.o CC kernel/irq/devres.o CC kernel/irq/autoprobe.o CC lib/irq_regs.o CC kernel/printk/printk.o CC lib/is_single_threaded.o CC lib/klist.o CC lib/kobject.o CC kernel/rcu/update.o CC kernel/sched/core.o CC kernel/sched/loadavg.o CC kernel/sched/clock.o CC lib/kobject_uevent.o CC kernel/rcu/sync.o CC kernel/rcu/tiny.o CC lib/nmi_backtrace.o CC lib/nodemask.o CC lib/plist.o CC kernel/time/time.o CC kernel/up.o CC kernel/memremap.o CC lib/radix-tree.o CC kernel/sched/cputime.o AR drivers/rtc/rtc-core.o AR drivers/rtc/built-in.o CC kernel/sched/idle_task.o CC kernel/sched/fair.o CC kernel/sched/rt.o CC kernel/sched/deadline.o CC lib/ratelimit.o CC kernel/sched/wait.o CC kernel/sched/wait_bit.o CC kernel/sched/swait.o CC lib/rbtree.o CC lib/seq_buf.o CC lib/sha1.o CC lib/show_mem.o CC lib/siphash.o AR kernel/locking/built-in.o CC kernel/sched/completion.o CC kernel/sched/idle.o CC lib/string.o CC lib/timerqueue.o CC lib/vsprintf.o CC lib/win_minmax.o CC kernel/time/timer.o CC kernel/time/hrtimer.o AR kernel/rcu/built-in.o CC kernel/time/timekeeping.o CC kernel/time/ntp.o CC kernel/time/clocksource.o CC kernel/time/jiffies.o CC kernel/time/timer_list.o /home/kisskb/slave/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /home/kisskb/slave/src/kernel/printk/printk.c:186:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] AR kernel/power/built-in.o CC kernel/time/timeconv.o CC kernel/time/timecounter.o CC kernel/time/alarmtimer.o CC kernel/time/posix-stubs.o CC kernel/time/clockevents.o CC kernel/time/tick-common.o CC kernel/time/sched_clock.o AR kernel/printk/built-in.o AR drivers/tty/built-in.o AR drivers/built-in.o AR kernel/irq/built-in.o AR mm/built-in.o AR kernel/sched/built-in.o AR lib/lib.a EXPORTS lib/lib-ksyms.o AR lib/built-in.o AR kernel/time/built-in.o AR kernel/built-in.o GEN .version CHK include/generated/compile.h AR built-in.o LD vmlinux.o MODPOST vmlinux.o LD vmlinux SORTEX vmlinux SYSMAP System.map make[1]: Leaving directory '/home/kisskb/slave/build/linus_parisc-allnoconfig_parisc' Completed OK # rm -rf /home/kisskb/slave/build/linus_parisc-allnoconfig_parisc # Build took: 0:00:07.995164