Buildresult: linus/i386-randconfig/i386-gcc4.6 built on Dec 17 2017, 02:12

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Dec 17 2017, 02:12
Duration:	0:00:05.171753
Builder:	ka1
Revision:	Revert "mm: replace p??_write with pte_access_permitted in fault + gup paths" (`f6f3732162b5ae3c771b9285a5a32d72b8586920)`
Target:	linus/i386-randconfig/i386-gcc4.6
Branch:	linus
Compiler:	i386-gcc4.6 (i386-linux-gcc (GCC) 4.6.3)
Config:	randconfig (download)
Log:	Download original Possible errors make[1]: * [prepare-compiler-check] Error 1 make: * [sub-make] Error 2 No warnings found in log. Full Log # git rev-parse -q --verify f6f3732162b5ae3c771b9285a5a32d72b8586920^{commit} f6f3732162b5ae3c771b9285a5a32d72b8586920 already have revision, skipping fetch # git checkout -q -f -B kisskb f6f3732162b5ae3c771b9285a5a32d72b8586920 # git clean -qxdf # git log -1 commit f6f3732162b5ae3c771b9285a5a32d72b8586920 Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri Dec 15 18:53:22 2017 -0800 Revert "mm: replace p??_write with pte_access_permitted in fault + gup paths" This reverts commits 5c9d2d5c269c, c7da82b894e9, and e7fe7b5cae90. We'll probably need to revisit this, but basically we should not complicate the get_user_pages_fast() case, and checking the actual page table protection key bits will require more care anyway, since the protection keys depend on the exact state of the VM in question. Particularly when doing a "remote" page lookup (ie in somebody elses VM, not your own), you need to be much more careful than this was. Dave Hansen says: "So, the underlying bug here is that we now a get_user_pages_remote() and then go ahead and do the p_access_permitted() checks against the current PKRU. This was introduced recently with the addition of the new p??_access_permitted() calls. We have checks in the VMA path for the "remote" gups and we avoid consulting PKRU for them. This got missed in the pkeys selftests because I did a ptrace read, but not a write. I also didn't explicitly test it against something where a COW needed to be done" It's also not entirely clear that it makes sense to check the protection key bits at this level at all. But one possible eventual solution is to make the get_user_pages_fast() case just abort if it sees protection key bits set, which makes us fall back to the regular get_user_pages() case, which then has a vma and can do the check there if we want to. We'll see. Somewhat related to this all: what we _do_ want to do some day is to check the PAGE_USER bit - it should obviously always be set for user pages, but it would be a good check to have back. Because we have no generic way to test for it, we lost it as part of moving over from the architecture-specific x86 GUP implementation to the generic one in commit e585513b76f7 ("x86/mm/gup: Switch GUP to the generic get_user_page_fast() implementation"). Cc: Peter Zijlstra <peterz@infradead.org> Cc: Dan Williams <dan.j.williams@intel.com> Cc: Dave Hansen <dave.hansen@intel.com> Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Al Viro <viro@zeniv.linux.org.uk> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < git log --format=%s --max-count=1 f6f3732162b5ae3c771b9285a5a32d72b8586920 # < make -j 48 ARCH=i386 O=/home/kisskb/slave/build/linus_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- randconfig KCONFIG_SEED=0xEF428EF4 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # yes \n \| make -j 48 ARCH=i386 O=/home/kisskb/slave/build/linus_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -j 48 ARCH=i386 O=/home/kisskb/slave/build/linus_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- make[1]: Entering directory '/home/kisskb/slave/build/linus_i386-randconfig_i386' GEN ./Makefile scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config/kernel.release SYSTBL arch/x86/include/generated/asm/syscalls_32.h SYSHDR arch/x86/include/generated/uapi/asm/unistd_32.h HOSTCC scripts/basic/bin2c SYSHDR arch/x86/include/generated/uapi/asm/unistd_64.h SYSHDR arch/x86/include/generated/uapi/asm/unistd_x32.h Cannot use CONFIG_CC_STACKPROTECTOR_REGULAR: -fstack-protector available but compiler is broken /home/kisskb/slave/src/Makefile:1094: recipe for target 'prepare-compiler-check' failed make[1]: [prepare-compiler-check] Error 1 make[1]: * Waiting for unfinished jobs.... UPD include/config/kernel.release make[1]: * wait: No child processes. Stop. Makefile:146: recipe for target 'sub-make' failed make: * [sub-make] Error 2 Command 'make -j 48 ARCH=i386 O=/home/kisskb/slave/build/linus_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- ' returned non-zero exit status 2 # rm -rf /home/kisskb/slave/build/linus_i386-randconfig_i386 # Build took: 0:00:05.171753

© Michael Ellerman 2006-2018.