Buildresult: linus/TCM-BF518_defconfig/bfin built on Feb 4 2018, 08:28

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	Failed
Date/Time:	Feb 4 2018, 08:28
Duration:	0:00:05.927770
Builder:	ka3
Revision:	pinctrl: remove include file from <linux/device.h> (`23c35f48f5fbe33f68904138b23fee64df7d2f0f)`
Target:	linus/TCM-BF518_defconfig/bfin
Branch:	linus
Compiler:	bfin (bfin-uclinux-gcc (GCC) 4.6.3)
Config:	TCM-BF518_defconfig (download)
Log:	Download original Possible errors cc1: error: -mcpu=bf518-0.1 has invalid silicon revision cc1: error: unrecognized command line option '-mcpu=bf518-0.1' make[3]: * [scripts/mod/empty.o] Error 1 cc1: error: -mcpu=bf518-0.1 has invalid silicon revision cc1: error: unrecognized command line option '-mcpu=bf518-0.1' make[3]: * [scripts/mod/devicetable-offsets.s] Error 1 make[2]: * [scripts/mod] Error 2 make[1]: * [scripts] Error 2 make: *** [sub-make] Error 2 No warnings found in log. Full Log # git rev-parse -q --verify 23c35f48f5fbe33f68904138b23fee64df7d2f0f^{commit} 23c35f48f5fbe33f68904138b23fee64df7d2f0f already have revision, skipping fetch # git checkout -q -f -B kisskb 23c35f48f5fbe33f68904138b23fee64df7d2f0f # git clean -qxdf # git log -1 commit 23c35f48f5fbe33f68904138b23fee64df7d2f0f Author: Linus Torvalds <torvalds@linux-foundation.org> Date: Fri Feb 2 16:44:14 2018 -0800 pinctrl: remove include file from <linux/device.h> When pulling the recent pinctrl merge, I was surprised by how a pinctrl-only pull request ended up rebuilding basically the whole kernel. The reason for that ended up being that <linux/device.h> included <linux/pinctrl/devinfo.h>, so any change to that file ended up causing pretty much every driver out there to be rebuilt. The reason for that was because 'struct device' has this in it: #ifdef CONFIG_PINCTRL struct dev_pin_info pins; #endif but we already avoid header includes for these kinds of things in that header file, preferring to just use a forward-declaration of the structure instead. Exactly to avoid this kind of header dependency. Since some drivers seem to expect that <linux/pinctrl/devinfo.h> header to come in automatically, move the include to <linux/pinctrl/pinctrl.h> instead. It might be better to just make the includes more targeted, but I'm not going to review every driver. It would definitely be good to have a tool for finding and minimizing header dependencies automatically - or at least help with them. Right now we almost certainly end up having way too many of these things, and it's hard to test every single configuration. FWIW, you can get a sense of the "hotness" of a header file with something like this after doing a full build: find . -name '..o.cmd' -print0 \| xargs -0 tail --lines=+2 \| grep -v 'wildcard ' \| tr ' \\' '\n' \| sort \| uniq -c \| sort -n \| less -S which isn't exact (there are other things in those '.o.cmd' than just the dependencies, and the "--lines=+2" only removes the header), but might a useful approximation. With this patch, <linux/pinctrl/devinfo.h> drops to "only" having 833 users in the current x86-64 allmodconfig. In contrast, <linux/device.h> has 14857 build files including it directly or indirectly. Of course, the headers that absolutely _everybody_ includes (things like <linux/types.h> etc) get a score of 23000+. Cc: Linus Walleij <linus.walleij@linaro.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux-gcc --version # < git log --format=%s --max-count=1 23c35f48f5fbe33f68904138b23fee64df7d2f0f # < make -j 80 ARCH=blackfin O=/home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux- TCM-BF518_defconfig # make -j 80 ARCH=blackfin O=/home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux- make[1]: Entering directory '/home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin' GEN ./Makefile scripts/kconfig/conf --silentoldconfig Kconfig CHK include/config/kernel.release GEN ./Makefile WRAP arch/blackfin/include/generated/uapi/asm/auxvec.h WRAP arch/blackfin/include/generated/uapi/asm/bitsperlong.h WRAP arch/blackfin/include/generated/uapi/asm/bpf_perf_event.h WRAP arch/blackfin/include/generated/uapi/asm/errno.h WRAP arch/blackfin/include/generated/uapi/asm/ioctl.h WRAP arch/blackfin/include/generated/uapi/asm/ipcbuf.h WRAP arch/blackfin/include/generated/uapi/asm/kvm_para.h WRAP arch/blackfin/include/generated/uapi/asm/mman.h CHK include/generated/uapi/linux/version.h WRAP arch/blackfin/include/generated/uapi/asm/msgbuf.h WRAP arch/blackfin/include/generated/uapi/asm/param.h WRAP arch/blackfin/include/generated/uapi/asm/resource.h WRAP arch/blackfin/include/generated/uapi/asm/sembuf.h WRAP arch/blackfin/include/generated/uapi/asm/setup.h UPD include/generated/uapi/linux/version.h WRAP arch/blackfin/include/generated/uapi/asm/shmbuf.h WRAP arch/blackfin/include/generated/uapi/asm/shmparam.h WRAP arch/blackfin/include/generated/uapi/asm/socket.h WRAP arch/blackfin/include/generated/uapi/asm/sockios.h WRAP arch/blackfin/include/generated/uapi/asm/statfs.h WRAP arch/blackfin/include/generated/uapi/asm/termbits.h WRAP arch/blackfin/include/generated/uapi/asm/termios.h WRAP arch/blackfin/include/generated/uapi/asm/types.h WRAP arch/blackfin/include/generated/uapi/asm/ucontext.h HOSTCC scripts/basic/bin2c UPD include/config/kernel.release Using /home/kisskb/slave/src as source for kernel WRAP arch/blackfin/include/generated/asm/bugs.h WRAP arch/blackfin/include/generated/asm/current.h WRAP arch/blackfin/include/generated/asm/device.h WRAP arch/blackfin/include/generated/asm/div64.h WRAP arch/blackfin/include/generated/asm/emergency-restart.h WRAP arch/blackfin/include/generated/asm/extable.h WRAP arch/blackfin/include/generated/asm/fb.h WRAP arch/blackfin/include/generated/asm/futex.h WRAP arch/blackfin/include/generated/asm/hw_irq.h WRAP arch/blackfin/include/generated/asm/irq_regs.h WRAP arch/blackfin/include/generated/asm/irq_work.h WRAP arch/blackfin/include/generated/asm/kdebug.h WRAP arch/blackfin/include/generated/asm/kmap_types.h WRAP arch/blackfin/include/generated/asm/kprobes.h WRAP arch/blackfin/include/generated/asm/local.h WRAP arch/blackfin/include/generated/asm/local64.h WRAP arch/blackfin/include/generated/asm/mcs_spinlock.h WRAP arch/blackfin/include/generated/asm/mm-arch-hooks.h WRAP arch/blackfin/include/generated/asm/percpu.h WRAP arch/blackfin/include/generated/asm/pgalloc.h WRAP arch/blackfin/include/generated/asm/preempt.h WRAP arch/blackfin/include/generated/asm/serial.h WRAP arch/blackfin/include/generated/asm/topology.h WRAP arch/blackfin/include/generated/asm/trace_clock.h WRAP arch/blackfin/include/generated/asm/unaligned.h CHK include/generated/utsrelease.h WRAP arch/blackfin/include/generated/asm/user.h WRAP arch/blackfin/include/generated/asm/word-at-a-time.h WRAP arch/blackfin/include/generated/asm/xor.h UPD include/generated/utsrelease.h HOSTCC scripts/kallsyms HOSTCC scripts/conmakehash CC scripts/mod/empty.o HOSTCC scripts/mod/mk_elfconfig CC scripts/mod/devicetable-offsets.s cc1: error: -mcpu=bf518-0.1 has invalid silicon revision cc1: error: unrecognized command line option '-mcpu=bf518-0.1' /home/kisskb/slave/src/scripts/Makefile.build:316: recipe for target 'scripts/mod/empty.o' failed make[3]: [scripts/mod/empty.o] Error 1 make[3]: * Waiting for unfinished jobs.... cc1: error: -mcpu=bf518-0.1 has invalid silicon revision cc1: error: unrecognized command line option '-mcpu=bf518-0.1' /home/kisskb/slave/src/scripts/Makefile.build:150: recipe for target 'scripts/mod/devicetable-offsets.s' failed make[3]: * [scripts/mod/devicetable-offsets.s] Error 1 /home/kisskb/slave/src/scripts/Makefile.build:575: recipe for target 'scripts/mod' failed make[2]: * [scripts/mod] Error 2 make[2]: * Waiting for unfinished jobs.... /home/kisskb/slave/src/Makefile:558: recipe for target 'scripts' failed make[1]: * [scripts] Error 2 make[1]: Leaving directory '/home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin' Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -j 80 ARCH=blackfin O=/home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/bfin-uclinux/bin/bfin-uclinux- ' returned non-zero exit status 2 # rm -rf /home/kisskb/slave/build/linus_TCM-BF518_defconfig_bfin # Build took: 0:00:05.927770

© Michael Ellerman 2006-2018.