# git rev-parse -q --verify b6fbf9e64995137a57c19b0aa7f6c76c727439dc^{commit}
b6fbf9e64995137a57c19b0aa7f6c76c727439dc
already have revision, skipping fetch
# git checkout -q -f -B kisskb b6fbf9e64995137a57c19b0aa7f6c76c727439dc
# git clean -qxdf
# git log -1
commit b6fbf9e64995137a57c19b0aa7f6c76c727439dc
Author: Alistair Popple <alistair@popple.id.au>
Date:   Fri Mar 2 16:18:45 2018 +1100

    powerpc/powernv/npu: Fix deadlock in mmio_invalidate()
    
    When sending TLB invalidates to the NPU we need to send extra flushes due
    to a hardware issue. The original implementation would lock the all the
    ATSD MMIO registers sequentially before unlocking and relocking each of
    them sequentially to do the extra flush.
    
    This introduced a deadlock as it is possible for one thread to hold one
    ATSD register whilst waiting for another register to be freed while the
    other thread is holding that register waiting for the one in the first
    thread to be freed.
    
    For example if there are two threads and two ATSD registers:
    
      Thread A	Thread B
      ----------------------
      Acquire 1
      Acquire 2
      Release 1	Acquire 1
      Wait 1	Wait 2
    
    Both threads will be stuck waiting to acquire a register resulting in an
    RCU stall warning or soft lockup.
    
    This patch solves the deadlock by refactoring the code to ensure registers
    are not released between flushes and to ensure all registers are either
    acquired or released together and in order.
    
    Fixes: bbd5ff50afff ("powerpc/powernv/npu-dma: Add explicit flush when sending an ATSD")
    Signed-off-by: Alistair Popple <alistair@popple.id.au>
    Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < git log --format=%s --max-count=1 b6fbf9e64995137a57c19b0aa7f6c76c727439dc
# < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_cell_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  cell_defconfig
# make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_cell_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1439:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields':
/kisskb/src/kernel/rcu/srcutree.c:146:32: warning: 'levelspread[<U33c0>]' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[<U33c0>]' was declared here
/kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount':
/kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq':
/kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here
/kisskb/src/drivers/net/tun.c: In function 'tun_get_user':
/kisskb/src/drivers/net/tun.c:1816:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1726:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized]
Completed OK
# rm -rf /kisskb/build/powerpc-next_cell_defconfig_powerpc
# Build took: 0:01:05.914567