Buildresult: powerpc-next/52xx/cm5200_defconfig/powerpc-gcc4.6 built on Mar 7 2018, 23:50

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Mar 7 2018, 23:50
Duration:	0:00:34.700095
Builder:	ka3
Revision:	powerpc/powernv/npu: Fix deadlock in mmio_invalidate() (`b6fbf9e64995137a57c19b0aa7f6c76c727439dc)`
Target:	powerpc-next/52xx/cm5200_defconfig/powerpc-gcc4.6
Branch:	powerpc-next
Compiler:	powerpc-gcc4.6 (powerpc-linux-gcc (GCC) 4.6.3)
Config:	52xx/cm5200_defconfig (download)
Log:	Download original Possible warnings (2) RCU stall warning or soft lockup. kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] Full Log # git rev-parse -q --verify b6fbf9e64995137a57c19b0aa7f6c76c727439dc^{commit} b6fbf9e64995137a57c19b0aa7f6c76c727439dc already have revision, skipping fetch # git checkout -q -f -B kisskb b6fbf9e64995137a57c19b0aa7f6c76c727439dc # git clean -qxdf # git log -1 commit b6fbf9e64995137a57c19b0aa7f6c76c727439dc Author: Alistair Popple <alistair@popple.id.au> Date: Fri Mar 2 16:18:45 2018 +1100 powerpc/powernv/npu: Fix deadlock in mmio_invalidate() When sending TLB invalidates to the NPU we need to send extra flushes due to a hardware issue. The original implementation would lock the all the ATSD MMIO registers sequentially before unlocking and relocking each of them sequentially to do the extra flush. This introduced a deadlock as it is possible for one thread to hold one ATSD register whilst waiting for another register to be freed while the other thread is holding that register waiting for the one in the first thread to be freed. For example if there are two threads and two ATSD registers: Thread A Thread B ---------------------- Acquire 1 Acquire 2 Release 1 Acquire 1 Wait 1 Wait 2 Both threads will be stuck waiting to acquire a register resulting in an RCU stall warning or soft lockup. This patch solves the deadlock by refactoring the code to ensure registers are not released between flushes and to ensure all registers are either acquired or released together and in order. Fixes: bbd5ff50afff ("powerpc/powernv/npu-dma: Add explicit flush when sending an ATSD") Signed-off-by: Alistair Popple <alistair@popple.id.au> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 b6fbf9e64995137a57c19b0aa7f6c76c727439dc # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_52xx_cm5200_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- 52xx/cm5200_defconfig # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_52xx_cm5200_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] INFO: Uncompressed kernel (size 0x4b4cc8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x500000) Image Name: Linux-4.16.0-rc4-gb6fbf9e Created: Wed Mar 7 23:51:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2385901 Bytes = 2329.98 kB = 2.28 MB Load Address: 00000000 Entry Point: 00000000 Completed OK # rm -rf /kisskb/build/powerpc-next_52xx_cm5200_defconfig_powerpc # Build took: 0:00:34.700095

© Michael Ellerman 2006-2018.