# git rev-parse -q --verify ed16e99272308afe183d983523bf995e8a517026^{commit}
ed16e99272308afe183d983523bf995e8a517026
already have revision, skipping fetch
# git checkout -q -f -B kisskb ed16e99272308afe183d983523bf995e8a517026
# git clean -qxdf
# < git log -1
# commit ed16e99272308afe183d983523bf995e8a517026
# Author: Michael Neuling <mikey@neuling.org>
# Date:   Mon Mar 26 15:17:07 2018 +1100
# 
#     powerpc/eeh: Fix race with driver un/bind
#     
#     The current EEH callbacks can race with a driver unbind. This can
#     result in a backtraces like this:
#     
#       EEH: Frozen PHB#0-PE#1fc detected
#       EEH: PE location: S000009, PHB location: N/A
#       CPU: 2 PID: 2312 Comm: kworker/u258:3 Not tainted 4.15.6-openpower1 #2
#       Workqueue: nvme-wq nvme_reset_work [nvme]
#       Call Trace:
#         dump_stack+0x9c/0xd0 (unreliable)
#         eeh_dev_check_failure+0x420/0x470
#         eeh_check_failure+0xa0/0xa4
#         nvme_reset_work+0x138/0x1414 [nvme]
#         process_one_work+0x1ec/0x328
#         worker_thread+0x2e4/0x3a8
#         kthread+0x14c/0x154
#         ret_from_kernel_thread+0x5c/0xc8
#       nvme nvme1: Removing after probe failure status: -19
#       <snip>
#       cpu 0x23: Vector: 300 (Data Access) at [c000000ff50f3800]
#           pc: c0080000089a0eb0: nvme_error_detected+0x4c/0x90 [nvme]
#           lr: c000000000026564: eeh_report_error+0xe0/0x110
#           sp: c000000ff50f3a80
#          msr: 9000000000009033
#          dar: 400
#        dsisr: 40000000
#         current = 0xc000000ff507c000
#         paca    = 0xc00000000fdc9d80   softe: 0        irq_happened: 0x01
#           pid   = 782, comm = eehd
#       Linux version 4.15.6-openpower1 (smc@smc-desktop) (gcc version 6.4.0 (Buildroot 2017.11.2-00008-g4b6188e)) #2 SM                                             P Tue Feb 27 12:33:27 PST 2018
#       enter ? for help
#         eeh_report_error+0xe0/0x110
#         eeh_pe_dev_traverse+0xc0/0xdc
#         eeh_handle_normal_event+0x184/0x4c4
#         eeh_handle_event+0x30/0x288
#         eeh_event_handler+0x124/0x170
#         kthread+0x14c/0x154
#         ret_from_kernel_thread+0x5c/0xc8
#     
#     The first part is an EEH (on boot), the second half is the resulting
#     crash. nvme probe starts the nvme_reset_work() worker thread. This
#     worker thread starts touching the device which see a device error
#     (EEH) and hence queues up an event in the powerpc EEH worker
#     thread. nvme_reset_work() then continues and runs
#     nvme_remove_dead_ctrl_work() which results in unbinding the driver
#     from the device and hence releases all resources. At the same time,
#     the EEH worker thread starts doing the EEH .error_detected() driver
#     callback, which no longer works since the resources have been freed.
#     
#     This fixes the problem in the same way the generic PCIe AER code (in
#     drivers/pci/pcie/aer/aerdrv_core.c) does. It makes the EEH code hold
#     the device_lock() while performing the driver EEH callbacks and
#     associated code. This ensures either the callbacks are no longer
#     register, or if they are registered the driver will not be removed
#     from underneath us.
#     
#     This has been broken forever. The EEH call backs were first introduced
#     in 2005 (in 77bd7415610) but it's not clear if a lock was needed back
#     then.
#     
#     Fixes: 77bd74156101 ("[PATCH] powerpc: PCI Error Recovery: PPC64 core recovery routines")
#     Cc: stable@vger.kernel.org # v2.6.16+
#     Signed-off-by: Michael Neuling <mikey@neuling.org>
#     Reviewed-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version
# < git log --format=%s --max-count=1 ed16e99272308afe183d983523bf995e8a517026
# < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-allmodconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  allmodconfig
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# Added to kconfig CONFIG_SAMPLES=n
# yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-allmodconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  oldconfig
yes: standard output: Broken pipe
yes: write error
# make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-allmodconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  
/kisskb/src/arch/powerpc/mm/pgtable-radix.c: In function 'stop_machine_change_mapping':
/kisskb/src/arch/powerpc/mm/pgtable-radix.c:771:2: error: too few arguments to function 'create_physical_mapping'
/kisskb/src/arch/powerpc/mm/pgtable-radix.c:268:22: note: declared here
/kisskb/src/arch/powerpc/mm/pgtable-radix.c:772:2: error: too few arguments to function 'create_physical_mapping'
/kisskb/src/arch/powerpc/mm/pgtable-radix.c:268:22: note: declared here
/kisskb/src/scripts/Makefile.build:324: recipe for target 'arch/powerpc/mm/pgtable-radix.o' failed
make[2]: *** [arch/powerpc/mm/pgtable-radix.o] Error 1
make[2]: *** Waiting for unfinished jobs....
/kisskb/src/arch/powerpc/platforms/powernv/idle.c: In function 'pnv_power9_force_smt4_catch':
/kisskb/src/arch/powerpc/platforms/powernv/idle.c:415:11: error: 'paca' undeclared (first use in this function)
/kisskb/src/arch/powerpc/platforms/powernv/idle.c:415:11: note: each undeclared identifier is reported only once for each function it appears in
/kisskb/src/arch/powerpc/platforms/powernv/idle.c: In function 'pnv_power9_force_smt4_release':
/kisskb/src/arch/powerpc/platforms/powernv/idle.c:460:11: error: 'paca' undeclared (first use in this function)
/kisskb/src/scripts/Makefile.build:324: recipe for target 'arch/powerpc/platforms/powernv/idle.o' failed
make[3]: *** [arch/powerpc/platforms/powernv/idle.o] Error 1
make[3]: *** Waiting for unfinished jobs....
/kisskb/src/scripts/Makefile.build:583: recipe for target 'arch/powerpc/platforms/powernv' failed
make[2]: *** [arch/powerpc/platforms/powernv] Error 2
make[2]: *** Waiting for unfinished jobs....
/kisskb/src/Makefile:1051: recipe for target 'arch/powerpc/mm' failed
make[1]: *** [arch/powerpc/mm] Error 2
make[1]: *** Waiting for unfinished jobs....
/kisskb/src/drivers/auxdisplay/img-ascii-lcd.c: In function 'malta_update':
/kisskb/src/drivers/auxdisplay/img-ascii-lcd.c:109:5: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/auxdisplay/img-ascii-lcd.c: In function 'sead3_update':
/kisskb/src/drivers/auxdisplay/img-ascii-lcd.c:207:5: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write':
/kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/Makefile:1051: recipe for target 'arch/powerpc/platforms' failed
make[1]: *** [arch/powerpc/platforms] Error 2
/kisskb/src/mm/swap_state.c: In function '__add_to_swap_cache':
/kisskb/src/mm/swap_state.c:135:5: warning: 'error' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl':
/kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page':
/kisskb/src/mm/hugetlb.c:1439:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
/kisskb/src/arch/powerpc/include/asm/io-defs.h:12:1: warning: 'px_is' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here
/kisskb/src/arch/powerpc/include/asm/io-defs.h:12:1: warning: 'px_cmd' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here
/kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount':
/kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/bridge/br_netlink.c: In function 'br_process_vlan_info':
/kisskb/src/net/bridge/br_netlink.c:577:10: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/f2fs/file.c: In function 'f2fs_precache_extents':
/kisskb/src/fs/f2fs/file.c:2786:6: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_replace':
/kisskb/src/drivers/dma-buf/reservation.c:207:2: warning: 'k' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/dma-buf/reservation.c:210:7: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c: In function '__arm_v7s_map.constprop.5':
/kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:433:7: warning: 'cptep' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/input/joystick/analog.c:176:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp]
/kisskb/src/sound/soc/codecs/arizona.c: In function 'arizona_hw_params':
/kisskb/src/sound/soc/codecs/arizona.c:1889:3: warning: 'aif_rx_state' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/soc/codecs/arizona.c:1886:3: warning: 'aif_tx_state' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/input/rmi4/rmi_f11.c: In function 'rmi_f11_finger_handler':
/kisskb/src/drivers/input/rmi4/rmi_f11.c:631:3: warning: 'abs_fingers' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/btrfs/ref-verify.c: In function 'process_extent_item.isra.0':
/kisskb/src/fs/btrfs/ref-verify.c:516:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/btrfs/ref-verify.c: In function 'process_leaf':
/kisskb/src/fs/btrfs/ref-verify.c:568:2: warning: 'ret' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc':
/kisskb/src/fs/nfsd/nfs4xdr.c:2043:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_handle_pwr_constr.isra.12':
/kisskb/src/net/mac80211/mlme.c:1350:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work':
/kisskb/src/sound/soc/codecs/da7219-aad.c:318:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/soc/codecs/rt5665.c: In function 'rt5665_i2s_pin_event':
/kisskb/src/sound/soc/codecs/rt5665.c:2666:23: warning: 'val2' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/sound/soc/codecs/rt5665.c:2663:23: warning: 'val1' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c: In function 'tun_get_user':
/kisskb/src/drivers/net/tun.c:1816:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/tun.c:1726:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c: In function 'pctv452e_frontend_attach':
/kisskb/src/drivers/media/usb/dvb-usb/pctv452e.c:922:2: warning: value computed is not used [-Wunused-value]
/kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain':
/kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_rf_ctl_override_rev7':
/kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c:202:21: warning: 'val_addr' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
/kisskb/src/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3323:18: warning: 'server_ioba' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3317:18: warning: 'client_ioba' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c: In function 'update_root_ft_create':
/kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/fs_core.c:867:5: warning: 'err' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit':
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:101:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:101:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/staging/lustre/lustre/ptlrpc/nrs.c: In function 'ptlrpc_nrs_policy_register.constprop.1':
/kisskb/src/include/linux/string.h:266:29: warning: array subscript is above array bounds [-Warray-bounds]
/kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8723a_phy_lc_calibrate':
/kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3481:23: warning: 'rf_amode' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c: In function 'nv50_head_lut_load':
/kisskb/src/arch/powerpc/include/asm/io.h:178:1: warning: 'b' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1813:18: note: 'b' was declared here
/kisskb/src/arch/powerpc/include/asm/io.h:178:1: warning: 'g' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1813:15: note: 'g' was declared here
/kisskb/src/arch/powerpc/include/asm/io.h:178:1: warning: 'r' may be used uninitialized in this function [-Wuninitialized]
/kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1813:12: note: 'r' was declared here
Makefile:146: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
Command 'make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-allmodconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-  ' returned non-zero exit status 2
# rm -rf /kisskb/build/powerpc-next_powerpc-allmodconfig_powerpc
# Build took: 0:05:18.848923