# git rev-parse -q --verify ed16e99272308afe183d983523bf995e8a517026^{commit} ed16e99272308afe183d983523bf995e8a517026 already have revision, skipping fetch # git checkout -q -f -B kisskb ed16e99272308afe183d983523bf995e8a517026 # git clean -qxdf # < git log -1 # commit ed16e99272308afe183d983523bf995e8a517026 # Author: Michael Neuling # Date: Mon Mar 26 15:17:07 2018 +1100 # # powerpc/eeh: Fix race with driver un/bind # # The current EEH callbacks can race with a driver unbind. This can # result in a backtraces like this: # # EEH: Frozen PHB#0-PE#1fc detected # EEH: PE location: S000009, PHB location: N/A # CPU: 2 PID: 2312 Comm: kworker/u258:3 Not tainted 4.15.6-openpower1 #2 # Workqueue: nvme-wq nvme_reset_work [nvme] # Call Trace: # dump_stack+0x9c/0xd0 (unreliable) # eeh_dev_check_failure+0x420/0x470 # eeh_check_failure+0xa0/0xa4 # nvme_reset_work+0x138/0x1414 [nvme] # process_one_work+0x1ec/0x328 # worker_thread+0x2e4/0x3a8 # kthread+0x14c/0x154 # ret_from_kernel_thread+0x5c/0xc8 # nvme nvme1: Removing after probe failure status: -19 # # cpu 0x23: Vector: 300 (Data Access) at [c000000ff50f3800] # pc: c0080000089a0eb0: nvme_error_detected+0x4c/0x90 [nvme] # lr: c000000000026564: eeh_report_error+0xe0/0x110 # sp: c000000ff50f3a80 # msr: 9000000000009033 # dar: 400 # dsisr: 40000000 # current = 0xc000000ff507c000 # paca = 0xc00000000fdc9d80 softe: 0 irq_happened: 0x01 # pid = 782, comm = eehd # Linux version 4.15.6-openpower1 (smc@smc-desktop) (gcc version 6.4.0 (Buildroot 2017.11.2-00008-g4b6188e)) #2 SM P Tue Feb 27 12:33:27 PST 2018 # enter ? for help # eeh_report_error+0xe0/0x110 # eeh_pe_dev_traverse+0xc0/0xdc # eeh_handle_normal_event+0x184/0x4c4 # eeh_handle_event+0x30/0x288 # eeh_event_handler+0x124/0x170 # kthread+0x14c/0x154 # ret_from_kernel_thread+0x5c/0xc8 # # The first part is an EEH (on boot), the second half is the resulting # crash. nvme probe starts the nvme_reset_work() worker thread. This # worker thread starts touching the device which see a device error # (EEH) and hence queues up an event in the powerpc EEH worker # thread. nvme_reset_work() then continues and runs # nvme_remove_dead_ctrl_work() which results in unbinding the driver # from the device and hence releases all resources. At the same time, # the EEH worker thread starts doing the EEH .error_detected() driver # callback, which no longer works since the resources have been freed. # # This fixes the problem in the same way the generic PCIe AER code (in # drivers/pci/pcie/aer/aerdrv_core.c) does. It makes the EEH code hold # the device_lock() while performing the driver EEH callbacks and # associated code. This ensures either the callbacks are no longer # register, or if they are registered the driver will not be removed # from underneath us. # # This has been broken forever. The EEH call backs were first introduced # in 2005 (in 77bd7415610) but it's not clear if a lock was needed back # then. # # Fixes: 77bd74156101 ("[PATCH] powerpc: PCI Error Recovery: PPC64 core recovery routines") # Cc: stable@vger.kernel.org # v2.6.16+ # Signed-off-by: Michael Neuling # Reviewed-by: Benjamin Herrenschmidt # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 ed16e99272308afe183d983523bf995e8a517026 # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0x7760A033 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/ipc/shm.c: In function 'SyS_shmdt': /kisskb/src/ipc/shm.c:1565:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c:1487:15: note: 'file' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:269:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:234:28: note: 'next' was declared here /kisskb/src/mm/ksm.c: In function 'stable_node_dup': /kisskb/src/mm/ksm.c:1358:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/memcontrol.c: In function 'commit_charge': /kisskb/src/mm/memcontrol.c:2077:5: warning: 'isolated' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/memcontrol.c:2091:6: note: 'isolated' was declared here /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/core/pcm_iec958.c: In function 'create_iec958_consumer': /kisskb/src/sound/core/pcm_iec958.c:80:9: warning: 'ws' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': /kisskb/src/kernel/time/tick-sched.c:639:17: warning: 'now' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/time/tick-sched.c:1059:10: note: 'now' was declared here /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:210:7: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:160:17: note: 'k' was declared here /kisskb/src/drivers/dma/sh/rcar-dmac.c: In function 'rcar_dmac_chan_prep_sg': /kisskb/src/drivers/dma/sh/rcar-dmac.c:939:23: warning: 'high_mem_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma/sh/rcar-dmac.c:938:23: warning: 'high_dev_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:149:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c: In function 'arizona_hw_params': /kisskb/src/sound/soc/codecs/arizona.c:1889:3: warning: 'aif_rx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/arizona.c:1886:3: warning: 'aif_tx_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/flow_dissector.c: In function '__skb_flow_dissect': /kisskb/src/net/core/flow_dissector.c:789:7: warning: 'vlan' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work': /kisskb/src/sound/soc/codecs/da7219-aad.c:318:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3149:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/joystick/analog.c:176:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c: In function 'arm_v7s_map': /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:433:7: warning: 'cptep' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:429:22: note: 'cptep' was declared here /kisskb/src/sound/soc/codecs/rt5665.c: In function 'rt5665_i2s_pin_event': /kisskb/src/sound/soc/codecs/rt5665.c:2666:23: warning: 'val2' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/rt5665.c:2663:23: warning: 'val1' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/infiniband/hw/cxgb4/device.c: In function 'wr_log_show': /kisskb/src/drivers/infiniband/hw/cxgb4/device.c:152:14: warning: 'prev_time' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/nfc/st21nfca/core.c: In function 'st21nfca_hci_target_from_gate': /kisskb/src/drivers/nfc/st21nfca/core.c:664:10: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/nfc/st21nfca/core.c:663:20: warning: 'sak' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/nfc/st21nfca/core.c:662:21: warning: 'atqa' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/infiniband/ulp/ipoib/ipoib_main.c: In function 'ipoib_intf_alloc': /kisskb/src/drivers/infiniband/ulp/ipoib/ipoib_main.c:2040:5: warning: 'dev' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': /kisskb/src/sound/soc/codecs/wm8960.c:803:56: warning: 'j' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c:800:54: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/infiniband/hw/cxgb4/cq.c: In function 'c4iw_flush_hw_cq': /kisskb/src/drivers/infiniband/hw/cxgb4/cq.c:288:21: warning: 'hw_cqe' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/infiniband/hw/cxgb4/cq.c:320:17: note: 'hw_cqe' was declared here /kisskb/src/drivers/mfd/arizona-core.c: In function 'arizona_dev_init': /kisskb/src/drivers/mfd/arizona-core.c:1387:6: warning: 'n_subdevs' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/rmi4/rmi_f11.c: In function 'rmi_f11_attention': /kisskb/src/drivers/input/rmi4/rmi_f11.c:631:3: warning: 'abs_fingers' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/rmi4/rmi_f11.c:580:6: note: 'abs_fingers' was declared here /kisskb/src/net/tipc/socket.c: In function 'tipc_recvmsg': /kisskb/src/net/tipc/socket.c:1694:27: warning: 'copy' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c: In function 'xgene_sgmac_init': /kisskb/src/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:311:34: warning: 'data' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/apm/xgene/xgene_enet_sgmac.c:300:6: note: 'data' was declared here /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_zone_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:601:32: warning: 'reg_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'reg_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:443:16: warning: 'reg_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c: In function 'brcmf_pcie_setup': /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:1126:22: warning: 'bufsz' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:1085:6: note: 'bufsz' was declared here /kisskb/src/net/mac80211/tx.c: In function 'ieee80211_build_hdr': /kisskb/src/net/mac80211/tx.c:2452:27: warning: 'chanctx_conf' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/scsi/aacraid/src.c: In function 'aac_src_intr_message': /kisskb/src/drivers/scsi/aacraid/src.c:98:4: warning: 'bellbits' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1347:6: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1307:6: note: 'pwr_level_cisco' was declared here /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c: In function 'rtl8xxxu_probe': /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3481:23: warning: 'rf_amode' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c:3434:6: note: 'rf_amode' was declared here /kisskb/src/drivers/scsi/am53c974.c: In function 'pci_esp_dma_drain': /kisskb/src/drivers/scsi/am53c974.c:199:5: warning: 'resid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/scsi/hpsa.c: In function 'complete_scsi_command': /kisskb/src/drivers/scsi/hpsa.c:2659:7: warning: 'sense_key' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_create_port': /kisskb/src/drivers/scsi/lpfc/lpfc_init.c:3889:6: warning: 'wwn' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/scsi/lpfc/lpfc_bsg.c: In function 'lpfc_issue_ct_rsp_cmp': /kisskb/src/drivers/scsi/lpfc/lpfc_bsg.c:1467:15: warning: 'bsg_reply' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/realtek/r8169.c: In function 'rtl_set_coalesce': /kisskb/src/drivers/net/ethernet/realtek/r8169.c:2571:13: warning: 'cp01' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c: In function 'mlx5e_ethtool_flow_replace': /kisskb/src/include/linux/err.h:36:9: warning: 'rule' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/ethernet/mellanox/mlx5/core/en_fs_ethtool.c:296:27: note: 'rule' was declared here WARNING: modpost: Found 2 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' /kisskb/src/scripts/link-vmlinux.sh: line 94: 13316 Segmentation fault (core dumped) ${LD} ${LDFLAGS} ${LDFLAGS_vmlinux} -o ${2} -T ${lds} ${objects} /kisskb/src/Makefile:1032: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 139 Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_powerpc-randconfig_powerpc # Build took: 0:02:50.180810