# git rev-parse -q --verify f2748bdfe157343eb8cf910a1d89ccf2fd20100b^{commit} f2748bdfe157343eb8cf910a1d89ccf2fd20100b already have revision, skipping fetch # git checkout -q -f -B kisskb f2748bdfe157343eb8cf910a1d89ccf2fd20100b # git clean -qxdf # < git log -1 # commit f2748bdfe157343eb8cf910a1d89ccf2fd20100b # Author: Nicholas Piggin # Date: Sun Apr 1 20:36:15 2018 +1000 # # powerpc/powernv: Always stop secondaries before reboot/shutdown # # Currently powernv reboot and shutdown requests just leave secondaries # to do their own things. This is undesirable because they can trigger # any number of watchdogs while waiting for reboot, but also we don't # know what else they might be doing -- they might be causing trouble, # trampling memory, etc. # # The opal scheduled flash update code already ran into watchdog problems # due to flashing taking a long time, and it was fixed with 2196c6f1ed # ("powerpc/powernv: Return secondary CPUs to firmware before FW update"), # which returns secondaries to opal. It's been found that regular reboots # can take over 10 seconds, which can result in the hard lockup watchdog # firing, # # reboot: Restarting system # [ 360.038896709,5] OPAL: Reboot request... # Watchdog CPU:0 Hard LOCKUP # Watchdog CPU:44 detected Hard LOCKUP other CPUS:16 # Watchdog CPU:16 Hard LOCKUP # watchdog: BUG: soft lockup - CPU#16 stuck for 3s! [swapper/16:0] # # This patch removes the special case for flash update, and calls # smp_send_stop in all cases before calling reboot/shutdown. # # smp_send_stop could return CPUs to OPAL, the main reason not to is # that the request could come from a NMI that interrupts OPAL code, # so re-entry to OPAL can cause a number of problems. Putting # secondaries into simple spin loops improves the chances of a # successful reboot. # # Signed-off-by: Nicholas Piggin # Reviewed-by: Vasant Hegde # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 f2748bdfe157343eb8cf910a1d89ccf2fd20100b # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pseries_defconfig # Added to kconfig CONFIG_MEMORY_HOTPLUG=y # Added to kconfig CONFIG_MEMORY_HOTREMOVE=n # yes \n | make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-next_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/swap_state.c: In function '__add_to_swap_cache': /kisskb/src/mm/swap_state.c:135:5: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1439:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec': /kisskb/src/net/bridge/br_netlink.c:635:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2043:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1816:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1726:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here WARNING: modpost: Found 2 section mismatch(es). To see full details build your kernel with: 'make CONFIG_DEBUG_SECTION_MISMATCH=y' Completed OK # rm -rf /kisskb/build/powerpc-next_pseries_defconfig+NO_MEMORY_HOTREMOVE_powerpc # Build took: 0:02:17.078811