# git rev-parse -q --verify 3909c5f6d66dd7a56899e1c7a0a65284a0d3423f^{commit} 3909c5f6d66dd7a56899e1c7a0a65284a0d3423f already have revision, skipping fetch # git checkout -q -f -B kisskb 3909c5f6d66dd7a56899e1c7a0a65284a0d3423f # git clean -qxdf # < git log -1 # commit 3909c5f6d66dd7a56899e1c7a0a65284a0d3423f # Author: Ram Pai # Date: Tue Mar 27 02:09:28 2018 -0700 # # mm, x86, powerpc: display pkey in smaps only if arch supports pkeys # # Currently the architecture specific code is expected to # display the protection keys in smap for a given vma. # This can lead to redundant code and possibly to divergent # formats in which the key gets displayed. # # This patch changes the implementation. It displays the # pkey only if the architecture support pkeys, i.e # arch_pkeys_enabled() returns true. This patch # provides x86 implementation for arch_pkeys_enabled(). # # x86 arch_show_smap() function is not needed anymore. # Deleting it. # # cc: Michael Ellermen # cc: Benjamin Herrenschmidt # cc: Andrew Morton # Reviewed-by: Dave Hansen # Signed-off-by: Thiago Jung Bauermann # (fixed compilation errors for x86 configs) # Acked-by: Michal Hocko # Reviewed-by: Ingo Molnar # Signed-off-by: Ram Pai # [mpe: Don't remove include of asm/mmu_context.h from pkeys.h, to avoid # build errors on some configs.] # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < git log --format=%s --max-count=1 3909c5f6d66dd7a56899e1c7a0a65284a0d3423f # < make -s -j 120 ARCH=i386 O=/kisskb/build/powerpc-next_i386_defconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- i386_defconfig # make -s -j 120 ARCH=i386 O=/kisskb/build/powerpc-next_i386_defconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- CONFIG_CC_STACKPROTECTOR_AUTO: -fstack-protector available but compiler is broken: disabling /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:652:2: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] In file included from /kisskb/src/include/linux/pkeys.h:6:0, from /kisskb/src/arch/x86/kernel/fpu/core.c:15: /kisskb/src/arch/x86/include/asm/mmu_context.h: In function 'arch_vma_access_permitted': /kisskb/src/arch/x86/include/asm/mmu_context.h:333:2: error: implicit declaration of function 'vma_pkey' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:324: recipe for target 'arch/x86/kernel/fpu/core.o' failed make[4]: *** [arch/x86/kernel/fpu/core.o] Error 1 make[4]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/pkeys.h:6:0, from /kisskb/src/arch/x86/kernel/fpu/xstate.c:9: /kisskb/src/arch/x86/include/asm/mmu_context.h: In function 'arch_vma_access_permitted': /kisskb/src/arch/x86/include/asm/mmu_context.h:333:2: error: implicit declaration of function 'vma_pkey' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:324: recipe for target 'arch/x86/kernel/fpu/xstate.o' failed make[4]: *** [arch/x86/kernel/fpu/xstate.o] Error 1 /kisskb/src/scripts/Makefile.build:583: recipe for target 'arch/x86/kernel/fpu' failed make[3]: *** [arch/x86/kernel/fpu] Error 2 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:146:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1033:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] In file included from /kisskb/src/include/linux/pkeys.h:6:0, from /kisskb/src/mm/mprotect.c:27: /kisskb/src/arch/x86/include/asm/mmu_context.h: In function 'arch_vma_access_permitted': /kisskb/src/arch/x86/include/asm/mmu_context.h:333:2: error: implicit declaration of function 'vma_pkey' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:324: recipe for target 'mm/mprotect.o' failed make[2]: *** [mm/mprotect.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/include/linux/pkeys.h:6:0, from /kisskb/src/mm/mmap.c:46: /kisskb/src/arch/x86/include/asm/mmu_context.h: In function 'arch_vma_access_permitted': /kisskb/src/arch/x86/include/asm/mmu_context.h:333:2: error: implicit declaration of function 'vma_pkey' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:324: recipe for target 'mm/mmap.o' failed make[2]: *** [mm/mmap.o] Error 1 /kisskb/src/Makefile:1051: recipe for target 'mm' failed make[1]: *** [mm] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:207:2: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:160:17: note: 'k' was declared here In file included from /kisskb/src/include/linux/pkeys.h:6:0, from /kisskb/src/fs/proc/task_mmu.c:21: /kisskb/src/arch/x86/include/asm/mmu_context.h: In function 'arch_vma_access_permitted': /kisskb/src/arch/x86/include/asm/mmu_context.h:333:2: error: implicit declaration of function 'vma_pkey' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors /kisskb/src/scripts/Makefile.build:324: recipe for target 'fs/proc/task_mmu.o' failed make[3]: *** [fs/proc/task_mmu.o] Error 1 make[3]: *** Waiting for unfinished jobs.... /kisskb/src/scripts/Makefile.build:583: recipe for target 'fs/proc' failed make[2]: *** [fs/proc] Error 2 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1350:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1307:6: note: 'pwr_level_cisco' was declared here /kisskb/src/scripts/Makefile.build:583: recipe for target 'arch/x86/kernel' failed make[2]: *** [arch/x86/kernel] Error 2 /kisskb/src/Makefile:1051: recipe for target 'arch/x86' failed make[1]: *** [arch/x86] Error 2 /kisskb/src/Makefile:1051: recipe for target 'fs' failed make[1]: *** [fs] Error 2 Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 120 ARCH=i386 O=/kisskb/build/powerpc-next_i386_defconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-next_i386_defconfig_i386 # Build took: 0:00:40.945147