# git rev-parse -q --verify 7c8db8431b5bc1c37f6d2ce73d2e18a42b52c87d^{commit} 7c8db8431b5bc1c37f6d2ce73d2e18a42b52c87d already have revision, skipping fetch # git checkout -q -f -B kisskb 7c8db8431b5bc1c37f6d2ce73d2e18a42b52c87d # git clean -qxdf # < git log -1 # commit 7c8db8431b5bc1c37f6d2ce73d2e18a42b52c87d # Author: Michael Ellerman # Date: Thu Apr 12 22:24:45 2018 +1000 # # powerpc/64s: Fix CPU_FTRS_ALWAYS vs DT CPU features # # The cpu_has_feature() mechanism has an optimisation where at build # time we construct a mask of the CPU feature bits that will always be # true for the given .config, based on the platform/bitness/etc. that we # are building for. # # That is incompatible with DT CPU features, where the set of CPU # features is dependent on feature flags that are given to us by # firmware. # # The result is that some feature bits can not be *disabled* by DT CPU # features. Or more accurately, they can be disabled but they will still # appear in the ALWAYS mask, meaning cpu_has_feature() will always # return true for them. # # In the past this hasn't really been a problem because on Book3S # 64 (where we support DT CPU features), the set of ALWAYS bits has been # very small. That was because we always built for POWER4 and later, # meaning the set of common bits was small. # # The only bit that could be cleared by DT CPU features that was also in # the ALWAYS mask was CPU_FTR_NODSISRALIGN, and that was only used in # the alignment handler to create a fake DSISR. That code was itself # deleted in 31bfdb036f12 ("powerpc: Use instruction emulation # infrastructure to handle alignment faults") (Sep 2017). # # However the set of ALWAYS features changed with the recent commit # db5ae1c155af ("powerpc/64s: Refine feature sets for little endian # builds") which restricted the set of feature flags when building # little endian to Power7 or later. That caused the ALWAYS mask to # become much larger for little endian builds. # # The result is that the following feature bits can currently not # be *disabled* by DT CPU features: # # CPU_FTR_REAL_LE, CPU_FTR_MMCRA, CPU_FTR_CTRL, CPU_FTR_SMT, # CPU_FTR_PURR, CPU_FTR_SPURR, CPU_FTR_DSCR, CPU_FTR_PKEY, # CPU_FTR_VMX_COPY, CPU_FTR_CFAR, CPU_FTR_HAS_PPR. # # To fix it we need to mask the set of ALWAYS features with the base set # of DT CPU features, ie. the features that are always enabled by DT CPU # features. That way there are no bits in the ALWAYS mask that are not # also always set by DT CPU features. # # Fixes: db5ae1c155af ("powerpc/64s: Refine feature sets for little endian builds") # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 7c8db8431b5bc1c37f6d2ce73d2e18a42b52c87d # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0xAC566B90 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/arch/powerpc/kernel/kexec_elf_64.c: In function 'elf64_load': /kisskb/src/arch/powerpc/kernel/kexec_elf_64.c:657:2: warning: 'fdt' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rhashtable_rehash_one': /kisskb/src/lib/rhashtable.c:269:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_replace': /kisskb/src/drivers/dma-buf/reservation.c:210:7: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:182:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/hwspinlock/hwspinlock_core.c: In function 'of_hwspin_lock_get_id': /kisskb/src/drivers/hwspinlock/hwspinlock_core.c:301:6: warning: 'id' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/time/tick-sched.c: In function 'tick_nohz_idle_exit': /kisskb/src/kernel/time/tick-sched.c:1059:31: warning: 'now' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:149:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/flow_dissector.c: In function '__skb_flow_dissect': /kisskb/src/net/core/flow_dissector.c:789:7: warning: 'vlan' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:898:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3176:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c: In function 'generic_reg_wait': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:157:11: warning: 'reg_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c: In function 'drm_sched_job_recovery': /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c:526:20: warning: 'guilty_context' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_handle_pwr_constr.isra.11': /kisskb/src/net/mac80211/mlme.c:1352:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/tipc/socket.c: In function 'tipc_recvmsg': /kisskb/src/net/tipc/socket.c:1691:27: warning: 'copy' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c: In function 'macsec_del_rxsa': /kisskb/src/drivers/net/macsec.c:1926:2: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c:1926:2: warning: 'rx_sc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c: In function 'macsec_del_txsa': /kisskb/src/drivers/net/macsec.c:2003:2: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c:2003:2: warning: 'tx_sc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c: In function 'macsec_upd_txsa': /kisskb/src/drivers/net/macsec.c:2068:5: warning: 'assoc_num' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c:2068:24: warning: 'tx_sc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/macsec.c:2069:21: warning: 'secy' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1820:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1530:31: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1730:46: note: 'linear' was declared here In file included from /kisskb/src/drivers/net/wireless/ath/wil6210/fw.c:36:0: /kisskb/src/drivers/net/wireless/ath/wil6210/fw_inc.c: In function 'wil_fw_process': /kisskb/src/drivers/net/wireless/ath/wil6210/fw_inc.c:602:4: warning: 'hdr_sz' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/intel/iwlegacy/4965-mac.c: In function 'il4965_tx_skb': /kisskb/src/drivers/net/wireless/intel/iwlegacy/4965-mac.c:1859:33: warning: 'phys_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c: In function 'g94_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c: In function 'gm200_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:101:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:101:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c: In function 'nv50_head_lut_load': /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'b' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1805:18: note: 'b' was declared here /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'g' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1805:15: note: 'g' was declared here /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'r' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nv50_display.c:1805:12: note: 'r' was declared here WARNING: vmlinux.o(.text+0x3f3c8): Section mismatch in reference from the function .fsl_add_bridge() to the function .init.text:.setup_pci_cmd() The function .fsl_add_bridge() references the function __init .setup_pci_cmd(). This is often because .fsl_add_bridge lacks a __init annotation or the annotation of .setup_pci_cmd is wrong. WARNING: 4 bad relocations c000000000016726 R_PPC64_ADDR16_HIGHEST .head.text+0x0000000000016740 c00000000001672a R_PPC64_ADDR16_HIGHER .head.text+0x0000000000016740 c000000000016732 R_PPC64_ADDR16_HI .head.text+0x0000000000016740 c000000000016736 R_PPC64_ADDR16_LO .head.text+0x0000000000016740 Completed OK # rm -rf /kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc # Build took: 0:03:25.141927