# git rev-parse -q --verify 81b654c273914704a4bdf580f28d67aaba1094e4^{commit} 81b654c273914704a4bdf580f28d67aaba1094e4 already have revision, skipping fetch # git checkout -q -f -B kisskb 81b654c273914704a4bdf580f28d67aaba1094e4 # git clean -qxdf # < git log -1 # commit 81b654c273914704a4bdf580f28d67aaba1094e4 # Author: Michael Ellerman # Date: Thu Apr 12 22:24:45 2018 +1000 # # powerpc/64s: Fix CPU_FTRS_ALWAYS vs DT CPU features # # The cpu_has_feature() mechanism has an optimisation where at build # time we construct a mask of the CPU feature bits that will always be # true for the given .config, based on the platform/bitness/etc. that we # are building for. # # That is incompatible with DT CPU features, where the set of CPU # features is dependent on feature flags that are given to us by # firmware. # # The result is that some feature bits can not be *disabled* by DT CPU # features. Or more accurately, they can be disabled but they will still # appear in the ALWAYS mask, meaning cpu_has_feature() will always # return true for them. # # In the past this hasn't really been a problem because on Book3S # 64 (where we support DT CPU features), the set of ALWAYS bits has been # very small. That was because we always built for POWER4 and later, # meaning the set of common bits was small. # # The only bit that could be cleared by DT CPU features that was also in # the ALWAYS mask was CPU_FTR_NODSISRALIGN, and that was only used in # the alignment handler to create a fake DSISR. That code was itself # deleted in 31bfdb036f12 ("powerpc: Use instruction emulation # infrastructure to handle alignment faults") (Sep 2017). # # However the set of ALWAYS features changed with the recent commit # db5ae1c155af ("powerpc/64s: Refine feature sets for little endian # builds") which restricted the set of feature flags when building # little endian to Power7 or later. That caused the ALWAYS mask to # become much larger for little endian builds. # # The result is that the following feature bits can currently not # be *disabled* by DT CPU features: # # CPU_FTR_REAL_LE, CPU_FTR_MMCRA, CPU_FTR_CTRL, CPU_FTR_SMT, # CPU_FTR_PURR, CPU_FTR_SPURR, CPU_FTR_DSCR, CPU_FTR_PKEY, # CPU_FTR_VMX_COPY, CPU_FTR_CFAR, CPU_FTR_HAS_PPR. # # To fix it we need to mask the set of ALWAYS features with the base set # of DT CPU features, ie. the features that are always enabled by DT CPU # features. That way there are no bits in the ALWAYS mask that are not # also always set by DT CPU features. # # Fixes: db5ae1c155af ("powerpc/64s: Refine feature sets for little endian builds") # Reviewed-by: Nicholas Piggin # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 81b654c273914704a4bdf580f28d67aaba1094e4 # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0x82934A3C # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # Added to kconfig # yes \n | make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/arch/powerpc/kvm/book3s_pr.c: In function 'kvmppc_handle_exit_pr': /kisskb/src/arch/powerpc/kvm/book3s_pr.c:1130:31: warning: 'last_sc' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:182:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/powerpc/kernel/kexec_elf_64.c: In function 'elf64_load': /kisskb/src/arch/powerpc/kernel/kexec_elf_64.c:657:2: warning: 'fdt' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/char/tpm/tpm-sysfs.c: In function 'pubek_show': /kisskb/src/drivers/char/tpm/tpm-sysfs.c:37:16: warning: 'tpm_buf.data' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/char/tpm/tpm2-cmd.c: In function 'tpm2_unseal_trusted': /kisskb/src/drivers/char/tpm/tpm.h:489:9: warning: 'blob_handle' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/char/tpm/tpm2-cmd.c:722:6: note: 'blob_handle' was declared here /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:269:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:234:28: note: 'next' was declared here /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:210:7: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:160:17: note: 'k' was declared here /kisskb/src/drivers/dma/sh/rcar-dmac.c: In function 'rcar_dmac_chan_prep_sg': /kisskb/src/drivers/dma/sh/rcar-dmac.c:939:23: warning: 'high_mem_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma/sh/rcar-dmac.c:938:23: warning: 'high_dev_addr' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c: In function 'drm_sched_job_recovery': /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c:526:20: warning: 'guilty_context' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/rmi4/rmi_f11.c: In function 'rmi_f11_attention': /kisskb/src/drivers/input/rmi4/rmi_f11.c:631:3: warning: 'abs_fingers' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/rmi4/rmi_f11.c:580:6: note: 'abs_fingers' was declared here /kisskb/src/drivers/input/mouse/cyapa.c: In function 'cyapa_irq': /kisskb/src/drivers/input/mouse/cyapa.c:717:27: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/mouse/cyapa_gen3.c: In function 'cyapa_gen3_set_power_mode': /kisskb/src/drivers/input/mouse/cyapa_gen3.c:927:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/adc/qcom-pm8xxx-xoadc.c: In function 'pm8xxx_get_channel': /kisskb/src/drivers/iio/adc/qcom-pm8xxx-xoadc.c:426:27: warning: 'ch' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/touchscreen/hideep.c: In function 'hideep_update_fw': /kisskb/src/drivers/input/touchscreen/hideep.c:633:10: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/touchscreen/hideep.c:605:6: note: 'error' was declared here /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:898:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_sideband_msg_build': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:364:23: warning: 'hdrlen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:246:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c: In function 'generic_reg_wait': /kisskb/src/drivers/gpu/drm/amd/amdgpu/../display/dc/dc_helper.c:157:11: warning: 'reg_val' may be used uninitialized in this function [-Wuninitialized] arch/powerpc/kvm/book3s_hv_rmhandlers.o: In function `hcall_real_table': (.text+0x1400): undefined reference to `.kvmppc_h_get_tce' arch/powerpc/kvm/book3s_hv_rmhandlers.o: In function `hcall_real_table': (.text+0x1404): undefined reference to `.kvmppc_rm_h_put_tce' arch/powerpc/kvm/book3s_hv_rmhandlers.o: In function `hcall_real_table': (.text+0x151c): undefined reference to `.kvmppc_rm_h_stuff_tce' arch/powerpc/kvm/book3s_hv_rmhandlers.o: In function `hcall_real_table': (.text+0x1520): undefined reference to `.kvmppc_rm_h_put_tce_indirect' /kisskb/src/Makefile:1033: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/powerpc-fixes_powerpc-randconfig_powerpc # Build took: 0:01:48.021558