# git rev-parse -q --verify 75ecfb49516c53da00c57b9efe48fa3f5504a791^{commit} 75ecfb49516c53da00c57b9efe48fa3f5504a791 already have revision, skipping fetch # git checkout -q -f -B kisskb 75ecfb49516c53da00c57b9efe48fa3f5504a791 # git clean -qxdf # < git log -1 # commit 75ecfb49516c53da00c57b9efe48fa3f5504a791 # Author: Mahesh Salgaonkar # Date: Mon Apr 23 10:29:27 2018 +0530 # # powerpc/mce: Fix a bug where mce loops on memory UE. # # The current code extracts the physical address for UE errors and then # hooks it up into memory failure infrastructure. On successful # extraction of physical address it wrongly sets "handled = 1" which # means this UE error has been recovered. Since MCE handler gets return # value as handled = 1, it assumes that error has been recovered and # goes back to same NIP. This causes MCE interrupt again and again in a # loop leading to hard lockup. # # Also, initialize phys_addr to ULONG_MAX so that we don't end up # queuing undesired page to hwpoison. # # Without this patch we see: # Severe Machine check interrupt [Recovered] # NIP: [000000001002588c] PID: 7109 Comm: find # Initiator: CPU # Error type: UE [Load/Store] # Effective address: 00007fffd2755940 # Physical address: 000020181a080000 # ... # Severe Machine check interrupt [Recovered] # NIP: [000000001002588c] PID: 7109 Comm: find # Initiator: CPU # Error type: UE [Load/Store] # Effective address: 00007fffd2755940 # Physical address: 000020181a080000 # Severe Machine check interrupt [Recovered] # NIP: [000000001002588c] PID: 7109 Comm: find # Initiator: CPU # Error type: UE [Load/Store] # Effective address: 00007fffd2755940 # Physical address: 000020181a080000 # Memory failure: 0x20181a08: recovery action for dirty LRU page: Recovered # Memory failure: 0x20181a08: already hardware poisoned # Memory failure: 0x20181a08: already hardware poisoned # Memory failure: 0x20181a08: already hardware poisoned # Memory failure: 0x20181a08: already hardware poisoned # Memory failure: 0x20181a08: already hardware poisoned # Memory failure: 0x20181a08: already hardware poisoned # ... # Watchdog CPU:38 Hard LOCKUP # # After this patch we see: # # Severe Machine check interrupt [Not recovered] # NIP: [00007fffaae585f4] PID: 7168 Comm: find # Initiator: CPU # Error type: UE [Load/Store] # Effective address: 00007fffaafe28ac # Physical address: 00002017c0bd0000 # find[7168]: unhandled signal 7 at 00007fffaae585f4 nip 00007fffaae585f4 lr 00007fffaae585e0 code 4 # Memory failure: 0x2017c0bd: recovery action for dirty LRU page: Recovered # # Fixes: 01eaac2b0591 ("powerpc/mce: Hookup ierror (instruction) UE errors") # Fixes: ba41e1e1ccb9 ("powerpc/mce: Hookup derror (load/store) UE errors") # Cc: stable@vger.kernel.org # v4.15+ # Signed-off-by: Mahesh Salgaonkar # Signed-off-by: Balbir Singh # Reviewed-by: Balbir Singh # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < git log --format=%s --max-count=1 75ecfb49516c53da00c57b9efe48fa3f5504a791 # < make -s -j 48 ARCH=i386 O=/kisskb/build/powerpc-fixes_i386_defconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- i386_defconfig # make -s -j 48 ARCH=i386 O=/kisskb/build/powerpc-fixes_i386_defconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- CONFIG_CC_STACKPROTECTOR_AUTO: -fstack-protector available but compiler is broken: disabling /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:146:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[]' was declared here /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:652:2: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1033:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:340:21: note: 'pdeo' was declared here /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:207:2: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:160:17: note: 'k' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1352:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1309:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/powerpc-fixes_i386_defconfig_i386 # Build took: 0:01:20.852790