# git rev-parse -q --verify ac61c1156623455c46701654abd8c99720bceea1^{commit} ac61c1156623455c46701654abd8c99720bceea1 already have revision, skipping fetch # git checkout -q -f -B kisskb ac61c1156623455c46701654abd8c99720bceea1 # git clean -qxdf # < git log -1 # commit ac61c1156623455c46701654abd8c99720bceea1 # Author: Nicholas Piggin # Date: Wed Apr 25 12:17:53 2018 +1000 # # powerpc: Fix smp_send_stop NMI IPI handling # # The NMI IPI handler for a receiving CPU increments nmi_ipi_busy_count # over the handler function call, which causes later smp_send_nmi_ipi() # callers to spin until the call is finished. # # The stop_this_cpu() function never returns, so the busy count is never # decremeted, which can cause the system to hang in some cases. For # example panic() will call smp_send_stop() early on which calls # stop_this_cpu() on other CPUs, then later in the reboot path, # pnv_restart() will call smp_send_stop() again, which hangs. # # Fix this by adding a special case to the stop_this_cpu() handler to # decrement the busy count, because it will never return. # # Now that the NMI/non-NMI versions of stop_this_cpu() are different, # split them out into separate functions rather than doing #ifdef tricks # to share the body between the two functions. # # Fixes: 6bed3237624e3 ("powerpc: use NMI IPI for smp_send_stop") # Reported-by: Abdul Haleem # Signed-off-by: Nicholas Piggin # [mpe: Split out the functions, tweak change log a bit] # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 ac61c1156623455c46701654abd8c99720bceea1 # < make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- allyesconfig # Added to kconfig CONFIG_PROFILE_ALL_BRANCHES=n # Added to kconfig CONFIG_ENABLE_WARN_DEPRECATED=n # Added to kconfig CONFIG_ENABLE_MUST_CHECK=n # Added to kconfig CONFIG_DEBUG_INFO=n # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # yes \n | make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 40 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get': /kisskb/src/sound/aoa/codecs/onyx.c:380:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized] ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity; ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/include/linux/of_address.h:7, from /kisskb/src/drivers/ata/ahci_qoriq.c:18: /kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': /kisskb/src/arch/powerpc/include/asm/io.h:623:3: warning: 'px_is' may be used uninitialized in this function [-Wmaybe-uninitialized] ppc_pci_io.name al; \ ^ /kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here u32 px_cmd, px_is, px_val; ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/include/linux/of_address.h:7, from /kisskb/src/drivers/ata/ahci_qoriq.c:18: /kisskb/src/arch/powerpc/include/asm/io.h:142:2: warning: 'px_cmd' may be used uninitialized in this function [-Wmaybe-uninitialized] __asm__ __volatile__("sync;"#insn" %1,%y0" \ ^ /kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here u32 px_cmd, px_is, px_val; ^ WARNING: vmlinux.o(.text+0x3ebd5c): Section mismatch in reference from the function .devm_memremap_pages() to the function .meminit.text:.arch_add_memory() The function .devm_memremap_pages() references the function __meminit .arch_add_memory(). This is often because .devm_memremap_pages lacks a __meminit annotation or the annotation of .arch_add_memory is wrong. WARNING: vmlinux.o(.text+0x3ec648): Section mismatch in reference from the function .devm_memremap_pages_release() to the function .meminit.text:.arch_remove_memory() The function .devm_memremap_pages_release() references the function __meminit .arch_remove_memory(). This is often because .devm_memremap_pages_release lacks a __meminit annotation or the annotation of .arch_remove_memory is wrong. WARNING: vmlinux.o(.text+0x527d5c): Section mismatch in reference from the function .hmm_devmem_release() to the function .meminit.text:.arch_remove_memory() The function .hmm_devmem_release() references the function __meminit .arch_remove_memory(). This is often because .hmm_devmem_release lacks a __meminit annotation or the annotation of .arch_remove_memory is wrong. WARNING: vmlinux.o(.text+0x5280c0): Section mismatch in reference from the function .hmm_devmem_pages_create() to the function .meminit.text:.arch_add_memory() The function .hmm_devmem_pages_create() references the function __meminit .arch_add_memory(). This is often because .hmm_devmem_pages_create lacks a __meminit annotation or the annotation of .arch_add_memory is wrong. Completed OK # rm -rf /kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 # Build took: 0:09:43.010052