# git rev-parse -q --verify 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0^{commit} 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 already have revision, skipping fetch # git checkout -q -f -B kisskb 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # git clean -qxdf # < git log -1 # commit 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # Author: Linus Torvalds # Date: Thu Jun 14 12:21:18 2018 +0900 # # Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables # # The changes to automatically test for working stack protector compiler # support in the Kconfig files removed the special STACKPROTECTOR_AUTO # option that picked the strongest stack protector that the compiler # supported. # # That was all a nice cleanup - it makes no sense to have the AUTO case # now that the Kconfig phase can just determine the compiler support # directly. # # HOWEVER. # # It also meant that doing "make oldconfig" would now _disable_ the strong # stackprotector if you had AUTO enabled, because in a legacy config file, # the sane stack protector configuration would look like # # CONFIG_HAVE_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_NONE is not set # # CONFIG_CC_STACKPROTECTOR_REGULAR is not set # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_STACKPROTECTOR_AUTO=y # # and when you ran this through "make oldconfig" with the Kbuild changes, # it would ask you about the regular CONFIG_CC_STACKPROTECTOR (that had # been renamed from CONFIG_CC_STACKPROTECTOR_REGULAR to just # CONFIG_CC_STACKPROTECTOR), but it would think that the STRONG version # used to be disabled (because it was really enabled by AUTO), and would # disable it in the new config, resulting in: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # That's dangerously subtle - people could suddenly find themselves with # the weaker stack protector setup without even realizing. # # The solution here is to just rename not just the old RECULAR stack # protector option, but also the strong one. This does that by just # removing the CC_ prefix entirely for the user choices, because it really # is not about the compiler support (the compiler support now instead # automatially impacts _visibility_ of the options to users). # # This results in "make oldconfig" actually asking the user for their # choice, so that we don't have any silent subtle security model changes. # The end result would generally look like this: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_STACKPROTECTOR=y # CONFIG_STACKPROTECTOR_STRONG=y # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # where the "CC_" versions really are about internal compiler # infrastructure, not the user selections. # # Acked-by: Masahiro Yamada # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-gcc --version # < git log --format=%s --max-count=1 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # < make -s -j 10 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MODULE_SIG=n # yes \n | make -s -j 10 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 10 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/drivers/input/joystick/analog.c:176:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^ In file included from /kisskb/src/arch/sparc/include/asm/cmpxchg.h:5:0, from /kisskb/src/arch/sparc/include/asm/atomic_64.h:12, from /kisskb/src/arch/sparc/include/asm/atomic.h:5, from /kisskb/src/include/linux/atomic.h:5, from /kisskb/src/include/asm-generic/qspinlock_types.h:28, from /kisskb/src/arch/sparc/include/asm/spinlock_types.h:6, from /kisskb/src/include/linux/spinlock_types.h:13, from /kisskb/src/include/linux/spinlock.h:82, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/ocfs2/file.c:27: /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/arch/sparc/include/asm/cmpxchg_64.h:55:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ^ /kisskb/src/fs/ocfs2/file.c:2386:3: note: in expansion of macro 'xchg' xchg(&iocb->ki_complete, saved_ki_complete); ^ In file included from /kisskb/src/arch/sparc/include/asm/cmpxchg.h:5:0, from /kisskb/src/arch/sparc/include/asm/atomic_64.h:12, from /kisskb/src/arch/sparc/include/asm/atomic.h:5, from /kisskb/src/include/linux/atomic.h:5, from /kisskb/src/include/asm-generic/qspinlock_types.h:28, from /kisskb/src/arch/sparc/include/asm/spinlock_types.h:6, from /kisskb/src/include/linux/spinlock_types.h:13, from /kisskb/src/include/linux/spinlock.h:82, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:12: /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_xdp_setup': /kisskb/src/arch/sparc/include/asm/cmpxchg_64.h:55:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ^ /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4448:4: note: in expansion of macro 'xchg' xchg(&adapter->rx_ring[i]->xdp_prog, adapter->xdp_prog); ^ kernel: arch/sparc/boot/image is ready kernel: arch/sparc/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_sparc64-allmodconfig_sparc64 # Build took: 0:13:44.047156