# git rev-parse -q --verify 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0^{commit} 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 already have revision, skipping fetch # git checkout -q -f -B kisskb 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # git clean -qxdf # < git log -1 # commit 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # Author: Linus Torvalds # Date: Thu Jun 14 12:21:18 2018 +0900 # # Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables # # The changes to automatically test for working stack protector compiler # support in the Kconfig files removed the special STACKPROTECTOR_AUTO # option that picked the strongest stack protector that the compiler # supported. # # That was all a nice cleanup - it makes no sense to have the AUTO case # now that the Kconfig phase can just determine the compiler support # directly. # # HOWEVER. # # It also meant that doing "make oldconfig" would now _disable_ the strong # stackprotector if you had AUTO enabled, because in a legacy config file, # the sane stack protector configuration would look like # # CONFIG_HAVE_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_NONE is not set # # CONFIG_CC_STACKPROTECTOR_REGULAR is not set # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_STACKPROTECTOR_AUTO=y # # and when you ran this through "make oldconfig" with the Kbuild changes, # it would ask you about the regular CONFIG_CC_STACKPROTECTOR (that had # been renamed from CONFIG_CC_STACKPROTECTOR_REGULAR to just # CONFIG_CC_STACKPROTECTOR), but it would think that the STRONG version # used to be disabled (because it was really enabled by AUTO), and would # disable it in the new config, resulting in: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # That's dangerously subtle - people could suddenly find themselves with # the weaker stack protector setup without even realizing. # # The solution here is to just rename not just the old RECULAR stack # protector option, but also the strong one. This does that by just # removing the CC_ prefix entirely for the user choices, because it really # is not about the compiler support (the compiler support now instead # automatially impacts _visibility_ of the options to users). # # This results in "make oldconfig" actually asking the user for their # choice, so that we don't have any silent subtle security model changes. # The end result would generally look like this: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_STACKPROTECTOR=y # CONFIG_STACKPROTECTOR_STRONG=y # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # where the "CC_" versions really are about internal compiler # infrastructure, not the user selections. # # Acked-by: Masahiro Yamada # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version # < git log --format=%s --max-count=1 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # < make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- axs101_defconfig # Added to kconfig CONFIG_INITRAMFS_SOURCE="" # yes \n | make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/include/asm-generic/bug.h:18:0, from /kisskb/src/arch/arc/include/asm/bug.h:32, from /kisskb/src/include/linux/bug.h:5, from /kisskb/src/include/linux/mmdebug.h:5, from /kisskb/src/include/linux/gfp.h:5, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/mm/nobootmem.c:14: /kisskb/src/mm/nobootmem.c: In function '__free_pages_memory': /kisskb/src/include/linux/kernel.h:812:29: warning: comparison of distinct pointer types lacks a cast [enabled by default] (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ /kisskb/src/include/linux/kernel.h:826:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^ /kisskb/src/include/linux/kernel.h:836:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^ /kisskb/src/include/linux/kernel.h:845:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^ /kisskb/src/mm/nobootmem.c:104:11: note: in expansion of macro 'min' order = min(MAX_ORDER - 1UL, __ffs(start)); ^ /kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue': /kisskb/src/net/ipv4/tcp_input.c:4296:49: warning: array subscript is above array bounds [-Warray-bounds] tp->selective_acks[i-1] = tp->selective_acks[i]; ^ /kisskb/src/net/xfrm/xfrm_policy.c: In function '__xfrm_policy_check': /kisskb/src/net/xfrm/xfrm_policy.c:2377:15: warning: array subscript is above array bounds [-Warray-bounds] if (sp->xvec[k]->props.mode != XFRM_MODE_TRANSPORT) { ^ Completed OK # rm -rf /kisskb/build/linus_axs101_defconfig_arcompact # Build took: 0:00:47.585047