# git rev-parse -q --verify 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0^{commit} 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 already have revision, skipping fetch # git checkout -q -f -B kisskb 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # git clean -qxdf # < git log -1 # commit 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # Author: Linus Torvalds # Date: Thu Jun 14 12:21:18 2018 +0900 # # Kbuild: rename CC_STACKPROTECTOR[_STRONG] config variables # # The changes to automatically test for working stack protector compiler # support in the Kconfig files removed the special STACKPROTECTOR_AUTO # option that picked the strongest stack protector that the compiler # supported. # # That was all a nice cleanup - it makes no sense to have the AUTO case # now that the Kconfig phase can just determine the compiler support # directly. # # HOWEVER. # # It also meant that doing "make oldconfig" would now _disable_ the strong # stackprotector if you had AUTO enabled, because in a legacy config file, # the sane stack protector configuration would look like # # CONFIG_HAVE_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_NONE is not set # # CONFIG_CC_STACKPROTECTOR_REGULAR is not set # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_STACKPROTECTOR_AUTO=y # # and when you ran this through "make oldconfig" with the Kbuild changes, # it would ask you about the regular CONFIG_CC_STACKPROTECTOR (that had # been renamed from CONFIG_CC_STACKPROTECTOR_REGULAR to just # CONFIG_CC_STACKPROTECTOR), but it would think that the STRONG version # used to be disabled (because it was really enabled by AUTO), and would # disable it in the new config, resulting in: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_CC_STACKPROTECTOR=y # # CONFIG_CC_STACKPROTECTOR_STRONG is not set # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # That's dangerously subtle - people could suddenly find themselves with # the weaker stack protector setup without even realizing. # # The solution here is to just rename not just the old RECULAR stack # protector option, but also the strong one. This does that by just # removing the CC_ prefix entirely for the user choices, because it really # is not about the compiler support (the compiler support now instead # automatially impacts _visibility_ of the options to users). # # This results in "make oldconfig" actually asking the user for their # choice, so that we don't have any silent subtle security model changes. # The end result would generally look like this: # # CONFIG_HAVE_CC_STACKPROTECTOR=y # CONFIG_CC_HAS_STACKPROTECTOR_NONE=y # CONFIG_STACKPROTECTOR=y # CONFIG_STACKPROTECTOR_STRONG=y # CONFIG_CC_HAS_SANE_STACKPROTECTOR=y # # where the "CC_" versions really are about internal compiler # infrastructure, not the user selections. # # Acked-by: Masahiro Yamada # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version # < git log --format=%s --max-count=1 050e9baa9dc9fbd9ce2b27f0056990fc9e0a08a0 # < make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allyesconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 allyesconfig # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_KCOV=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n # Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n # Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n # Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n # Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n # Added to kconfig CONFIG_UML_NET=n # Added to kconfig CONFIG_UML_NET_ETHERTAP=n # Added to kconfig CONFIG_UML_NET_TUNTAP=n # Added to kconfig CONFIG_UML_NET_SLIP=n # Added to kconfig CONFIG_UML_NET_DAEMON=n # Added to kconfig CONFIG_UML_NET_VDE=n # Added to kconfig CONFIG_UML_NET_MCAST=n # Added to kconfig CONFIG_UML_NET_PCAP=n # Added to kconfig CONFIG_UML_NET_SLIRP=n # Added to kconfig CONFIG_GCOV_KERNEL=n # yes \n | make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allyesconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allyesconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 /kisskb/src/arch/um/os-Linux/skas/process.c: In function 'start_idle_thread': /kisskb/src/arch/um/os-Linux/skas/process.c:613:1: warning: control reaches end of non-void function [-Wreturn-type] } ^ /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:3: warning: 'root' may be used uninitialized in this function [-Wmaybe-uninitialized] percpu_ref_reinit(&root->cgrp.self.refcnt); ^ /kisskb/src/security/apparmor/policy_unpack.c: In function 'unpack_trans_table': /kisskb/src/security/apparmor/policy_unpack.c:515:9: warning: 'pos' may be used uninitialized in this function [-Wmaybe-uninitialized] str[pos] = ':'; ^ /kisskb/src/lib/lz4/lz4hc_compress.c: In function 'LZ4HC_compress_generic': /kisskb/src/lib/lz4/lz4hc_compress.c:579:1: warning: the frame size of 2144 bytes is larger than 2048 bytes [-Wframe-larger-than=] } ^ LINK linux Completed OK # rm -rf /kisskb/build/linus_um-allyesconfig_um-x86_64 # Build took: 0:06:08.373820