# git rev-parse -q --verify 837bf7cc3b7504385ae0e829c72e470dfc27cf6c^{commit} # git fetch -q -n -f git://fs.ozlabs.ibm.com/kernel/crypto master # git rev-parse -q --verify 837bf7cc3b7504385ae0e829c72e470dfc27cf6c^{commit} 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # git checkout -q -f -B kisskb 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # git clean -qxdf # < git log -1 # commit 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # Author: Michael Büsch # Date: Thu Jun 14 20:08:11 2018 +0200 # # hwrng: core - Always drop the RNG in hwrng_unregister() # # enable_best_rng() is used in hwrng_unregister() to switch away from the # currently active RNG, if that is the one currently being removed. # However enable_best_rng() might fail, if the next RNG's init routine # fails. In that case enable_best_rng() will return an error code and # the currently active RNG will remain active. # After unregistering this might lead to crashes due to use-after-free. # # Fix this by dropping the currently active RNG, if enable_best_rng() # failed. This will result in no RNG to be active, if the next-best # one failed to initialize. # # This problem was introduced by 142a27f0a731ddcf467546960a5585970ca98e21 # # Fixes: 142a27f0a731 ("hwrng: core - Reset user selected rng by...") # Reported-by: Wirz # Tested-by: Wirz # Signed-off-by: Michael Büsch # Cc: stable@vger.kernel.org # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # < make -s -j 10 ARCH=powerpc O=/kisskb/build/crypto_pseries_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pseries_defconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/crypto_pseries_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1268:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/swap_state.c: In function '__add_to_swap_cache': /kisskb/src/mm/swap_state.c:135:5: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/bridge/br_netlink.c: In function 'br_afspec': /kisskb/src/net/bridge/br_netlink.c:635:7: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2041:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:340:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1827:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1737:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/crypto_pseries_defconfig_powerpc # Build took: 0:04:41.954239