# git rev-parse -q --verify 837bf7cc3b7504385ae0e829c72e470dfc27cf6c^{commit} # git fetch -q -n -f git://fs.ozlabs.ibm.com/kernel/crypto master # git rev-parse -q --verify 837bf7cc3b7504385ae0e829c72e470dfc27cf6c^{commit} 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # git checkout -q -f -B kisskb 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # git clean -qxdf # < git log -1 # commit 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # Author: Michael Büsch # Date: Thu Jun 14 20:08:11 2018 +0200 # # hwrng: core - Always drop the RNG in hwrng_unregister() # # enable_best_rng() is used in hwrng_unregister() to switch away from the # currently active RNG, if that is the one currently being removed. # However enable_best_rng() might fail, if the next RNG's init routine # fails. In that case enable_best_rng() will return an error code and # the currently active RNG will remain active. # After unregistering this might lead to crashes due to use-after-free. # # Fix this by dropping the currently active RNG, if enable_best_rng() # failed. This will result in no RNG to be active, if the next-best # one failed to initialize. # # This problem was introduced by 142a27f0a731ddcf467546960a5585970ca98e21 # # Fixes: 142a27f0a731 ("hwrng: core - Reset user selected rng by...") # Reported-by: Wirz # Tested-by: Wirz # Signed-off-by: Michael Büsch # Cc: stable@vger.kernel.org # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 837bf7cc3b7504385ae0e829c72e470dfc27cf6c # < make -s -j 48 ARCH=powerpc O=/kisskb/build/crypto_pmac32_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- pmac32_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/crypto_pmac32_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:225:6: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/ppc/awacs.c: In function 'snd_pmac_awacs_init': /kisskb/src/include/sound/control.h:220:2: warning: 'speaker_vol' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/ppc/awacs.c:886:36: note: 'speaker_vol' was declared here /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:340:21: note: 'pdeo' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1352:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1309:6: note: 'pwr_level_cisco' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/fs/nfsd/nfs4xdr.c: In function 'nfsd4_encode_components_esc': /kisskb/src/fs/nfsd/nfs4xdr.c:2041:9: warning: 'str' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1827:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1737:46: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c: In function 'b43_nphy_rf_ctl_override_rev7': /kisskb/src/drivers/net/wireless/broadcom/b43/phy_n.c:202:21: warning: 'val_addr' may be used uninitialized in this function [-Wuninitialized] INFO: Uncompressed kernel (size 0x89c2c4) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x900000) Completed OK # rm -rf /kisskb/build/crypto_pmac32_defconfig_powerpc # Build took: 0:01:20.364966