# git rev-parse -q --verify 22db552b50fa11d8c1d171de908a1f9ef62172b7^{commit} 22db552b50fa11d8c1d171de908a1f9ef62172b7 already have revision, skipping fetch # git checkout -q -f -B kisskb 22db552b50fa11d8c1d171de908a1f9ef62172b7 # git clean -qxdf # < git log -1 # commit 22db552b50fa11d8c1d171de908a1f9ef62172b7 # Author: Arnd Bergmann # Date: Tue Jun 19 16:02:27 2018 +0200 # # powerpc/powermac: Fix rtc read/write functions # # As Mathieu pointed out, my conversion to time64_t was incorrect and # resulted in negative times to be read from the RTC. The problem is # that during the conversion from a byte array to a time64_t, the # 'unsigned char' variable holding the top byte gets turned into a # negative signed 32-bit integer before being assigned to the 64-bit # variable for any times after 1972. # # This changes the logic to cast to an unsigned 32-bit number first for # the Macintosh time and then convert that to the Unix time, which then # gives us a time in the documented 1904..2040 year range. I decided not # to use the longer 1970..2106 range that other drivers use, for # consistency with the literal interpretation of the register, but that # could be easily changed if we decide we want to support any Mac after # 2040. # # Just to be on the safe side, I'm also adding a WARN_ON that will # trigger if either the year 2040 has come and is observed by this # driver, or we run into an RTC that got set back to a pre-1970 date for # some reason (the two are indistinguishable). # # For the RTC write functions, Andreas found another problem: both # pmu_request() and cuda_request() are varargs functions, so changing # the type of the arguments passed into them from 32 bit to 64 bit # breaks the API for the set_rtc_time functions. This changes it back to # 32 bits. # # The same code exists in arch/m68k/ and is patched in an identical way # now in a separate patch. # # Fixes: 5bfd643583b2 ("powerpc: use time64_t in read_persistent_clock") # Reported-by: Mathieu Malaterre # Reported-by: Andreas Schwab # Signed-off-by: Arnd Bergmann # Tested-by: Mathieu Malaterre # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 22db552b50fa11d8c1d171de908a1f9ef62172b7 # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mvme5100_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mvme5100_defconfig # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mvme5100_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1648:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:149:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/flow_dissector.c: In function '__skb_flow_dissect': /kisskb/src/net/core/flow_dissector.c:789:7: warning: 'vlan' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:269:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:234:28: note: 'next' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:246:2: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3161:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c: In function 'tun_get_user': /kisskb/src/drivers/net/tun.c:1835:30: warning: 'copylen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1545:31: warning: 'linear' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/net/tun.c:1745:46: note: 'linear' was declared here INFO: Uncompressed kernel (size 0x413ff8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x500000) Completed OK # rm -rf /kisskb/build/powerpc-fixes_mvme5100_defconfig_powerpc # Build took: 0:00:17.004792