# git rev-parse -q --verify d497ebf5fb3a026c0817f8c96cde578787f24093^{commit} d497ebf5fb3a026c0817f8c96cde578787f24093 already have revision, skipping fetch # git checkout -q -f -B kisskb d497ebf5fb3a026c0817f8c96cde578787f24093 # git clean -qxdf # < git log -1 # commit d497ebf5fb3a026c0817f8c96cde578787f24093 # Author: Frederic Barrat # Date: Mon Jun 18 14:14:36 2018 +0200 # # ocxl: Fix page fault handler in case of fault on dying process # # If a process exits without doing proper cleanup, there's a window # where an opencapi device can try to access the memory of the dying # process and may trigger a page fault. That's an expected scenario and # the ocxl driver holds a reference on the mm_struct of the process # until the opencapi device is notified of the process exiting. # However, if mm_users is already at 0, i.e. the address space of the # process has already been destroyed, the driver shouldn't try resolving # the page fault, as it will fail, but it can also try accessing already # freed data. # # It is fixed by only calling the bottom half of the page fault handler # if mm_users is greater than 0 and get a reference on mm_users instead # of mm_count. Otherwise, we can safely return a translation fault to # the device, as its associated memory context is being removed. The # opencapi device will be properly cleaned up shortly after when closing # the file descriptors. # # Fixes: 5ef3166e8a32 ("ocxl: Driver code for 'generic' opencapi devices") # Cc: stable@vger.kernel.org # v4.16+ # Signed-off-by: Frederic Barrat # Reviewed-By: Alastair D'Silva # Acked-by: Andrew Donnellan # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < git log --format=%s --max-count=1 d497ebf5fb3a026c0817f8c96cde578787f24093 # < make -s -j 48 ARCH=mips O=/kisskb/build/powerpc-next_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 48 ARCH=mips O=/kisskb/build/powerpc-next_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:146:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] FIT description: Linux 4.18.0-rc3-gd497ebf Created: Tue Jul 3 01:26:18 2018 Image 0 (kernel@0) Description: Linux 4.18.0-rc3-gd497ebf Created: Tue Jul 3 01:26:18 2018 Type: Kernel Image Compression: gzip compressed Data Size: 4335997 Bytes = 4234.37 kB = 4.14 MB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8082fb50 Hash algo: sha1 Hash value: 41f39e6afe0b77c24ebbf9e5b02179212b629f90 Image 1 (fdt@boston) Description: img,boston Device Tree Created: Tue Jul 3 01:26:18 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 3668 Bytes = 3.58 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 569c37cc891ce1e1f3a193cb41cc691a5d2debb5 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Tue Jul 3 01:26:18 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Tue Jul 3 01:26:18 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 509ce58e44c561d54539e64e9d4b47054e696fc6 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/powerpc-next_mips-defconfig_mips # Build took: 0:01:40.607205