# git rev-parse -q --verify d02d21ea007b6b33cdaf15c2f84fb1fea996ecc2^{commit} d02d21ea007b6b33cdaf15c2f84fb1fea996ecc2 already have revision, skipping fetch # git checkout -q -f -B kisskb d02d21ea007b6b33cdaf15c2f84fb1fea996ecc2 # git clean -qxdf # < git log -1 # commit d02d21ea007b6b33cdaf15c2f84fb1fea996ecc2 # Author: Linus Torvalds # Date: Wed Jul 4 18:17:51 2018 -0700 # # autofs: rename 'autofs' module back to 'autofs4' # # It turns out that systemd has a bug: it wants to load the autofs module # early because of some initialization ordering with udev, and it doesn't # do that correctly. Everywhere else it does the proper "look up module # name" that does the proper alias resolution, but in that early code, it # just uses a hardcoded "autofs4" for the module name. # # The result of that is that as of commit a2225d931f75 ("autofs: remove # left-over autofs4 stubs"), you get # # systemd[1]: Failed to insert module 'autofs4': No such file or directory # # in the system logs, and a lack of module loading. All this despite the # fact that we had very clearly marked 'autofs4' as an alias for this # module. # # What's so ridiculous about this is that literally everything else does # the module alias handling correctly, including really old versions of # systemd (that just used 'modprobe' to do this), and even all the other # systemd module loading code. # # Only that special systemd early module load code is broken, hardcoding # the module names for not just 'autofs4', but also "ipv6", "unix", # "ip_tables" and "virtio_rng". Very annoying. # # Instead of creating an _additional_ separate compatibility 'autofs4' # module, just rely on the fact that everybody else gets this right, and # just call the module 'autofs4' for compatibility reasons, with 'autofs' # as the alias name. # # That will allow the systemd people to fix their bugs, adding the proper # alias handling, and maybe even fix the name of the module to be just # "autofs" (so that they can _test_ the alias handling). And eventually, # we can revert this silly compatibility hack. # # See also # # https://github.com/systemd/systemd/issues/9501 # https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=902946 # # for the systemd bug reports upstream and in the Debian bug tracker # respectively. # # Fixes: a2225d931f75 ("autofs: remove left-over autofs4 stubs") # Reported-by: Ben Hutchings # Reported-by: Michael Biebl # Cc: Ian Kent # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux-gcc --version # < git log --format=%s --max-count=1 d02d21ea007b6b33cdaf15c2f84fb1fea996ecc2 # < make -s -j 120 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- a500_defconfig # make -s -j 120 ARCH=parisc O=/kisskb/build/linus_a500_defconfig_parisc64 CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa64-linux/bin/hppa64-linux- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/crypto/ablkcipher.c: In function 'crypto_ablkcipher_report': /kisskb/src/crypto/ablkcipher.c:374:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/ablkcipher.c: In function 'crypto_givcipher_report': /kisskb/src/crypto/ablkcipher.c:448:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/blkcipher.c: In function 'crypto_blkcipher_report': /kisskb/src/crypto/blkcipher.c:513:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_blkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'fill_kobj_path', inlined from 'kobject_get_path' at /kisskb/src/lib/kobject.c:155:2: /kisskb/src/lib/kobject.c:128:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(path + length, kobject_name(parent), cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/lib/kobject.c: In function 'kobject_get_path': /kisskb/src/lib/kobject.c:125:13: note: length computed here int cur = strlen(kobject_name(parent)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /kisskb/src/arch/parisc/include/asm/atomic.h:10, from /kisskb/src/include/linux/atomic.h:5, from /kisskb/src/arch/parisc/include/asm/bitops.h:13, from /kisskb/src/include/linux/bitops.h:38, from /kisskb/src/include/linux/kernel.h:11, from /kisskb/src/include/linux/list.h:9, from /kisskb/src/include/linux/module.h:9, from /kisskb/src/drivers/scsi/scsi_debug.c:23: /kisskb/src/drivers/scsi/scsi_debug.c: In function 'resp_start_stop': /kisskb/src/arch/parisc/include/asm/cmpxchg.h:48:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__xchg((unsigned long)(x), (ptr), sizeof(*(ptr)))) /kisskb/src/arch/parisc/include/asm/atomic.h:78:30: note: in expansion of macro 'xchg' #define atomic_xchg(v, new) (xchg(&((v)->counter), new)) ^~~~ /kisskb/src/drivers/scsi/scsi_debug.c:1622:2: note: in expansion of macro 'atomic_xchg' atomic_xchg(&devip->stopped, stop); ^~~~~~~~~~~ In function 'kernfs_get_target_path', inlined from 'kernfs_getlink' at /kisskb/src/fs/kernfs/symlink.c:109:10, inlined from 'kernfs_iop_get_link.part.0' at /kisskb/src/fs/kernfs/symlink.c:127:10, inlined from 'kernfs_iop_get_link': /kisskb/src/fs/kernfs/symlink.c:91:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(s + len, kn->name, slen); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/kernfs/symlink.c: In function 'kernfs_iop_get_link': /kisskb/src/fs/kernfs/symlink.c:88:14: note: length computed here int slen = strlen(kn->name); ^~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c: In function '__save_error_info': /kisskb/src/fs/ext4/super.c:326:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_last_error_func, func, sizeof(es->s_last_error_func)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c:330:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_first_error_func, func, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(es->s_first_error_func)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function '__xfs_xattr_put_listent', inlined from 'xfs_xattr_put_listent' at /kisskb/src/fs/xfs/xfs_xattr.c:204:2: /kisskb/src/fs/xfs/xfs_xattr.c:142:2: warning: 'strncpy' output may be truncated copying between 5 and 9 bytes from a string of length 9 [-Wstringop-truncation] strncpy(offset, prefix, prefix_len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_a500_defconfig_parisc64 # Build took: 0:00:34.768325