# git rev-parse -q --verify 9e049ef80be988e91cb55f3ddfa7c80a7b376852^{commit}
9e049ef80be988e91cb55f3ddfa7c80a7b376852
already have revision, skipping fetch
# git checkout -q -f -B kisskb 9e049ef80be988e91cb55f3ddfa7c80a7b376852
# git clean -qxdf
# < git log -1
# commit 9e049ef80be988e91cb55f3ddfa7c80a7b376852
# Author: Alexey Kardashevskiy <aik@ozlabs.ru>
# Date:   Thu Jul 5 18:01:33 2018 +1000
# 
#     KVM: PPC: Check if IOMMU page is contained in the pinned physical page
#     
#     A VM which has:
#      - a DMA capable device passed through to it (eg. network card);
#      - running a malicious kernel that ignores H_PUT_TCE failure;
#      - capability of using IOMMU pages bigger that physical pages
#     can create an IOMMU mapping that exposes (for example) 16MB of
#     the host physical memory to the device when only 64K was allocated to
#     the VM.
#     
#     The remaining 16MB - 64K will be some other content of host memory,
#     possibly including pages of the VM, but also pages of host kernel memory,
#     host programs or other VMs.
#     
#     The attacking VM does not control the location of the page it can map,
#     and is only allowed to map as many pages as it has pages of RAM.
#     
#     We already have a check in drivers/vfio/vfio_iommu_spapr_tce.c that
#     an IOMMU page is contained in the physical page so the PCI hardware won't
#     get access to unassigned host memory; however this check is missing in
#     the KVM fastpath (H_PUT_TCE accelerated code). We were lucky so far and
#     did not hit this yet as the very first time when the mapping happens
#     we do not have tbl::it_userspace allocated yet and fall back to
#     the userspace which in turn calls VFIO IOMMU driver, this fails and
#     the guest does not retry,
#     
#     This stores the smallest preregistered page size in the preregistered
#     region descriptor and changes the mm_iommu_xxx API to check this against
#     the IOMMU page size. This calculates maximum page size as a minimum of
#     the natural region alignment and compound page size.
#     
#     Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
#     Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
# < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version
# < git log --format=%s --max-count=1 9e049ef80be988e91cb55f3ddfa7c80a7b376852
# < make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  allyesconfig
# Added to kconfig CONFIG_PROFILE_ALL_BRANCHES=n
# Added to kconfig CONFIG_ENABLE_WARN_DEPRECATED=n
# Added to kconfig CONFIG_ENABLE_MUST_CHECK=n
# Added to kconfig CONFIG_DEBUG_INFO=n
# Added to kconfig CONFIG_BUILD_DOCSRC=n
# Added to kconfig CONFIG_MODULE_SIG=n
# yes \n | make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  oldconfig
yes: standard output: Broken pipe
yes: write error
# make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-  
/kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter.
/kisskb/src/sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get':
/kisskb/src/sound/aoa/codecs/onyx.c:380:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized]
  ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity;
                                     ^
In file included from /kisskb/src/include/linux/io.h:25:0,
                 from /kisskb/src/include/linux/of_address.h:7,
                 from /kisskb/src/drivers/ata/ahci_qoriq.c:18:
/kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset':
/kisskb/src/arch/powerpc/include/asm/io.h:633:3: warning: 'px_is' may be used uninitialized in this function [-Wmaybe-uninitialized]
   ppc_pci_io.name al;    \
   ^
/kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here
  u32 px_cmd, px_is, px_val;
              ^
In file included from /kisskb/src/include/linux/io.h:25:0,
                 from /kisskb/src/include/linux/of_address.h:7,
                 from /kisskb/src/drivers/ata/ahci_qoriq.c:18:
/kisskb/src/arch/powerpc/include/asm/io.h:142:2: warning: 'px_cmd' may be used uninitialized in this function [-Wmaybe-uninitialized]
  __asm__ __volatile__("sync;"#insn" %1,%y0"   \
  ^
/kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here
  u32 px_cmd, px_is, px_val;
      ^
/kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter.
Completed OK
# rm -rf /kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3
# Build took: 0:29:45.025863