# git rev-parse -q --verify 2dfc21550af6fcc9dbd445da241f8f963d25c782^{commit} 2dfc21550af6fcc9dbd445da241f8f963d25c782 already have revision, skipping fetch # git checkout -q -f -B kisskb 2dfc21550af6fcc9dbd445da241f8f963d25c782 # git clean -qxdf # < git log -1 # commit 2dfc21550af6fcc9dbd445da241f8f963d25c782 # Author: Michael Ellerman # Date: Mon Jul 16 23:52:14 2018 +1000 # # powerpc/xmon: Fix disassembly since printf changes # # The recent change to add printf annotations to xmon inadvertently made # the disassembly output ugly, eg: # # c00000002001e058 7ee00026 mfcr r23 # c00000002001e05c fffffffffae101a0 std r23,416(r1) # c00000002001e060 fffffffff8230000 std r1,0(r3) # # The problem being that negative 32-bit values are being displayed in # full 64-bits. # # The printf conversion was actually correct, we are passing unsigned # long so it should use "lx". But powerpc instructions are only 4 bytes # and the code only reads 4 bytes, so inst should really just be # unsigned int, and that also fixes the printing to look the way we # want: # # c00000002001e058 7ee00026 mfcr r23 # c00000002001e05c fae101a0 std r23,416(r1) # c00000002001e060 f8230000 std r1,0(r3) # # Fixes: e70d8f55268b ("powerpc/xmon: Add __printf annotation to xmon_printf()") # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 2dfc21550af6fcc9dbd445da241f8f963d25c782 # < make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_44x_eiger_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- 44x/eiger_defconfig # make -s -j 10 ARCH=powerpc O=/kisskb/build/powerpc-fixes_44x_eiger_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here Completed OK # rm -rf /kisskb/build/powerpc-fixes_44x_eiger_defconfig_powerpc # Build took: 0:01:03.954791