# git rev-parse -q --verify 3c53776e29f81719efcf8f7a6e30cdf753bee94d^{commit} 3c53776e29f81719efcf8f7a6e30cdf753bee94d already have revision, skipping fetch # git checkout -q -f -B kisskb 3c53776e29f81719efcf8f7a6e30cdf753bee94d # git clean -qxdf # < git log -1 # commit 3c53776e29f81719efcf8f7a6e30cdf753bee94d # Author: Linus Torvalds # Date: Mon Jan 8 11:51:04 2018 -0800 # # Mark HI and TASKLET softirq synchronous # # Way back in 4.9, we committed 4cd13c21b207 ("softirq: Let ksoftirqd do # its job"), and ever since we've had small nagging issues with it. For # example, we've had: # # 1ff688209e2e ("watchdog: core: make sure the watchdog_worker is not deferred") # 8d5755b3f77b ("watchdog: softdog: fire watchdog even if softirqs do not get to run") # 217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()") # # all of which worked around some of the effects of that commit. # # The DVB people have also complained that the commit causes excessive USB # URB latencies, which seems to be due to the USB code using tasklets to # schedule USB traffic. This seems to be an issue mainly when already # living on the edge, but waiting for ksoftirqd to handle it really does # seem to cause excessive latencies. # # Now Hanna Hawa reports that this issue isn't just limited to USB URB and # DVB, but also causes timeout problems for the Marvell SoC team: # # "I'm facing kernel panic issue while running raid 5 on sata disks # connected to Macchiatobin (Marvell community board with Armada-8040 # SoC with 4 ARMv8 cores of CA72) Raid 5 built with Marvell DMA engine # and async_tx mechanism (ASYNC_TX_DMA [=y]); the DMA driver (mv_xor_v2) # uses a tasklet to clean the done descriptors from the queue" # # The latency problem causes a panic: # # mv_xor_v2 f0400000.xor: dma_sync_wait: timeout! # Kernel panic - not syncing: async_tx_quiesce: DMA error waiting for transaction # # We've discussed simply just reverting the original commit entirely, and # also much more involved solutions (with per-softirq threads etc). This # patch is intentionally stupid and fairly limited, because the issue # still remains, and the other solutions either got sidetracked or had # other issues. # # We should probably also consider the timer softirqs to be synchronous # and not be delayed to ksoftirqd (since they were the issue with the # earlier watchdog problems), but that should be done as a separate patch. # This does only the tasklet cases. # # Reported-and-tested-by: Hanna Hawa # Reported-and-tested-by: Josef Griebichler # Reported-by: Mauro Carvalho Chehab # Cc: Alan Stern # Cc: Greg Kroah-Hartman # Cc: Eric Dumazet # Cc: Ingo Molnar # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version # < git log --format=%s --max-count=1 3c53776e29f81719efcf8f7a6e30cdf753bee94d # < make -s -j 10 ARCH=nds32 O=/kisskb/build/linus_nds32-defconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- defconfig # make -s -j 10 ARCH=nds32 O=/kisskb/build/linus_nds32-defconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In function 'fill_item_path', inlined from 'configfs_get_target_path' at /kisskb/src/fs/configfs/symlink.c:250:2, inlined from 'configfs_getlink' at /kisskb/src/fs/configfs/symlink.c:272:10, inlined from 'configfs_get_link' at /kisskb/src/fs/configfs/symlink.c:295:10: /kisskb/src/fs/configfs/symlink.c:67:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(buffer + length,config_item_name(p),cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/configfs/symlink.c: In function 'configfs_get_link': /kisskb/src/fs/configfs/symlink.c:63:13: note: length computed here int cur = strlen(config_item_name(p)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/ablkcipher.c: In function 'crypto_ablkcipher_report': /kisskb/src/crypto/ablkcipher.c:374:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/ablkcipher.c: In function 'crypto_givcipher_report': /kisskb/src/crypto/ablkcipher.c:448:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/blkcipher.c: In function 'crypto_blkcipher_report': /kisskb/src/crypto/blkcipher.c:513:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_blkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'kernfs_get_target_path', inlined from 'kernfs_getlink.isra.0' at /kisskb/src/fs/kernfs/symlink.c:109:10, inlined from 'kernfs_iop_get_link' at /kisskb/src/fs/kernfs/symlink.c:127:10: /kisskb/src/fs/kernfs/symlink.c:91:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(s + len, kn->name, slen); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/kernfs/symlink.c: In function 'kernfs_iop_get_link': /kisskb/src/fs/kernfs/symlink.c:88:14: note: length computed here int slen = strlen(kn->name); ^~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c: In function '__save_error_info.isra.4': /kisskb/src/fs/ext4/super.c:326:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_last_error_func, func, sizeof(es->s_last_error_func)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c:330:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_first_error_func, func, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(es->s_first_error_func)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'fill_kobj_path', inlined from 'kobject_get_path' at /kisskb/src/lib/kobject.c:155:2: /kisskb/src/lib/kobject.c:128:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(path + length, kobject_name(parent), cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/lib/kobject.c: In function 'kobject_get_path': /kisskb/src/lib/kobject.c:125:13: note: length computed here int cur = strlen(kobject_name(parent)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: kernel/time/timekeeping.o: in function `timekeeping_init': timekeeping.c:(.init.text+0x1a8): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: timekeeping.c:(.init.text+0x1ac): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: timekeeping.c:(.init.text+0x1ec): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: timekeeping.c:(.init.text+0x1f0): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: fs/direct-io.o: in function `do_direct_IO': direct-io.c:(.text+0x16a0): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '40456', this reader only handles version 2, 3, 4 and 5 information direct-io.c:(.text+0x16a4): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: direct-io.c:(.text+0x1858): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '2096', this reader only handles version 2, 3, 4 and 5 information direct-io.c:(.text+0x185c): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '9492', this reader only handles version 2, 3, 4 and 5 information fs/ext4/mballoc.o: in function `ext4_mb_normalize_request.constprop.10': mballoc.c:(.text+0x1bbe): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: mballoc.c:(.text+0x1bc2): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '10772', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c0e): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '3159', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c12): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '17', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c46): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '10772', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c4a): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '17602', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c6c): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '21', this reader only handles version 2, 3, 4 and 5 information mballoc.c:(.text+0x1c70): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '26644', this reader only handles version 2, 3, 4 and 5 information fs/ext4/super.o: in function `ext4_fill_super': super.c:(.text+0x6500): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: super.c:(.text+0x6504): undefined reference to `__ashrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '27924', this reader only handles version 2, 3, 4 and 5 information super.c:(.text+0x7e34): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '8527', this reader only handles version 2, 3, 4 and 5 information super.c:(.text+0x7e38): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '18', this reader only handles version 2, 3, 4 and 5 information super.c:(.text+0x7fe0): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: DWARF error: found dwarf version '27924', this reader only handles version 2, 3, 4 and 5 information super.c:(.text+0x7fe4): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: drivers/clocksource/mmio.o: in function `clocksource_mmio_init': mmio.c:(.init.text+0x5c): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: mmio.c:(.init.text+0x60): undefined reference to `__lshrdi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: net/ipv4/tcp_ipv4.o: in function `tcp_v4_err': tcp_ipv4.c:(.text+0x25a8): undefined reference to `__ashldi3' /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-ld: tcp_ipv4.c:(.text+0x25ac): undefined reference to `__ashldi3' /kisskb/src/Makefile:1005: recipe for target 'vmlinux' failed make[1]: *** [vmlinux] Error 1 Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 10 ARCH=nds32 O=/kisskb/build/linus_nds32-defconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus_nds32-defconfig_nds32le # Build took: 0:01:43.930044