# git rev-parse -q --verify 3c53776e29f81719efcf8f7a6e30cdf753bee94d^{commit} 3c53776e29f81719efcf8f7a6e30cdf753bee94d already have revision, skipping fetch # git checkout -q -f -B kisskb 3c53776e29f81719efcf8f7a6e30cdf753bee94d # git clean -qxdf # < git log -1 # commit 3c53776e29f81719efcf8f7a6e30cdf753bee94d # Author: Linus Torvalds # Date: Mon Jan 8 11:51:04 2018 -0800 # # Mark HI and TASKLET softirq synchronous # # Way back in 4.9, we committed 4cd13c21b207 ("softirq: Let ksoftirqd do # its job"), and ever since we've had small nagging issues with it. For # example, we've had: # # 1ff688209e2e ("watchdog: core: make sure the watchdog_worker is not deferred") # 8d5755b3f77b ("watchdog: softdog: fire watchdog even if softirqs do not get to run") # 217f69743681 ("net: busy-poll: allow preemption in sk_busy_loop()") # # all of which worked around some of the effects of that commit. # # The DVB people have also complained that the commit causes excessive USB # URB latencies, which seems to be due to the USB code using tasklets to # schedule USB traffic. This seems to be an issue mainly when already # living on the edge, but waiting for ksoftirqd to handle it really does # seem to cause excessive latencies. # # Now Hanna Hawa reports that this issue isn't just limited to USB URB and # DVB, but also causes timeout problems for the Marvell SoC team: # # "I'm facing kernel panic issue while running raid 5 on sata disks # connected to Macchiatobin (Marvell community board with Armada-8040 # SoC with 4 ARMv8 cores of CA72) Raid 5 built with Marvell DMA engine # and async_tx mechanism (ASYNC_TX_DMA [=y]); the DMA driver (mv_xor_v2) # uses a tasklet to clean the done descriptors from the queue" # # The latency problem causes a panic: # # mv_xor_v2 f0400000.xor: dma_sync_wait: timeout! # Kernel panic - not syncing: async_tx_quiesce: DMA error waiting for transaction # # We've discussed simply just reverting the original commit entirely, and # also much more involved solutions (with per-softirq threads etc). This # patch is intentionally stupid and fairly limited, because the issue # still remains, and the other solutions either got sidetracked or had # other issues. # # We should probably also consider the timer softirqs to be synchronous # and not be delayed to ksoftirqd (since they were the issue with the # earlier watchdog problems), but that should be done as a separate patch. # This does only the tasklet cases. # # Reported-and-tested-by: Hanna Hawa # Reported-and-tested-by: Josef Griebichler # Reported-by: Mauro Carvalho Chehab # Cc: Alan Stern # Cc: Greg Kroah-Hartman # Cc: Eric Dumazet # Cc: Ingo Molnar # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux-gcc --version # < git log --format=%s --max-count=1 3c53776e29f81719efcf8f7a6e30cdf753bee94d # < make -s -j 48 ARCH=sh O=/kisskb/build/linus_shmin_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- shmin_defconfig # make -s -j 48 ARCH=sh O=/kisskb/build/linus_shmin_defconfig_sh4 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/sh4-linux/bin/sh4-linux- Generating include/generated/machtypes.h :1317:2: warning: #warning syscall pkey_mprotect not implemented [-Wcpp] :1320:2: warning: #warning syscall pkey_alloc not implemented [-Wcpp] :1323:2: warning: #warning syscall pkey_free not implemented [-Wcpp] :1326:2: warning: #warning syscall statx not implemented [-Wcpp] :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S: Assembler messages: /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S:389: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/sh3/../../entry-common.S:392: Warning: overflow in branch to syscall_exit_work; converted into longer instruction sequence /kisskb/src/arch/sh/kernel/cpu/clock-cpg.c: In function 'cpg_clk_init': /kisskb/src/arch/sh/kernel/cpu/clock-cpg.c:53:3: warning: 'arch_init_clk_ops' is deprecated (declared at /kisskb/src/arch/sh/include/asm/clock.h:8) [-Wdeprecated-declarations] /kisskb/src/arch/sh/kernel/cpu/clock-cpg.c: In function 'arch_clk_init': /kisskb/src/arch/sh/kernel/cpu/clock-cpg.c:77:2: warning: 'cpg_clk_init' is deprecated (declared at /kisskb/src/arch/sh/kernel/cpu/clock-cpg.c:47) [-Wdeprecated-declarations] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/sh/clk/cpg.c: In function 'r8': /kisskb/src/drivers/sh/clk/cpg.c:41:2: warning: passing argument 1 of 'ioread8' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:29:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r16': /kisskb/src/drivers/sh/clk/cpg.c:46:2: warning: passing argument 1 of 'ioread16' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:30:21: note: expected 'void *' but argument is of type 'const void *' /kisskb/src/drivers/sh/clk/cpg.c: In function 'r32': /kisskb/src/drivers/sh/clk/cpg.c:51:2: warning: passing argument 1 of 'ioread32' discards 'const' qualifier from pointer target type [enabled by default] /kisskb/src/include/asm-generic/iomap.h:32:21: note: expected 'void *' but argument is of type 'const void *' Kernel: arch/sh/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_shmin_defconfig_sh4 # Build took: 0:00:27.056349