# git rev-parse -q --verify 76fa4975f3ed12d15762bc979ca44078598ed8ee^{commit} 76fa4975f3ed12d15762bc979ca44078598ed8ee already have revision, skipping fetch # git checkout -q -f -B kisskb 76fa4975f3ed12d15762bc979ca44078598ed8ee # git clean -qxdf # < git log -1 # commit 76fa4975f3ed12d15762bc979ca44078598ed8ee # Author: Alexey Kardashevskiy # Date: Tue Jul 17 17:19:13 2018 +1000 # # KVM: PPC: Check if IOMMU page is contained in the pinned physical page # # A VM which has: # - a DMA capable device passed through to it (eg. network card); # - running a malicious kernel that ignores H_PUT_TCE failure; # - capability of using IOMMU pages bigger that physical pages # can create an IOMMU mapping that exposes (for example) 16MB of # the host physical memory to the device when only 64K was allocated to the VM. # # The remaining 16MB - 64K will be some other content of host memory, possibly # including pages of the VM, but also pages of host kernel memory, host # programs or other VMs. # # The attacking VM does not control the location of the page it can map, # and is only allowed to map as many pages as it has pages of RAM. # # We already have a check in drivers/vfio/vfio_iommu_spapr_tce.c that # an IOMMU page is contained in the physical page so the PCI hardware won't # get access to unassigned host memory; however this check is missing in # the KVM fastpath (H_PUT_TCE accelerated code). We were lucky so far and # did not hit this yet as the very first time when the mapping happens # we do not have tbl::it_userspace allocated yet and fall back to # the userspace which in turn calls VFIO IOMMU driver, this fails and # the guest does not retry, # # This stores the smallest preregistered page size in the preregistered # region descriptor and changes the mm_iommu_xxx API to check this against # the IOMMU page size. # # This calculates maximum page size as a minimum of the natural region # alignment and compound page size. For the page shift this uses the shift # returned by find_linux_pte() which indicates how the page is mapped to # the current userspace - if the page is huge and this is not a zero, then # it is a leaf pte and the page is mapped within the range. # # Fixes: 121f80ba68f1 ("KVM: PPC: VFIO: Add in-kernel acceleration for VFIO") # Cc: stable@vger.kernel.org # v4.12+ # Signed-off-by: Alexey Kardashevskiy # Reviewed-by: David Gibson # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 76fa4975f3ed12d15762bc979ca44078598ed8ee # < make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc5200_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mpc5200_defconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc5200_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:225:6: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here INFO: Uncompressed kernel (size 0x6d01cc) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x6d01cc) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x6d01cc) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x6bfb20) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) Image Name: Linux-4.18.0-rc3-g76fa497 Created: Wed Jul 18 19:44:33 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3395381 Bytes = 3315.80 kB = 3.24 MB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-4.18.0-rc3-g76fa497 Created: Wed Jul 18 19:44:33 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3418768 Bytes = 3338.64 kB = 3.26 MB Load Address: 00700000 Entry Point: 00700248 Image Name: Linux-4.18.0-rc3-g76fa497 Created: Wed Jul 18 19:44:33 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3418856 Bytes = 3338.73 kB = 3.26 MB Load Address: 00700000 Entry Point: 00700248 Image Name: Linux-4.18.0-rc3-g76fa497 Created: Wed Jul 18 19:44:33 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3418880 Bytes = 3338.75 kB = 3.26 MB Load Address: 00700000 Entry Point: 00700248 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc5200_defconfig_powerpc # Build took: 0:00:54.475431