# git rev-parse -q --verify 76fa4975f3ed12d15762bc979ca44078598ed8ee^{commit} 76fa4975f3ed12d15762bc979ca44078598ed8ee already have revision, skipping fetch # git checkout -q -f -B kisskb 76fa4975f3ed12d15762bc979ca44078598ed8ee # git clean -qxdf # < git log -1 # commit 76fa4975f3ed12d15762bc979ca44078598ed8ee # Author: Alexey Kardashevskiy # Date: Tue Jul 17 17:19:13 2018 +1000 # # KVM: PPC: Check if IOMMU page is contained in the pinned physical page # # A VM which has: # - a DMA capable device passed through to it (eg. network card); # - running a malicious kernel that ignores H_PUT_TCE failure; # - capability of using IOMMU pages bigger that physical pages # can create an IOMMU mapping that exposes (for example) 16MB of # the host physical memory to the device when only 64K was allocated to the VM. # # The remaining 16MB - 64K will be some other content of host memory, possibly # including pages of the VM, but also pages of host kernel memory, host # programs or other VMs. # # The attacking VM does not control the location of the page it can map, # and is only allowed to map as many pages as it has pages of RAM. # # We already have a check in drivers/vfio/vfio_iommu_spapr_tce.c that # an IOMMU page is contained in the physical page so the PCI hardware won't # get access to unassigned host memory; however this check is missing in # the KVM fastpath (H_PUT_TCE accelerated code). We were lucky so far and # did not hit this yet as the very first time when the mapping happens # we do not have tbl::it_userspace allocated yet and fall back to # the userspace which in turn calls VFIO IOMMU driver, this fails and # the guest does not retry, # # This stores the smallest preregistered page size in the preregistered # region descriptor and changes the mm_iommu_xxx API to check this against # the IOMMU page size. # # This calculates maximum page size as a minimum of the natural region # alignment and compound page size. For the page shift this uses the shift # returned by find_linux_pte() which indicates how the page is mapped to # the current userspace - if the page is huge and this is not a zero, then # it is a leaf pte and the page is mapped within the range. # # Fixes: 121f80ba68f1 ("KVM: PPC: VFIO: Add in-kernel acceleration for VFIO") # Cc: stable@vger.kernel.org # v4.12+ # Signed-off-by: Alexey Kardashevskiy # Reviewed-by: David Gibson # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-gcc --version # < git log --format=%s --max-count=1 76fa4975f3ed12d15762bc979ca44078598ed8ee # < make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_sparc64-defconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- defconfig # make -s -j 40 ARCH=sparc64 O=/kisskb/build/powerpc-fixes_sparc64-defconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] WARNING: EXPORT symbol "_mcount" [vmlinux] version generation failed, symbol will not be versioned. kernel: arch/sparc/boot/image is ready WARNING: EXPORT symbol "_mcount" [vmlinux] version generation failed, symbol will not be versioned. kernel: arch/sparc/boot/zImage is ready Completed OK # rm -rf /kisskb/build/powerpc-fixes_sparc64-defconfig_sparc64 # Build took: 0:00:40.627990