# git rev-parse -q --verify 46d8c4b28652d35dc6cfb5adf7f54e102fc04384^{commit} 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 already have revision, skipping fetch # git checkout -q -f -B kisskb 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 # git clean -qxdf # < git log -1 # commit 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 # Author: Herbert Xu # Date: Fri Jul 13 16:12:32 2018 +0800 # # crypto: padlock-aes - Fix Nano workaround data corruption # # This was detected by the self-test thanks to Ard's chunking patch. # # I finally got around to testing this out on my ancient Via box. It # turns out that the workaround got the assembly wrong and we end up # doing count + initial cycles of the loop instead of just count. # # This obviously causes corruption, either by overwriting the source # that is yet to be processed, or writing over the end of the buffer. # # On CPUs that don't require the workaround only ECB is affected. # On Nano CPUs both ECB and CBC are affected. # # This patch fixes it by doing the subtraction prior to the assembly. # # Fixes: a76c1c23d0c3 ("crypto: padlock-aes - work around Nano CPU...") # Cc: # Reported-by: Jamie Heilman # Signed-off-by: Herbert Xu # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < git log --format=%s --max-count=1 46d8c4b28652d35dc6cfb5adf7f54e102fc04384 # < make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- allnoconfig # make -s -j 48 ARCH=x86_64 O=/kisskb/build/crypto_x86_64-allnoconfig_x86_64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1033:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:650:16: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/crypto_x86_64-allnoconfig_x86_64 # Build took: 0:00:14.798681