# git rev-parse -q --verify cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a^{commit} cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a already have revision, skipping fetch # git checkout -q -f -B kisskb cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # git clean -qxdf # < git log -1 # commit cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # Author: Frederic Barrat # Date: Tue Jul 31 15:24:52 2018 +0200 # # powerpc/64s/radix: Fix missing global invalidations when removing copro # # With the optimizations for TLB invalidation from commit 0cef77c7798a # ("powerpc/64s/radix: flush remote CPUs out of single-threaded # mm_cpumask"), the scope of a TLBI (global vs. local) can now be # influenced by the value of the 'copros' counter of the memory context. # # When calling mm_context_remove_copro(), the 'copros' counter is # decremented first before flushing. It may have the unintended side # effect of sending local TLBIs when we explicitly need global # invalidations in this case. Thus breaking any nMMU user in a bad and # unpredictable way. # # Fix it by flushing first, before updating the 'copros' counter, so # that invalidations will be global. # # Fixes: 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask") # Signed-off-by: Frederic Barrat # Reviewed-by: Nicholas Piggin # Tested-by: Vaibhav Jain # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux-gcc --version # < git log --format=%s --max-count=1 cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # < make -s -j 48 ARCH=x86 O=/kisskb/build/powerpc-fixes_x86_64_defconfig_x86_64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- x86_64_defconfig # make -s -j 48 ARCH=x86 O=/kisskb/build/powerpc-fixes_x86_64_defconfig_x86_64 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/x86_64-linux/bin/x86_64-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1033:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] kernel/trace/trace.o: warning: objtool: tracing_start()+0x6d: unreachable instruction kernel/rcu/tree.o: warning: objtool: rcu_init()+0x1c5: unreachable instruction /kisskb/src/mm/vmstat.c: In function 'sysctl_vm_numa_stat_handler': /kisskb/src/mm/vmstat.c:89:5: warning: 'oldval' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:653:2: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] drivers/clk/clk.o: warning: objtool: clk_prepare_unlock()+0x44: unreachable instruction /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] fs/aio.o: warning: objtool: aio_nr_sub()+0x2d: unreachable instruction /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:207:2: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:160:17: note: 'k' was declared here /kisskb/src/net/mac80211/mlme.c: In function 'ieee80211_rx_mgmt_beacon': /kisskb/src/net/mac80211/mlme.c:1353:3: warning: 'pwr_level_cisco' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/mac80211/mlme.c:1310:6: note: 'pwr_level_cisco' was declared here Completed OK # rm -rf /kisskb/build/powerpc-fixes_x86_64_defconfig_x86_64 # Build took: 0:01:29.273941