# git rev-parse -q --verify cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a^{commit} cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a already have revision, skipping fetch # git checkout -q -f -B kisskb cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # git clean -qxdf # < git log -1 # commit cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # Author: Frederic Barrat # Date: Tue Jul 31 15:24:52 2018 +0200 # # powerpc/64s/radix: Fix missing global invalidations when removing copro # # With the optimizations for TLB invalidation from commit 0cef77c7798a # ("powerpc/64s/radix: flush remote CPUs out of single-threaded # mm_cpumask"), the scope of a TLBI (global vs. local) can now be # influenced by the value of the 'copros' counter of the memory context. # # When calling mm_context_remove_copro(), the 'copros' counter is # decremented first before flushing. It may have the unintended side # effect of sending local TLBIs when we explicitly need global # invalidations in this case. Thus breaking any nMMU user in a bad and # unpredictable way. # # Fix it by flushing first, before updating the 'copros' counter, so # that invalidations will be global. # # Fixes: 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask") # Signed-off-by: Frederic Barrat # Reviewed-by: Nicholas Piggin # Tested-by: Vaibhav Jain # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux-gcc --version # < git log --format=%s --max-count=1 cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # < make -s -j 120 ARCH=mips O=/kisskb/build/powerpc-fixes_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- defconfig # make -s -j 120 ARCH=mips O=/kisskb/build/powerpc-fixes_mips-defconfig_mips CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/mips-linux/bin/mips-linux- /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:146:32: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here /kisskb/src/arch/mips/vdso/Makefile:32: MIPS VDSO requires binutils >= 2.25 /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] FIT description: Linux 4.18.0-rc3-gcca19f0 Created: Thu Aug 2 01:16:17 2018 Image 0 (kernel@0) Description: Linux 4.18.0-rc3-gcca19f0 Created: Thu Aug 2 01:16:17 2018 Type: Kernel Image Compression: gzip compressed Data Size: 4335999 Bytes = 4234.37 kB = 4.14 MB Architecture: MIPS OS: Linux Load Address: 0x80100000 Entry Point: 0x8082fb50 Hash algo: sha1 Hash value: cfabaa40a2a0ced7af884d9fac03cdb4a7ed87bc Image 1 (fdt@boston) Description: img,boston Device Tree Created: Thu Aug 2 01:16:17 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 3668 Bytes = 3.58 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 569c37cc891ce1e1f3a193cb41cc691a5d2debb5 Image 2 (fdt@ni169445) Description: NI 169445 device tree Created: Thu Aug 2 01:16:17 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 1871 Bytes = 1.83 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 51b89b31605ee62038c8468c429af091dfc75ec7 Image 3 (fdt@xilfpga) Description: MIPSfpga (xilfpga) Device Tree Created: Thu Aug 2 01:16:17 2018 Type: Flat Device Tree Compression: uncompressed Data Size: 2708 Bytes = 2.64 kB = 0.00 MB Architecture: MIPS Hash algo: sha1 Hash value: 509ce58e44c561d54539e64e9d4b47054e696fc6 Default Configuration: 'conf@default' Configuration 0 (conf@default) Description: Generic Linux kernel Kernel: kernel@0 Configuration 1 (conf@boston) Description: Boston Linux kernel Kernel: kernel@0 FDT: fdt@boston Configuration 2 (conf@ni169445) Description: NI 169445 Linux Kernel Kernel: kernel@0 FDT: fdt@ni169445 Configuration 3 (conf@xilfpga) Description: MIPSfpga Linux kernel Kernel: kernel@0 FDT: fdt@xilfpga Completed OK # rm -rf /kisskb/build/powerpc-fixes_mips-defconfig_mips # Build took: 0:00:46.993409