# git rev-parse -q --verify cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a^{commit} cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a already have revision, skipping fetch # git checkout -q -f -B kisskb cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # git clean -qxdf # < git log -1 # commit cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # Author: Frederic Barrat # Date: Tue Jul 31 15:24:52 2018 +0200 # # powerpc/64s/radix: Fix missing global invalidations when removing copro # # With the optimizations for TLB invalidation from commit 0cef77c7798a # ("powerpc/64s/radix: flush remote CPUs out of single-threaded # mm_cpumask"), the scope of a TLBI (global vs. local) can now be # influenced by the value of the 'copros' counter of the memory context. # # When calling mm_context_remove_copro(), the 'copros' counter is # decremented first before flushing. It may have the unintended side # effect of sending local TLBIs when we explicitly need global # invalidations in this case. Thus breaking any nMMU user in a bad and # unpredictable way. # # Fix it by flushing first, before updating the 'copros' counter, so # that invalidations will be global. # # Fixes: 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask") # Signed-off-by: Frederic Barrat # Reviewed-by: Nicholas Piggin # Tested-by: Vaibhav Jain # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # < make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- allyesconfig # Added to kconfig CONFIG_PROFILE_ALL_BRANCHES=n # Added to kconfig CONFIG_ENABLE_WARN_DEPRECATED=n # Added to kconfig CONFIG_ENABLE_MUST_CHECK=n # Added to kconfig CONFIG_DEBUG_INFO=n # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # yes \n | make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 80 ARCH=powerpc O=/kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/sound/aoa/codecs/onyx.c: In function 'onyx_snd_single_bit_get': /kisskb/src/sound/aoa/codecs/onyx.c:380:37: warning: 'c' may be used uninitialized in this function [-Wmaybe-uninitialized] ucontrol->value.integer.value[0] = !!(c & mask) ^ polarity; ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/include/linux/of_address.h:7, from /kisskb/src/drivers/ata/ahci_qoriq.c:18: /kisskb/src/drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_hardreset': /kisskb/src/arch/powerpc/include/asm/io.h:633:3: warning: 'px_is' may be used uninitialized in this function [-Wmaybe-uninitialized] ppc_pci_io.name al; \ ^ /kisskb/src/drivers/ata/ahci_qoriq.c:86:14: note: 'px_is' was declared here u32 px_cmd, px_is, px_val; ^ In file included from /kisskb/src/include/linux/io.h:25:0, from /kisskb/src/include/linux/of_address.h:7, from /kisskb/src/drivers/ata/ahci_qoriq.c:18: /kisskb/src/arch/powerpc/include/asm/io.h:142:2: warning: 'px_cmd' may be used uninitialized in this function [-Wmaybe-uninitialized] __asm__ __volatile__("sync;"#insn" %1,%y0" \ ^ /kisskb/src/drivers/ata/ahci_qoriq.c:86:6: note: 'px_cmd' was declared here u32 px_cmd, px_is, px_val; ^ Completed OK # rm -rf /kisskb/build/powerpc-fixes_powerpc-allyesconfig_powerpc-5.3 # Build took: 0:16:42.927580