# git rev-parse -q --verify cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a^{commit} cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a already have revision, skipping fetch # git checkout -q -f -B kisskb cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # git clean -qxdf # < git log -1 # commit cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # Author: Frederic Barrat # Date: Tue Jul 31 15:24:52 2018 +0200 # # powerpc/64s/radix: Fix missing global invalidations when removing copro # # With the optimizations for TLB invalidation from commit 0cef77c7798a # ("powerpc/64s/radix: flush remote CPUs out of single-threaded # mm_cpumask"), the scope of a TLBI (global vs. local) can now be # influenced by the value of the 'copros' counter of the memory context. # # When calling mm_context_remove_copro(), the 'copros' counter is # decremented first before flushing. It may have the unintended side # effect of sending local TLBIs when we explicitly need global # invalidations in this case. Thus breaking any nMMU user in a bad and # unpredictable way. # # Fix it by flushing first, before updating the 'copros' counter, so # that invalidations will be global. # # Fixes: 0cef77c7798a ("powerpc/64s/radix: flush remote CPUs out of single-threaded mm_cpumask") # Signed-off-by: Frederic Barrat # Reviewed-by: Nicholas Piggin # Tested-by: Vaibhav Jain # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 cca19f0b684f4ed6aabf6ad07ae3e15e77bfd78a # < make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mpc885_ads_defconfig # Added to kconfig CONFIG_HUGETLBFS=y # yes \n | make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 120 ARCH=powerpc O=/kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] Image Name: Linux-4.18.0-rc3-gcca19f0 Created: Thu Aug 2 02:18:16 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 1787232 Bytes = 1745.34 kB = 1.70 MB Load Address: 00400000 Entry Point: 004001a4 Completed OK # rm -rf /kisskb/build/powerpc-fixes_mpc885_ads_defconfig+HUGETLB_powerpc # Build took: 0:00:21.343086