# git rev-parse -q --verify 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c^{commit} 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c already have revision, skipping fetch # git checkout -q -f -B kisskb 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # git clean -qxdf # < git log -1 # commit 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # Author: John Stultz # Date: Tue Jul 31 10:17:04 2018 -0700 # # staging: ashmem: Fix SIGBUS crash when traversing mmaped ashmem pages # # Amit Pundir and Youling in parallel reported crashes with recent # mainline kernels running Android: # # F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** # F DEBUG : Build fingerprint: 'Android/db410c32_only/db410c32_only:Q/OC-MR1/102:userdebug/test-key # F DEBUG : Revision: '0' # F DEBUG : ABI: 'arm' # F DEBUG : pid: 2261, tid: 2261, name: zygote >>> zygote <<< # F DEBUG : signal 7 (SIGBUS), code 2 (BUS_ADRERR), fault addr 0xec00008 # ... ... # F DEBUG : backtrace: # F DEBUG : #00 pc 00001c04 /system/lib/libc.so (memset+48) # F DEBUG : #01 pc 0010c513 /system/lib/libart.so (create_mspace_with_base+82) # F DEBUG : #02 pc 0015c601 /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateMspace(void*, unsigned int, unsigned int)+40) # F DEBUG : #03 pc 0015c3ed /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateFromMemMap(art::MemMap*, std::__1::basic_string, std::__1::allocator> const&, unsigned int, unsigned int, unsigned int, unsigned int, bool)+36) # ... # # This was bisected back to commit bfd40eaff5ab ("mm: fix # vma_is_anonymous() false-positives"). # # create_mspace_with_base() in the trace above, utilizes ashmem, and with # ashmem, for shared mappings we use shmem_zero_setup(), which sets the # vma->vm_ops to &shmem_vm_ops. But for private ashmem mappings nothing # sets the vma->vm_ops. # # Looking at the problematic patch, it seems to add a requirement that one # call vma_set_anonymous() on a vma, otherwise the dummy_vm_ops will be # used. Using the dummy_vm_ops seem to triggger SIGBUS when traversing # unmapped pages. # # Thus, this patch adds a call to vma_set_anonymous() for ashmem private # mappings and seems to avoid the reported problem. # # Fixes: bfd40eaff5ab ("mm: fix vma_is_anonymous() false-positives") # Cc: Kirill Shutemov # Cc: Andrew Morton # Cc: Dmitry Vyukov # Cc: Oleg Nesterov # Cc: Andrea Arcangeli # Cc: Greg Kroah-Hartman # Cc: Hugh Dickins # Cc: Joel Fernandes # Cc: Colin Cross # Cc: Matthew Wilcox # Reported-by: Amit Pundir # Reported-by: Youling 257 # Signed-off-by: John Stultz # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < git log --format=%s --max-count=1 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # < make -s -j 48 ARCH=arm O=/kisskb/build/linus_lpc32xx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- lpc32xx_defconfig # make -s -j 48 ARCH=arm O=/kisskb/build/linus_lpc32xx_defconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] /kisskb/src/kernel/rcu/srcutree.c: In function 'init_srcu_struct_fields': /kisskb/src/kernel/rcu/srcutree.c:127:33: warning: 'levelspread[]' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/rcu/srcutree.c:94:6: note: 'levelspread[]' was declared here /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1648:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/flow_dissector.c: In function '__skb_flow_dissect': /kisskb/src/net/core/flow_dissector.c:789:7: warning: 'vlan' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3161:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:269:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:234:28: note: 'next' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_add': /kisskb/src/drivers/gpio/gpiolib-of.c:390:8: warning: 'dflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:376:19: note: 'dflags' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c:390:8: warning: 'lflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:375:25: note: 'lflags' was declared here /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:1001:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] Completed OK # rm -rf /kisskb/build/linus_lpc32xx_defconfig_arm # Build took: 0:00:50.883001