# git rev-parse -q --verify 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c^{commit} 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c already have revision, skipping fetch # git checkout -q -f -B kisskb 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # git clean -qxdf # < git log -1 # commit 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # Author: John Stultz # Date: Tue Jul 31 10:17:04 2018 -0700 # # staging: ashmem: Fix SIGBUS crash when traversing mmaped ashmem pages # # Amit Pundir and Youling in parallel reported crashes with recent # mainline kernels running Android: # # F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** # F DEBUG : Build fingerprint: 'Android/db410c32_only/db410c32_only:Q/OC-MR1/102:userdebug/test-key # F DEBUG : Revision: '0' # F DEBUG : ABI: 'arm' # F DEBUG : pid: 2261, tid: 2261, name: zygote >>> zygote <<< # F DEBUG : signal 7 (SIGBUS), code 2 (BUS_ADRERR), fault addr 0xec00008 # ... ... # F DEBUG : backtrace: # F DEBUG : #00 pc 00001c04 /system/lib/libc.so (memset+48) # F DEBUG : #01 pc 0010c513 /system/lib/libart.so (create_mspace_with_base+82) # F DEBUG : #02 pc 0015c601 /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateMspace(void*, unsigned int, unsigned int)+40) # F DEBUG : #03 pc 0015c3ed /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateFromMemMap(art::MemMap*, std::__1::basic_string, std::__1::allocator> const&, unsigned int, unsigned int, unsigned int, unsigned int, bool)+36) # ... # # This was bisected back to commit bfd40eaff5ab ("mm: fix # vma_is_anonymous() false-positives"). # # create_mspace_with_base() in the trace above, utilizes ashmem, and with # ashmem, for shared mappings we use shmem_zero_setup(), which sets the # vma->vm_ops to &shmem_vm_ops. But for private ashmem mappings nothing # sets the vma->vm_ops. # # Looking at the problematic patch, it seems to add a requirement that one # call vma_set_anonymous() on a vma, otherwise the dummy_vm_ops will be # used. Using the dummy_vm_ops seem to triggger SIGBUS when traversing # unmapped pages. # # Thus, this patch adds a call to vma_set_anonymous() for ashmem private # mappings and seems to avoid the reported problem. # # Fixes: bfd40eaff5ab ("mm: fix vma_is_anonymous() false-positives") # Cc: Kirill Shutemov # Cc: Andrew Morton # Cc: Dmitry Vyukov # Cc: Oleg Nesterov # Cc: Andrea Arcangeli # Cc: Greg Kroah-Hartman # Cc: Hugh Dickins # Cc: Joel Fernandes # Cc: Colin Cross # Cc: Matthew Wilcox # Reported-by: Amit Pundir # Reported-by: Youling 257 # Signed-off-by: John Stultz # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version # < git log --format=%s --max-count=1 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # < make -s -j 80 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- axs101_defconfig # Added to kconfig CONFIG_INITRAMFS_SOURCE="" # yes \n | make -s -j 80 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 80 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/include/asm-generic/bug.h:18:0, from /kisskb/src/arch/arc/include/asm/bug.h:32, from /kisskb/src/include/linux/bug.h:5, from /kisskb/src/include/linux/mmdebug.h:5, from /kisskb/src/include/linux/gfp.h:5, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/mm/nobootmem.c:14: /kisskb/src/mm/nobootmem.c: In function '__free_pages_memory': /kisskb/src/include/linux/kernel.h:812:29: warning: comparison of distinct pointer types lacks a cast [enabled by default] (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1))) ^ /kisskb/src/include/linux/kernel.h:826:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^ /kisskb/src/include/linux/kernel.h:836:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^ /kisskb/src/include/linux/kernel.h:845:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^ /kisskb/src/mm/nobootmem.c:104:11: note: in expansion of macro 'min' order = min(MAX_ORDER - 1UL, __ffs(start)); ^ /kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue': /kisskb/src/net/ipv4/tcp_input.c:4313:49: warning: array subscript is above array bounds [-Warray-bounds] tp->selective_acks[i-1] = tp->selective_acks[i]; ^ /kisskb/src/net/xfrm/xfrm_policy.c: In function '__xfrm_policy_check': /kisskb/src/net/xfrm/xfrm_policy.c:2380:15: warning: array subscript is above array bounds [-Warray-bounds] if (sp->xvec[k]->props.mode != XFRM_MODE_TRANSPORT) { ^ Completed OK # rm -rf /kisskb/build/linus_axs101_defconfig_arcompact # Build took: 0:00:50.773508