# git rev-parse -q --verify 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c^{commit} 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c already have revision, skipping fetch # git checkout -q -f -B kisskb 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # git clean -qxdf # < git log -1 # commit 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # Author: John Stultz # Date: Tue Jul 31 10:17:04 2018 -0700 # # staging: ashmem: Fix SIGBUS crash when traversing mmaped ashmem pages # # Amit Pundir and Youling in parallel reported crashes with recent # mainline kernels running Android: # # F DEBUG : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** # F DEBUG : Build fingerprint: 'Android/db410c32_only/db410c32_only:Q/OC-MR1/102:userdebug/test-key # F DEBUG : Revision: '0' # F DEBUG : ABI: 'arm' # F DEBUG : pid: 2261, tid: 2261, name: zygote >>> zygote <<< # F DEBUG : signal 7 (SIGBUS), code 2 (BUS_ADRERR), fault addr 0xec00008 # ... ... # F DEBUG : backtrace: # F DEBUG : #00 pc 00001c04 /system/lib/libc.so (memset+48) # F DEBUG : #01 pc 0010c513 /system/lib/libart.so (create_mspace_with_base+82) # F DEBUG : #02 pc 0015c601 /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateMspace(void*, unsigned int, unsigned int)+40) # F DEBUG : #03 pc 0015c3ed /system/lib/libart.so (art::gc::space::DlMallocSpace::CreateFromMemMap(art::MemMap*, std::__1::basic_string, std::__1::allocator> const&, unsigned int, unsigned int, unsigned int, unsigned int, bool)+36) # ... # # This was bisected back to commit bfd40eaff5ab ("mm: fix # vma_is_anonymous() false-positives"). # # create_mspace_with_base() in the trace above, utilizes ashmem, and with # ashmem, for shared mappings we use shmem_zero_setup(), which sets the # vma->vm_ops to &shmem_vm_ops. But for private ashmem mappings nothing # sets the vma->vm_ops. # # Looking at the problematic patch, it seems to add a requirement that one # call vma_set_anonymous() on a vma, otherwise the dummy_vm_ops will be # used. Using the dummy_vm_ops seem to triggger SIGBUS when traversing # unmapped pages. # # Thus, this patch adds a call to vma_set_anonymous() for ashmem private # mappings and seems to avoid the reported problem. # # Fixes: bfd40eaff5ab ("mm: fix vma_is_anonymous() false-positives") # Cc: Kirill Shutemov # Cc: Andrew Morton # Cc: Dmitry Vyukov # Cc: Oleg Nesterov # Cc: Andrea Arcangeli # Cc: Greg Kroah-Hartman # Cc: Hugh Dickins # Cc: Joel Fernandes # Cc: Colin Cross # Cc: Matthew Wilcox # Reported-by: Amit Pundir # Reported-by: Youling 257 # Signed-off-by: John Stultz # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux-gcc --version # < git log --format=%s --max-count=1 44960f2a7b63e224b1091b3e1d6f60e0cdf4be0c # < make -s -j 48 ARCH=nds32 O=/kisskb/build/linus_nds32-defconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- defconfig # make -s -j 48 ARCH=nds32 O=/kisskb/build/linus_nds32-defconfig_nds32le CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/nds32le-linux/bin/nds32le-linux- :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In function 'fill_item_path', inlined from 'configfs_get_target_path' at /kisskb/src/fs/configfs/symlink.c:250:2, inlined from 'configfs_getlink' at /kisskb/src/fs/configfs/symlink.c:272:10, inlined from 'configfs_get_link' at /kisskb/src/fs/configfs/symlink.c:295:10: /kisskb/src/fs/configfs/symlink.c:67:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(buffer + length,config_item_name(p),cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/configfs/symlink.c: In function 'configfs_get_link': /kisskb/src/fs/configfs/symlink.c:63:13: note: length computed here int cur = strlen(config_item_name(p)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/ablkcipher.c: In function 'crypto_ablkcipher_report': /kisskb/src/crypto/ablkcipher.c:374:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/crypto/ablkcipher.c: In function 'crypto_givcipher_report': /kisskb/src/crypto/ablkcipher.c:448:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_ablkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'kernfs_get_target_path', inlined from 'kernfs_getlink.isra.0' at /kisskb/src/fs/kernfs/symlink.c:109:10, inlined from 'kernfs_iop_get_link' at /kisskb/src/fs/kernfs/symlink.c:127:10: /kisskb/src/fs/kernfs/symlink.c:91:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(s + len, kn->name, slen); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/kernfs/symlink.c: In function 'kernfs_iop_get_link': /kisskb/src/fs/kernfs/symlink.c:88:14: note: length computed here int slen = strlen(kn->name); ^~~~~~~~~~~~~~~~ /kisskb/src/crypto/blkcipher.c: In function 'crypto_blkcipher_report': /kisskb/src/crypto/blkcipher.c:513:2: warning: 'strncpy' specified bound 64 equals destination size [-Wstringop-truncation] strncpy(rblkcipher.geniv, alg->cra_blkcipher.geniv ?: "", ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(rblkcipher.geniv)); ~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c: In function '__save_error_info.isra.4': /kisskb/src/fs/ext4/super.c:326:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_last_error_func, func, sizeof(es->s_last_error_func)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/fs/ext4/super.c:330:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation] strncpy(es->s_first_error_func, func, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ sizeof(es->s_first_error_func)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In function 'fill_kobj_path', inlined from 'kobject_get_path' at /kisskb/src/lib/kobject.c:155:2: /kisskb/src/lib/kobject.c:128:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation] strncpy(path + length, kobject_name(parent), cur); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /kisskb/src/lib/kobject.c: In function 'kobject_get_path': /kisskb/src/lib/kobject.c:125:13: note: length computed here int cur = strlen(kobject_name(parent)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ Completed OK # rm -rf /kisskb/build/linus_nds32-defconfig_nds32le # Build took: 0:00:58.065737