# git rev-parse -q --verify 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085^{commit} 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 already have revision, skipping fetch # git checkout -q -f -B kisskb 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # git clean -qxdf # < git log -1 # commit 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # Author: Linus Torvalds # Date: Wed Aug 1 13:43:38 2018 -0700 # # mm: do not initialize TLB stack vma's with vma_init() # # Commit 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and # data segments") tried to initialize various left-over ad-hoc vma's # "properly", but actually made things worse for the temporary vma's used # for TLB flushing. # # vma_init() doesn't actually initialize all of the vma, just a few # fields, so doing something like # # - struct vm_area_struct vma = { .vm_mm = tlb->mm, }; # + struct vm_area_struct vma; # + # + vma_init(&vma, tlb->mm); # # was actually very bad: instead of having a nicely initialized vma with # every field but "vm_mm" zeroed, you'd have an entirely uninitialized vma # with only a couple of fields initialized. And they weren't even fields # that the code in question mostly cared about. # # The flush_tlb_range() function takes a "struct vma" rather than a # "struct mm_struct", because a few architectures actually care about what # kind of range it is - being able to only do an ITLB flush if it's a # range that doesn't have data accesses enabled, for example. And all the # normal users already have the vma for doing the range invalidation. # # But a few people want to call flush_tlb_range() with a range they just # made up, so they also end up using a made-up vma. x86 just has a # special "flush_tlb_mm_range()" function for this, but other # architectures (arm and ia64) do the "use fake vma" thing instead, and # thus got caught up in the vma_init() changes. # # At the same time, the TLB flushing code really doesn't care about most # other fields in the vma, so vma_init() is just unnecessary and # pointless. # # This fixes things by having an explicit "this is just an initializer for # the TLB flush" initializer macro, which is used by the arm/arm64/ia64 # people who mis-use this interface with just a dummy vma. # # Fixes: 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and data segments") # Cc: Dmitry Vyukov # Cc: Oleg Nesterov # Cc: Andrea Arcangeli # Cc: Kirill Shutemov # Cc: Andrew Morton # Cc: John Stultz # Cc: Hugh Dickins # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi-gcc --version # < git log --format=%s --max-count=1 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # < make -s -j 120 ARCH=arm O=/kisskb/build/linus-rand_arm-randconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- randconfig KCONFIG_SEED=0x7446572 # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # yes \n | make -s -j 120 ARCH=arm O=/kisskb/build/linus-rand_arm-randconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 120 ARCH=arm O=/kisskb/build/linus-rand_arm-randconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] /kisskb/src/arch/arm/kernel/setup.c: In function 'reserve_crashkernel': /kisskb/src/arch/arm/kernel/setup.c:1004:25: error: 'SECTION_SIZE' undeclared (first use in this function) /kisskb/src/arch/arm/kernel/setup.c:1004:25: note: each undeclared identifier is reported only once for each function it appears in /kisskb/src/scripts/Makefile.build:317: recipe for target 'arch/arm/kernel/setup.o' failed make[2]: *** [arch/arm/kernel/setup.o] Error 1 make[2]: *** Waiting for unfinished jobs.... /kisskb/src/arch/arm/mach-s3c24xx/common.c:140:24: warning: 's3c_iodesc' defined but not used [-Wunused-variable] /kisskb/src/arch/arm/mach-s3c24xx/s3c244x.c:44:24: warning: 's3c244x_iodesc' defined but not used [-Wunused-variable] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/Makefile:1029: recipe for target 'arch/arm/kernel' failed make[1]: *** [arch/arm/kernel] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/connector/connector.c:242:12: warning: 'cn_proc_show' defined but not used [-Wunused-function] /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:225:6: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mfd/arizona-core.c: In function 'arizona_dev_init': /kisskb/src/drivers/mfd/arizona-core.c:1404:6: warning: 'n_subdevs' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c: In function 'mlx90632_read_raw': /kisskb/src/drivers/iio/temperature/mlx90632.c:472:39: warning: 'object_old_raw' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c:429:56: note: 'object_old_raw' was declared here /kisskb/src/drivers/iio/temperature/mlx90632.c:472:39: warning: 'object_new_raw' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c:429:40: note: 'object_new_raw' was declared here make[1]: *** wait: No child processes. Stop. Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 120 ARCH=arm O=/kisskb/build/linus-rand_arm-randconfig_arm CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/arm-unknown-linux-gnueabi/bin/arm-unknown-linux-gnueabi- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_arm-randconfig_arm # Build took: 0:00:30.633365