# git rev-parse -q --verify 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085^{commit} 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 already have revision, skipping fetch # git checkout -q -f -B kisskb 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # git clean -qxdf # < git log -1 # commit 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # Author: Linus Torvalds # Date: Wed Aug 1 13:43:38 2018 -0700 # # mm: do not initialize TLB stack vma's with vma_init() # # Commit 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and # data segments") tried to initialize various left-over ad-hoc vma's # "properly", but actually made things worse for the temporary vma's used # for TLB flushing. # # vma_init() doesn't actually initialize all of the vma, just a few # fields, so doing something like # # - struct vm_area_struct vma = { .vm_mm = tlb->mm, }; # + struct vm_area_struct vma; # + # + vma_init(&vma, tlb->mm); # # was actually very bad: instead of having a nicely initialized vma with # every field but "vm_mm" zeroed, you'd have an entirely uninitialized vma # with only a couple of fields initialized. And they weren't even fields # that the code in question mostly cared about. # # The flush_tlb_range() function takes a "struct vma" rather than a # "struct mm_struct", because a few architectures actually care about what # kind of range it is - being able to only do an ITLB flush if it's a # range that doesn't have data accesses enabled, for example. And all the # normal users already have the vma for doing the range invalidation. # # But a few people want to call flush_tlb_range() with a range they just # made up, so they also end up using a made-up vma. x86 just has a # special "flush_tlb_mm_range()" function for this, but other # architectures (arm and ia64) do the "use fake vma" thing instead, and # thus got caught up in the vma_init() changes. # # At the same time, the TLB flushing code really doesn't care about most # other fields in the vma, so vma_init() is just unnecessary and # pointless. # # This fixes things by having an explicit "this is just an initializer for # the TLB flush" initializer macro, which is used by the arm/arm64/ia64 # people who mis-use this interface with just a dummy vma. # # Fixes: 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and data segments") # Cc: Dmitry Vyukov # Cc: Oleg Nesterov # Cc: Andrea Arcangeli # Cc: Kirill Shutemov # Cc: Andrew Morton # Cc: John Stultz # Cc: Hugh Dickins # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux-gcc --version # < git log --format=%s --max-count=1 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # < make -s -j 48 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- allmodconfig # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_HAVE_FTRACE_MCOUNT_RECORD=n # Added to kconfig CONFIG_SAMPLES=n # Added to kconfig CONFIG_MODULE_SIG=n # yes \n | make -s -j 48 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 48 ARCH=sparc64 O=/kisskb/build/linus_sparc64-allmodconfig_sparc64 CROSS_COMPILE=/opt/cross/kisskb/br-sparc64-full-2016.08-613-ge98b4dd/bin/sparc64-linux- :1332:2: warning: #warning syscall io_pgetevents not implemented [-Wcpp] :1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/arch/sparc/include/asm/cmpxchg.h:5:0, from /kisskb/src/arch/sparc/include/asm/atomic_64.h:12, from /kisskb/src/arch/sparc/include/asm/atomic.h:5, from /kisskb/src/include/linux/atomic.h:5, from /kisskb/src/include/asm-generic/qspinlock_types.h:28, from /kisskb/src/arch/sparc/include/asm/spinlock_types.h:6, from /kisskb/src/include/linux/spinlock_types.h:13, from /kisskb/src/include/linux/spinlock.h:82, from /kisskb/src/include/linux/wait.h:9, from /kisskb/src/include/linux/wait_bit.h:8, from /kisskb/src/include/linux/fs.h:6, from /kisskb/src/fs/ocfs2/file.c:27: /kisskb/src/fs/ocfs2/file.c: In function 'ocfs2_file_write_iter': /kisskb/src/arch/sparc/include/asm/cmpxchg_64.h:55:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ^ /kisskb/src/fs/ocfs2/file.c:2386:3: note: in expansion of macro 'xchg' xchg(&iocb->ki_complete, saved_ki_complete); ^ /kisskb/src/drivers/input/joystick/analog.c:176:2: warning: #warning Precise timer not defined for this architecture. [-Wcpp] #warning Precise timer not defined for this architecture. ^ In file included from /kisskb/src/arch/sparc/include/asm/cmpxchg.h:5:0, from /kisskb/src/arch/sparc/include/asm/atomic_64.h:12, from /kisskb/src/arch/sparc/include/asm/atomic.h:5, from /kisskb/src/include/linux/atomic.h:5, from /kisskb/src/include/asm-generic/qspinlock_types.h:28, from /kisskb/src/arch/sparc/include/asm/spinlock_types.h:6, from /kisskb/src/include/linux/spinlock_types.h:13, from /kisskb/src/include/linux/spinlock.h:82, from /kisskb/src/include/linux/seqlock.h:36, from /kisskb/src/include/linux/time.h:6, from /kisskb/src/include/linux/stat.h:19, from /kisskb/src/include/linux/module.h:10, from /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:12: /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c: In function 'ixgbevf_xdp_setup': /kisskb/src/arch/sparc/include/asm/cmpxchg_64.h:55:22: warning: value computed is not used [-Wunused-value] #define xchg(ptr,x) ((__typeof__(*(ptr)))__xchg((unsigned long)(x),(ptr),sizeof(*(ptr)))) ^ /kisskb/src/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c:4448:4: note: in expansion of macro 'xchg' xchg(&adapter->rx_ring[i]->xdp_prog, adapter->xdp_prog); ^ kernel: arch/sparc/boot/image is ready kernel: arch/sparc/boot/zImage is ready Completed OK # rm -rf /kisskb/build/linus_sparc64-allmodconfig_sparc64 # Build took: 0:14:24.025205