Buildresult: linus/axs101_defconfig/arcompact built on Aug 2 2018, 09:30

kisskb

Revisions | Branches | Compilers | Configs | Build Results | Build Failures |

Status:	OK
Date/Time:	Aug 2 2018, 09:30
Duration:	0:01:09.830516
Builder:	ka4
Revision:	mm: do not initialize TLB stack vma's with vma_init() (`8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085)`
Target:	linus/axs101_defconfig/arcompact
Branch:	linus
Compiler:	arcompact (arc-buildroot-linux-uclibc-gcc (Buildroot 2015.08.1) 4.8.4)
Config:	axs101_defconfig (download)
Log:	Download original Possible warnings (4) <stdin>:1335:2: warning: #warning syscall rseq not implemented [-Wcpp] include/linux/kernel.h:812:29: warning: comparison of distinct pointer types lacks a cast [enabled by default] net/ipv4/tcp_input.c:4313:49: warning: array subscript is above array bounds [-Warray-bounds] net/xfrm/xfrm_policy.c:2380:15: warning: array subscript is above array bounds [-Warray-bounds] Full Log # git rev-parse -q --verify 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085^{commit} 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 already have revision, skipping fetch # git checkout -q -f -B kisskb 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # git clean -qxdf # < git log -1 # commit 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # Author: Linus Torvalds <torvalds@linux-foundation.org> # Date: Wed Aug 1 13:43:38 2018 -0700 # # mm: do not initialize TLB stack vma's with vma_init() # # Commit 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and # data segments") tried to initialize various left-over ad-hoc vma's # "properly", but actually made things worse for the temporary vma's used # for TLB flushing. # # vma_init() doesn't actually initialize all of the vma, just a few # fields, so doing something like # # - struct vm_area_struct vma = { .vm_mm = tlb->mm, }; # + struct vm_area_struct vma; # + # + vma_init(&vma, tlb->mm); # # was actually very bad: instead of having a nicely initialized vma with # every field but "vm_mm" zeroed, you'd have an entirely uninitialized vma # with only a couple of fields initialized. And they weren't even fields # that the code in question mostly cared about. # # The flush_tlb_range() function takes a "struct vma" rather than a # "struct mm_struct", because a few architectures actually care about what # kind of range it is - being able to only do an ITLB flush if it's a # range that doesn't have data accesses enabled, for example. And all the # normal users already have the vma for doing the range invalidation. # # But a few people want to call flush_tlb_range() with a range they just # made up, so they also end up using a made-up vma. x86 just has a # special "flush_tlb_mm_range()" function for this, but other # architectures (arm and ia64) do the "use fake vma" thing instead, and # thus got caught up in the vma_init() changes. # # At the same time, the TLB flushing code really doesn't care about most # other fields in the vma, so vma_init() is just unnecessary and # pointless. # # This fixes things by having an explicit "this is just an initializer for # the TLB flush" initializer macro, which is used by the arm/arm64/ia64 # people who mis-use this interface with just a dummy vma. # # Fixes: 2c4541e24c55 ("mm: use vma_init() to initialize VMAs on stack and data segments") # Cc: Dmitry Vyukov <dvyukov@google.com> # Cc: Oleg Nesterov <oleg@redhat.com> # Cc: Andrea Arcangeli <aarcange@redhat.com> # Cc: Kirill Shutemov <kirill.shutemov@linux.intel.com> # Cc: Andrew Morton <akpm@linux-foundation.org> # Cc: John Stultz <john.stultz@linaro.org> # Cc: Hugh Dickins <hughd@google.com> # Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> # < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version # < git log --format=%s --max-count=1 8b11ec1b5ffb54f71cb5a5e5c8c4d36e5d113085 # < make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- axs101_defconfig # Added to kconfig CONFIG_INITRAMFS_SOURCE="" # yes \n \| make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- oldconfig yes: standard output: Broken pipe yes: write error # make -s -j 10 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc- <stdin>:1335:2: warning: #warning syscall rseq not implemented [-Wcpp] In file included from /kisskb/src/include/asm-generic/bug.h:18:0, from /kisskb/src/arch/arc/include/asm/bug.h:32, from /kisskb/src/include/linux/bug.h:5, from /kisskb/src/include/linux/mmdebug.h:5, from /kisskb/src/include/linux/gfp.h:5, from /kisskb/src/include/linux/slab.h:15, from /kisskb/src/mm/nobootmem.c:14: /kisskb/src/mm/nobootmem.c: In function '__free_pages_memory': /kisskb/src/include/linux/kernel.h:812:29: warning: comparison of distinct pointer types lacks a cast [enabled by default] (!!(sizeof((typeof(x) )1 == (typeof(y) )1))) ^ /kisskb/src/include/linux/kernel.h:826:4: note: in expansion of macro '__typecheck' (__typecheck(x, y) && __no_side_effects(x, y)) ^ /kisskb/src/include/linux/kernel.h:836:24: note: in expansion of macro '__safe_cmp' __builtin_choose_expr(__safe_cmp(x, y), \ ^ /kisskb/src/include/linux/kernel.h:845:19: note: in expansion of macro '__careful_cmp' #define min(x, y) __careful_cmp(x, y, <) ^ /kisskb/src/mm/nobootmem.c:104:11: note: in expansion of macro 'min' order = min(MAX_ORDER - 1UL, __ffs(start)); ^ /kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue': /kisskb/src/net/ipv4/tcp_input.c:4313:49: warning: array subscript is above array bounds [-Warray-bounds] tp->selective_acks[i-1] = tp->selective_acks[i]; ^ /kisskb/src/net/xfrm/xfrm_policy.c: In function '__xfrm_policy_check': /kisskb/src/net/xfrm/xfrm_policy.c:2380:15: warning: array subscript is above array bounds [-Warray-bounds] if (sp->xvec[k]->props.mode != XFRM_MODE_TRANSPORT) { ^ Completed OK # rm -rf /kisskb/build/linus_axs101_defconfig_arcompact # Build took: 0:01:09.830516

© Michael Ellerman 2006-2018.