# git rev-parse -q --verify a6fcdbf95d7907bc5d5a669adb86e6bda72d738b^{commit} a6fcdbf95d7907bc5d5a669adb86e6bda72d738b already have revision, skipping fetch # git checkout -q -f -B kisskb a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # git clean -qxdf # < git log -1 # commit a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # Author: Reza Arbab # Date: Thu Aug 2 23:03:36 2018 -0500 # # powerpc/powernv: Fix concurrency issue with npu->mmio_atsd_usage # # We've encountered a performance issue when multiple processors stress # {get,put}_mmio_atsd_reg(). These functions contend for # mmio_atsd_usage, an unsigned long used as a bitmask. # # The accesses to mmio_atsd_usage are done using test_and_set_bit_lock() # and clear_bit_unlock(). As implemented, both of these will require # a (successful) stwcx to that same cache line. # # What we end up with is thread A, attempting to unlock, being slowed by # other threads repeatedly attempting to lock. A's stwcx instructions # fail and retry because the memory reservation is lost every time a # different thread beats it to the punch. # # There may be a long-term way to fix this at a larger scale, but for # now resolve the immediate problem by gating our call to # test_and_set_bit_lock() with one to test_bit(), which is obviously # implemented without using a store. # # Fixes: 1ab66d1fbada ("powerpc/powernv: Introduce address translation services for Nvlink2") # Signed-off-by: Reza Arbab # Acked-by: Alistair Popple # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # < make -s -j 20 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_smp_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mpc85xx_smp_defconfig # make -s -j 20 ARCH=powerpc O=/kisskb/build/powerpc-next_mpc85xx_smp_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/cgroup/cgroup-v1.c: In function 'cgroup1_mount': /kisskb/src/kernel/cgroup/cgroup-v1.c:1256:20: warning: 'root' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2497:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1819:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': /kisskb/src/sound/soc/codecs/wm8960.c:803:70: warning: 'j' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c:800:68: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/hugetlb.c: In function 'alloc_pool_huge_page': /kisskb/src/mm/hugetlb.c:1433:5: warning: 'page' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c: In function 'allocate_bd': /kisskb/src/drivers/net/ethernet/freescale/fs_enet/mac-scc.c:139:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] /kisskb/src/fs/udf/unicode.c: In function 'udf_name_conv_char': /kisskb/src/fs/udf/unicode.c:132:8: warning: 'c' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here arch/powerpc/boot/mpc8541cds.dtb: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) arch/powerpc/boot/mpc8555cds.dtb: Warning (pci_device_bus_num): /pci@e0008000/i8259@19000:bus-range: PCI bus number 1 out of range, expected (0 - 0) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbfd44c) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) INFO: Uncompressed kernel (size 0xbeccc8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0xc00000) Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818393 Bytes = 5682.02 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5817034 Bytes = 5680.70 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818148 Bytes = 5681.79 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5792934 Bytes = 5657.16 kB = 5.52 MB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5817048 Bytes = 5680.71 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00288 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5817160 Bytes = 5680.82 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818073 Bytes = 5681.71 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5817208 Bytes = 5680.87 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818413 Bytes = 5682.04 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00288 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818012 Bytes = 5681.65 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818418 Bytes = 5682.05 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5817210 Bytes = 5680.87 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5816992 Bytes = 5680.66 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00288 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818075 Bytes = 5681.71 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00248 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5816993 Bytes = 5680.66 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00288 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 22:30:03 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 5818380 Bytes = 5682.01 kB = 5.55 MB Load Address: 00c00000 Entry Point: 00c00288 Completed OK # rm -rf /kisskb/build/powerpc-next_mpc85xx_smp_defconfig_powerpc # Build took: 0:02:06.077650