# git rev-parse -q --verify a6fcdbf95d7907bc5d5a669adb86e6bda72d738b^{commit} a6fcdbf95d7907bc5d5a669adb86e6bda72d738b already have revision, skipping fetch # git checkout -q -f -B kisskb a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # git clean -qxdf # < git log -1 # commit a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # Author: Reza Arbab # Date: Thu Aug 2 23:03:36 2018 -0500 # # powerpc/powernv: Fix concurrency issue with npu->mmio_atsd_usage # # We've encountered a performance issue when multiple processors stress # {get,put}_mmio_atsd_reg(). These functions contend for # mmio_atsd_usage, an unsigned long used as a bitmask. # # The accesses to mmio_atsd_usage are done using test_and_set_bit_lock() # and clear_bit_unlock(). As implemented, both of these will require # a (successful) stwcx to that same cache line. # # What we end up with is thread A, attempting to unlock, being slowed by # other threads repeatedly attempting to lock. A's stwcx instructions # fail and retry because the memory reservation is lost every time a # different thread beats it to the punch. # # There may be a long-term way to fix this at a larger scale, but for # now resolve the immediate problem by gating our call to # test_and_set_bit_lock() with one to test_bit(), which is obviously # implemented without using a store. # # Fixes: 1ab66d1fbada ("powerpc/powernv: Introduce address translation services for Nvlink2") # Signed-off-by: Reza Arbab # Acked-by: Alistair Popple # Signed-off-by: Michael Ellerman # < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 a6fcdbf95d7907bc5d5a669adb86e6bda72d738b # < make -s -j 8 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- ppc40x_defconfig # make -s -j 8 ARCH=powerpc O=/kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. /kisskb/src/net/Makefile:24: CC cannot link executables. Skipping bpfilter. INFO: Uncompressed kernel (size 0x511954) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x511954) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x501274) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x511954) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) INFO: Uncompressed kernel (size 0x511954) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 16:48:14 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2562003 Bytes = 2501.96 kB = 2.44 MB Load Address: 00000000 Entry Point: 00000000 Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 16:48:15 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2587857 Bytes = 2527.20 kB = 2.47 MB Load Address: 00600000 Entry Point: 0060135c Image Name: Linux-4.18.0-rc3-ga6fcdbf Created: Fri Aug 3 16:48:15 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 2589970 Bytes = 2529.27 kB = 2.47 MB Load Address: 00600000 Entry Point: 0060153c Completed OK # rm -rf /kisskb/build/powerpc-next_ppc40x_defconfig_powerpc-5.3 # Build took: 0:01:26.544169