# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit} 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b already have revision, skipping fetch # git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # git clean -qxdf # < git log -1 # commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # Author: Linus Torvalds # Date: Wed Aug 15 19:08:10 2018 -0700 # # ALSA: update dell-wmi mic-mute registration to new world order # # Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED # controls") changed the return value of the snd_hda_gen_add_micmute_led() # without actually updating the callers. # # Admittedly, almost no callers actually cared about the return value. # But one call site very much did: the Dell wmi code. It would see the # registration return zero, which _used_ to mean "failed" but now means # "success", and clear the dell_micmute_led_set_func pointer. # # End result: the successful registration would end up calling the Dell # code that thought it had all failed, and call through a NULL pointer. # # To make matters worse, it ends up being a tail-call, and with the # retpoline sequence you don't even see the caller (dell_micmute_update()) # in the stack trace, so the error ended up way less obvious than it # should have been. # # Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls" # Cc: Takashi Iwai # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # < make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- mpc83xx_defconfig # make -s -j 8 ARCH=powerpc O=/kisskb/build/linus_mpc83xx_defconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function 'regmap_raw_read': /kisskb/src/drivers/base/regmap/regmap.c:2511:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/base/regmap/regmap.c: In function '_regmap_raw_write': /kisskb/src/drivers/base/regmap/regmap.c:1833:6: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'univ8250_release_irq': /kisskb/src/drivers/tty/serial/8250/8250_core.c:251:18: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c:231:19: note: 'i' was declared here arch/powerpc/boot/mpc832x_rdb.dtb: Warning (interrupts_property): /qe@e0100000/mdio@3120/ethernet-phy@0:#interrupt-cells: size is (4), expected multiple of 8 arch/powerpc/boot/mpc832x_rdb.dtb: Warning (interrupts_property): /qe@e0100000/mdio@3120/ethernet-phy@4:#interrupt-cells: size is (4), expected multiple of 8 INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) INFO: Uncompressed kernel (size 0x5ff0e8) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x600000) Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:05 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3033083 Bytes = 2962.00 kB = 2.89 MB Load Address: 00000000 Entry Point: 00000000 INFO: Uncompressed kernel (size 0x60f794) overlaps the address of the wrapper(0x400000) INFO: Fixing the link_address of wrapper to (0x700000) Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3056476 Bytes = 2984.84 kB = 2.91 MB Load Address: 00700000 Entry Point: 00700230 Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3056513 Bytes = 2984.88 kB = 2.91 MB Load Address: 00700000 Entry Point: 00700230 Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3056796 Bytes = 2985.15 kB = 2.92 MB Load Address: 00700000 Entry Point: 00700230 Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3056370 Bytes = 2984.74 kB = 2.91 MB Load Address: 00700000 Entry Point: 00700230 Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3055946 Bytes = 2984.32 kB = 2.91 MB Load Address: 00700000 Entry Point: 00700230 Image Name: Linux-4.18.0-g70b20dd Created: Thu Aug 16 16:55:06 2018 Image Type: PowerPC Linux Kernel Image (gzip compressed) Data Size: 3056491 Bytes = 2984.85 kB = 2.91 MB Load Address: 00700000 Entry Point: 00700230 Completed OK # rm -rf /kisskb/build/linus_mpc83xx_defconfig_powerpc # Build took: 0:00:56.098669