# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit}
70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
already have revision, skipping fetch
# git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# git clean -qxdf
# < git log -1
# commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Aug 15 19:08:10 2018 -0700
# 
#     ALSA: update dell-wmi mic-mute registration to new world order
#     
#     Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED
#     controls") changed the return value of the snd_hda_gen_add_micmute_led()
#     without actually updating the callers.
#     
#     Admittedly, almost no callers actually cared about the return value.
#     But one call site very much did: the Dell wmi code.  It would see the
#     registration return zero, which _used_ to mean "failed" but now means
#     "success", and clear the dell_micmute_led_set_func pointer.
#     
#     End result: the successful registration would end up calling the Dell
#     code that thought it had all failed, and call through a NULL pointer.
#     
#     To make matters worse, it ends up being a tail-call, and with the
#     retpoline sequence you don't even see the caller (dell_micmute_update())
#     in the stack trace, so the error ended up way less obvious than it
#     should have been.
#     
#     Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
#     Cc: Takashi Iwai <tiwai@suse.de>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-gcc --version
# < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# < make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-  axs101_defconfig
# Added to kconfig CONFIG_INITRAMFS_SOURCE=""
# make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-  olddefconfig
# make -s -j 48 ARCH=arc O=/kisskb/build/linus_axs101_defconfig_arcompact CROSS_COMPILE=/opt/cross/kisskb/arcompact-buildroot-2015.08.1/bin/arc-buildroot-linux-uclibc-  
In file included from /kisskb/src/include/asm-generic/bug.h:18:0,
                 from /kisskb/src/arch/arc/include/asm/bug.h:32,
                 from /kisskb/src/include/linux/bug.h:5,
                 from /kisskb/src/include/linux/mmdebug.h:5,
                 from /kisskb/src/include/linux/gfp.h:5,
                 from /kisskb/src/include/linux/slab.h:15,
                 from /kisskb/src/mm/nobootmem.c:14:
/kisskb/src/mm/nobootmem.c: In function '__free_pages_memory':
/kisskb/src/include/linux/kernel.h:812:29: warning: comparison of distinct pointer types lacks a cast [enabled by default]
   (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
                             ^
/kisskb/src/include/linux/kernel.h:826:4: note: in expansion of macro '__typecheck'
   (__typecheck(x, y) && __no_side_effects(x, y))
    ^
/kisskb/src/include/linux/kernel.h:836:24: note: in expansion of macro '__safe_cmp'
  __builtin_choose_expr(__safe_cmp(x, y), \
                        ^
/kisskb/src/include/linux/kernel.h:845:19: note: in expansion of macro '__careful_cmp'
 #define min(x, y) __careful_cmp(x, y, <)
                   ^
/kisskb/src/mm/nobootmem.c:104:11: note: in expansion of macro 'min'
   order = min(MAX_ORDER - 1UL, __ffs(start));
           ^
/kisskb/src/net/ipv4/tcp_input.c: In function 'tcp_data_queue':
/kisskb/src/net/ipv4/tcp_input.c:4319:49: warning: array subscript is above array bounds [-Warray-bounds]
     tp->selective_acks[i-1] = tp->selective_acks[i];
                                                 ^
Completed OK
# rm -rf /kisskb/build/linus_axs101_defconfig_arcompact
# Build took: 0:00:48.135044