# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit}
70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
already have revision, skipping fetch
# git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# git clean -qxdf
# < git log -1
# commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Aug 15 19:08:10 2018 -0700
# 
#     ALSA: update dell-wmi mic-mute registration to new world order
#     
#     Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED
#     controls") changed the return value of the snd_hda_gen_add_micmute_led()
#     without actually updating the callers.
#     
#     Admittedly, almost no callers actually cared about the return value.
#     But one call site very much did: the Dell wmi code.  It would see the
#     registration return zero, which _used_ to mean "failed" but now means
#     "success", and clear the dell_micmute_led_set_func pointer.
#     
#     End result: the successful registration would end up calling the Dell
#     code that thought it had all failed, and call through a NULL pointer.
#     
#     To make matters worse, it ends up being a tail-call, and with the
#     retpoline sequence you don't even see the caller (dell_micmute_update())
#     in the stack trace, so the error ended up way less obvious than it
#     should have been.
#     
#     Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
#     Cc: Takashi Iwai <tiwai@suse.de>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux-gcc --version
# < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# < make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 allmodconfig
# Added to kconfig CONFIG_STANDALONE=y
# Added to kconfig CONFIG_KCOV=n
# Added to kconfig CONFIG_GCC_PLUGINS=n
# Added to kconfig CONFIG_GCC_PLUGIN_CYC_COMPLEXITY=n
# Added to kconfig CONFIG_GCC_PLUGIN_SANCOV=n
# Added to kconfig CONFIG_GCC_PLUGIN_LATENT_ENTROPY=n
# Added to kconfig CONFIG_GCC_PLUGIN_STRUCTLEAK=n
# Added to kconfig CONFIG_GCC_PLUGIN_RANDSTRUCT=n
# Added to kconfig CONFIG_UML_NET=n
# Added to kconfig CONFIG_UML_NET_ETHERTAP=n
# Added to kconfig CONFIG_UML_NET_TUNTAP=n
# Added to kconfig CONFIG_UML_NET_SLIP=n
# Added to kconfig CONFIG_UML_NET_DAEMON=n
# Added to kconfig CONFIG_UML_NET_VDE=n
# Added to kconfig CONFIG_UML_NET_MCAST=n
# Added to kconfig CONFIG_UML_NET_PCAP=n
# Added to kconfig CONFIG_UML_NET_SLIRP=n
# Added to kconfig CONFIG_GCOV_KERNEL=n
# make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 olddefconfig
# make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 
/kisskb/src/Makefile:1166: *** Headers not exportable for the um architecture.  Stop.
make[1]: *** Waiting for unfinished jobs....
Makefile:146: recipe for target 'sub-make' failed
make: *** [sub-make] Error 2
Command 'make -s -j 10 ARCH=um O=/kisskb/build/linus_um-allmodconfig_um-x86_64 CROSS_COMPILE=/opt/cross/kisskb/fe-x86-64-core-i7-2017.05/bin/x86_64-linux- SUBARCH=x86_64 ' returned non-zero exit status 2
# rm -rf /kisskb/build/linus_um-allmodconfig_um-x86_64
# Build took: 0:00:12.615896