# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit}
70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
already have revision, skipping fetch
# git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# git clean -qxdf
# < git log -1
# commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Aug 15 19:08:10 2018 -0700
# 
#     ALSA: update dell-wmi mic-mute registration to new world order
#     
#     Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED
#     controls") changed the return value of the snd_hda_gen_add_micmute_led()
#     without actually updating the callers.
#     
#     Admittedly, almost no callers actually cared about the return value.
#     But one call site very much did: the Dell wmi code.  It would see the
#     registration return zero, which _used_ to mean "failed" but now means
#     "success", and clear the dell_micmute_led_set_func pointer.
#     
#     End result: the successful registration would end up calling the Dell
#     code that thought it had all failed, and call through a NULL pointer.
#     
#     To make matters worse, it ends up being a tail-call, and with the
#     retpoline sequence you don't even see the caller (dell_micmute_update())
#     in the stack trace, so the error ended up way less obvious than it
#     should have been.
#     
#     Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
#     Cc: Takashi Iwai <tiwai@suse.de>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-gcc --version
# < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# < make -s -j 40 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  defconfig
# make -s -j 40 ARCH=mips O=/kisskb/build/linus_mips-defconfig_mipsel CROSS_COMPILE=/opt/cross/kisskb/br-mipsel-o32-full-2016.08-613-ge98b4dd/bin/mipsel-linux-  
FIT description: Linux 4.18.0-g70b20dd
Created:         Thu Aug 16 19:10:35 2018
 Image 0 (kernel@0)
  Description:  Linux 4.18.0-g70b20dd
  Created:      Thu Aug 16 19:10:35 2018
  Type:         Kernel Image
  Compression:  gzip compressed
  Data Size:    4423914 Bytes = 4320.23 kB = 4.22 MB
  Architecture: MIPS
  OS:           Linux
  Load Address: 0x80100000
  Entry Point:  0x80838db0
  Hash algo:    sha1
  Hash value:   fa51aba5b378d08a0b7fe20771e776ab33c3cd4b
 Image 1 (fdt@boston)
  Description:  img,boston Device Tree
  Created:      Thu Aug 16 19:10:35 2018
  Type:         Flat Device Tree
  Compression:  uncompressed
  Data Size:    3668 Bytes = 3.58 kB = 0.00 MB
  Architecture: MIPS
  Hash algo:    sha1
  Hash value:   569c37cc891ce1e1f3a193cb41cc691a5d2debb5
 Image 2 (fdt@ni169445)
  Description:  NI 169445 device tree
  Created:      Thu Aug 16 19:10:35 2018
  Type:         Flat Device Tree
  Compression:  uncompressed
  Data Size:    1871 Bytes = 1.83 kB = 0.00 MB
  Architecture: MIPS
  Hash algo:    sha1
  Hash value:   51b89b31605ee62038c8468c429af091dfc75ec7
 Image 3 (fdt@xilfpga)
  Description:  MIPSfpga (xilfpga) Device Tree
  Created:      Thu Aug 16 19:10:35 2018
  Type:         Flat Device Tree
  Compression:  uncompressed
  Data Size:    2708 Bytes = 2.64 kB = 0.00 MB
  Architecture: MIPS
  Hash algo:    sha1
  Hash value:   509ce58e44c561d54539e64e9d4b47054e696fc6
 Default Configuration: 'conf@default'
 Configuration 0 (conf@default)
  Description:  Generic Linux kernel
  Kernel:       kernel@0
 Configuration 1 (conf@boston)
  Description:  Boston Linux kernel
  Kernel:       kernel@0
  FDT:          fdt@boston
 Configuration 2 (conf@ni169445)
  Description:  NI 169445 Linux Kernel
  Kernel:       kernel@0
  FDT:          fdt@ni169445
 Configuration 3 (conf@xilfpga)
  Description:  MIPSfpga Linux kernel
  Kernel:       kernel@0
  FDT:          fdt@xilfpga
Completed OK
# rm -rf /kisskb/build/linus_mips-defconfig_mipsel
# Build took: 0:00:58.303880