# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit}
70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
already have revision, skipping fetch
# git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# git clean -qxdf
# < git log -1
# commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# Author: Linus Torvalds <torvalds@linux-foundation.org>
# Date:   Wed Aug 15 19:08:10 2018 -0700
# 
#     ALSA: update dell-wmi mic-mute registration to new world order
#     
#     Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED
#     controls") changed the return value of the snd_hda_gen_add_micmute_led()
#     without actually updating the callers.
#     
#     Admittedly, almost no callers actually cared about the return value.
#     But one call site very much did: the Dell wmi code.  It would see the
#     registration return zero, which _used_ to mean "failed" but now means
#     "success", and clear the dell_micmute_led_set_func pointer.
#     
#     End result: the successful registration would end up calling the Dell
#     code that thought it had all failed, and call through a NULL pointer.
#     
#     To make matters worse, it ends up being a tail-call, and with the
#     retpoline sequence you don't even see the caller (dell_micmute_update())
#     in the stack trace, so the error ended up way less obvious than it
#     should have been.
#     
#     Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls"
#     Cc: Takashi Iwai <tiwai@suse.de>
#     Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
# < /opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-gcc --version
# < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b
# < make -s -j 40 ARCH=parisc O=/kisskb/build/linus_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-  defconfig
# make -s -j 40 ARCH=parisc O=/kisskb/build/linus_parisc-defconfig_parisc CROSS_COMPILE=/opt/cross/kisskb/korg/gcc-8.1.0-nolibc/hppa-linux/bin/hppa-linux-  
<stdin>:1335:2: warning: #warning syscall rseq not implemented [-Wcpp]
In function 'kernfs_get_target_path',
    inlined from 'kernfs_getlink.isra.0' at /kisskb/src/fs/kernfs/symlink.c:118:10,
    inlined from 'kernfs_iop_get_link.part.1' at /kisskb/src/fs/kernfs/symlink.c:136:10,
    inlined from 'kernfs_iop_get_link':
/kisskb/src/fs/kernfs/symlink.c:100:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
   strncpy(s + len, kn->name, slen);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/fs/kernfs/symlink.c: In function 'kernfs_iop_get_link':
/kisskb/src/fs/kernfs/symlink.c:97:14: note: length computed here
   int slen = strlen(kn->name);
              ^~~~~~~~~~~~~~~~
In function 'fill_kobj_path',
    inlined from 'kobject_get_path' at /kisskb/src/lib/kobject.c:174:2:
/kisskb/src/lib/kobject.c:147:3: warning: 'strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Wstringop-truncation]
   strncpy(path + length, kobject_name(parent), cur);
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/lib/kobject.c: In function 'kobject_get_path':
/kisskb/src/lib/kobject.c:144:13: note: length computed here
   int cur = strlen(kobject_name(parent));
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/fs/ext4/super.c: In function '__save_error_info.isra.6':
/kisskb/src/fs/ext4/super.c:344:2: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
  strncpy(es->s_last_error_func, func, sizeof(es->s_last_error_func));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/kisskb/src/fs/ext4/super.c:349:3: warning: 'strncpy' specified bound 32 equals destination size [-Wstringop-truncation]
   strncpy(es->s_first_error_func, func,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    sizeof(es->s_first_error_func));
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Completed OK
# rm -rf /kisskb/build/linus_parisc-defconfig_parisc
# Build took: 0:00:36.973205