# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit} 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b already have revision, skipping fetch # git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # git clean -qxdf # < git log -1 # commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # Author: Linus Torvalds # Date: Wed Aug 15 19:08:10 2018 -0700 # # ALSA: update dell-wmi mic-mute registration to new world order # # Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED # controls") changed the return value of the snd_hda_gen_add_micmute_led() # without actually updating the callers. # # Admittedly, almost no callers actually cared about the return value. # But one call site very much did: the Dell wmi code. It would see the # registration return zero, which _used_ to mean "failed" but now means # "success", and clear the dell_micmute_led_set_func pointer. # # End result: the successful registration would end up calling the Dell # code that thought it had all failed, and call through a NULL pointer. # # To make matters worse, it ends up being a tail-call, and with the # retpoline sequence you don't even see the caller (dell_micmute_update()) # in the stack trace, so the error ended up way less obvious than it # should have been. # # Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls" # Cc: Takashi Iwai # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux-gcc --version # < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # < make -s -j 48 ARCH=i386 O=/kisskb/build/linus-rand_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- randconfig KCONFIG_SEED=0x1CA84F56 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # make -s -j 48 ARCH=i386 O=/kisskb/build/linus-rand_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- olddefconfig # make -s -j 48 ARCH=i386 O=/kisskb/build/linus-rand_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- /kisskb/src/arch/x86/kernel/apic/io_apic.c: In function 'mp_map_pin_to_irq': /kisskb/src/arch/x86/kernel/apic/io_apic.c:1034:6: warning: 'irq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1658:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/hw_breakpoint.c: In function 'hw_breakpoint_arch_parse': /kisskb/src/arch/x86/kernel/hw_breakpoint.c:366:18: warning: 'align' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/arch/x86/kernel/e820.c: In function 'e820__setup_pci_gap': /kisskb/src/arch/x86/kernel/e820.c:653:2: warning: 'gapstart' may be used uninitialized in this function [-Wuninitialized] In file included from /kisskb/src/mm/memory.c:62:0: /kisskb/src/include/linux/swapops.h: In function 'swp_entry_to_pte': /kisskb/src/include/linux/swapops.h:85:2: internal compiler error: Segmentation fault Please submit a full bug report, with preprocessed source if appropriate. See for instructions. /kisskb/src/scripts/Makefile.build:310: recipe for target 'mm/memory.o' failed make[2]: *** [mm/memory.o] Error 1 make[2]: *** Waiting for unfinished jobs.... In file included from /kisskb/src/mm/mprotect.c:23:0: /kisskb/src/include/linux/swapops.h: In function 'swp_entry_to_pte': /kisskb/src/include/linux/swapops.h:85:2: internal compiler error: Segmentation fault Please submit a full bug report, with preprocessed source if appropriate. See for instructions. /kisskb/src/scripts/Makefile.build:310: recipe for target 'mm/mprotect.o' failed make[2]: *** [mm/mprotect.o] Error 1 /kisskb/src/Makefile:1041: recipe for target 'mm' failed make[1]: *** [mm] Error 2 make[1]: *** Waiting for unfinished jobs.... /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/raid6/recov_avx512.c:387:2: warning: #warning "your version of binutils lacks AVX512 support" [-Wcpp] /kisskb/src/sound/core/pcm_iec958.c: In function 'create_iec958_consumer': /kisskb/src/sound/core/pcm_iec958.c:80:9: warning: 'ws' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/block/bfq-iosched.c: In function 'bfq_exit_icq_bfqq': /kisskb/src/block/bfq-iosched.c:4084:11: warning: 'bfqd' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rht_deferred_worker': /kisskb/src/lib/rhashtable.c:267:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c:232:28: note: 'next' was declared here /kisskb/src/fs/f2fs/node.c: In function '__set_nat_cache_dirty': /kisskb/src/include/linux/list.h:93:12: warning: 'head' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/f2fs/node.c:225:24: note: 'head' was declared here /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_fence': /kisskb/src/drivers/dma-buf/reservation.c:211:7: warning: 'k' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c:161:17: note: 'k' was declared here /kisskb/src/sound/soc/codecs/da7219-aad.c: In function 'da7219_aad_hptest_work': /kisskb/src/sound/soc/codecs/da7219-aad.c:321:17: warning: 'pll_ctrl' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c: In function 'proc_reg_open': /kisskb/src/include/linux/list.h:65:12: warning: 'pdeo' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/proc/inode.c:339:21: note: 'pdeo' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c: In function 'of_gpiochip_add': /kisskb/src/drivers/gpio/gpiolib-of.c:390:8: warning: 'dflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:376:19: note: 'dflags' was declared here /kisskb/src/drivers/gpio/gpiolib-of.c:390:8: warning: 'lflags' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpio/gpiolib-of.c:375:25: note: 'lflags' was declared here /kisskb/src/drivers/input/mouse/cyapa.c: In function 'cyapa_irq': /kisskb/src/drivers/input/mouse/cyapa.c:717:27: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/mouse/cyapa_gen3.c: In function 'cyapa_gen3_set_power_mode': /kisskb/src/drivers/input/mouse/cyapa_gen3.c:927:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': /kisskb/src/sound/soc/codecs/wm8960.c:803:70: warning: 'j' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/soc/codecs/wm8960.c:800:68: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/mfd/arizona-core.c: In function 'arizona_dev_init': /kisskb/src/drivers/mfd/arizona-core.c:1404:6: warning: 'n_subdevs' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/pwm/pwm-atmel-hlcdc.c: In function 'atmel_hlcdc_pwm_apply': /kisskb/src/drivers/pwm/pwm-atmel-hlcdc.c:78:56: warning: 'clk_period_ns' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c: In function 'soc15_set_ip_blocks': /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:532:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:551:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] /kisskb/src/drivers/slimbus/messaging.c: In function 'slim_do_transfer': /kisskb/src/drivers/slimbus/messaging.c:126:14: warning: 'tid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function 'gmc_v8_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1459:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1459:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function 'gmc_v9_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:262:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:262:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/i915/i915_irq.c: In function 'gen11_irq_handler': /kisskb/src/drivers/gpu/drm/i915/i915_irq.c:3120:10: warning: 'gu_misc_iir' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/i915/i915_irq.c:3131:6: note: 'gu_misc_iir' was declared here /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c: In function 'drm_sched_job_recovery': /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c:689:20: warning: 'guilty_context' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c: In function 'mlx90632_read_raw': /kisskb/src/drivers/iio/temperature/mlx90632.c:472:39: warning: 'object_old_raw' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c:429:56: note: 'object_old_raw' was declared here /kisskb/src/drivers/iio/temperature/mlx90632.c:472:39: warning: 'object_new_raw' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/iio/temperature/mlx90632.c:429:40: note: 'object_new_raw' was declared here /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c: In function 'drm_dp_sideband_msg_build': /kisskb/src/drivers/gpu/drm/drm_dp_mst_topology.c:364:23: warning: 'hdrlen' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/radeon/radeon_uvd.c: In function 'radeon_uvd_init': /kisskb/src/drivers/gpu/drm/radeon/radeon_uvd.c:175:15: warning: 'r' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_check_only': /kisskb/src/drivers/gpu/drm/drm_atomic.c:760:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c:744:25: note: 'crtc_state' was declared here Makefile:146: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 Command 'make -s -j 48 ARCH=i386 O=/kisskb/build/linus-rand_i386-randconfig_i386 CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/i386-linux/bin/i386-linux- ' returned non-zero exit status 2 # rm -rf /kisskb/build/linus-rand_i386-randconfig_i386 # Build took: 0:01:36.923924