# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit} 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b already have revision, skipping fetch # git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # git clean -qxdf # < git log -1 # commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # Author: Linus Torvalds # Date: Wed Aug 15 19:08:10 2018 -0700 # # ALSA: update dell-wmi mic-mute registration to new world order # # Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED # controls") changed the return value of the snd_hda_gen_add_micmute_led() # without actually updating the callers. # # Admittedly, almost no callers actually cared about the return value. # But one call site very much did: the Dell wmi code. It would see the # registration return zero, which _used_ to mean "failed" but now means # "success", and clear the dell_micmute_led_set_func pointer. # # End result: the successful registration would end up calling the Dell # code that thought it had all failed, and call through a NULL pointer. # # To make matters worse, it ends up being a tail-call, and with the # retpoline sequence you don't even see the caller (dell_micmute_update()) # in the stack trace, so the error ended up way less obvious than it # should have been. # # Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls" # Cc: Takashi Iwai # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux-gcc --version # < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # < make -s -j 48 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- randconfig KCONFIG_SEED=0x3BCC2D45 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # make -s -j 48 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- olddefconfig # make -s -j 48 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc CROSS_COMPILE=/opt/cross/kisskb/gcc-4.6.3-nolibc/powerpc-linux/bin/powerpc-linux- /kisskb/src/kernel/printk/printk.c: In function 'devkmsg_sysctl_set_loglvl': /kisskb/src/kernel/printk/printk.c:183:16: warning: 'old' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/fs/afs/dynroot.c: In function 'afs_lookup_atcell': /kisskb/src/fs/afs/dynroot.c:126:6: warning: 'len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/ipc/shm.c: In function 'ksys_shmdt': /kisskb/src/ipc/shm.c:1658:59: warning: 'file' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/mpi/mpicoder.c: In function 'mpi_read_raw_from_sgl': /kisskb/src/lib/mpi/mpicoder.c:352:8: warning: 'buff' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/core/pcm_iec958.c: In function 'create_iec958_consumer': /kisskb/src/sound/core/pcm_iec958.c:80:9: warning: 'ws' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/sound/hda/hdac_regmap.c: In function 'hda_reg_write': /kisskb/src/sound/hda/hdac_regmap.c:282:16: warning: 'err' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/lib/rhashtable.c: In function 'rhashtable_rehash_one': /kisskb/src/lib/rhashtable.c:267:2: warning: 'next' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/dma-buf/reservation.c: In function 'reservation_object_add_shared_replace': /kisskb/src/drivers/dma-buf/reservation.c:211:7: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/mm/ksm.c: In function 'stable_node_dup': /kisskb/src/mm/ksm.c:1395:15: warning: 'found_rmap_hlist_len' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/hwspinlock/hwspinlock_core.c: In function 'of_hwspin_lock_get_id': /kisskb/src/drivers/hwspinlock/hwspinlock_core.c:328:6: warning: 'id' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/char/tpm/tpm-sysfs.c: In function 'pubek_show': /kisskb/src/drivers/char/tpm/tpm-sysfs.c:37:16: warning: 'tpm_buf.data' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/gen_stats.c: In function '__gnet_stats_copy_basic': /kisskb/src/net/core/gen_stats.c:161:19: warning: 'seq' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/core/dev.c: In function 'validate_xmit_skb_list': /kisskb/src/net/core/dev.c:3344:15: warning: 'tail' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/ncsi/ncsi-manage.c: In function 'set_one_vid': /kisskb/src/net/ncsi/ncsi-manage.c:625:19: warning: 'vid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/mouse/cyapa_gen3.c: In function 'cyapa_gen3_set_power_mode': /kisskb/src/drivers/input/mouse/cyapa_gen3.c:927:5: warning: 'ret' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/input/mouse/cyapa.c: In function 'cyapa_irq': /kisskb/src/drivers/input/mouse/cyapa.c:717:27: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c: In function 'soc15_set_ip_blocks': /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:532:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] /kisskb/src/drivers/gpu/drm/amd/amdgpu/soc15.c:551:3: warning: #warning "Enable CONFIG_DRM_AMD_DC for display support on SOC15." [-Wcpp] /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c: In function '__arm_v7s_map.constprop.9': /kisskb/src/drivers/iommu/io-pgtable-arm-v7s.c:433:7: warning: 'cptep' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c: In function 'gmc_v9_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:262:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c:262:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c: In function 'gmc_v8_0_process_interrupt': /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1459:10: warning: missing braces around initializer [-Wmissing-braces] /kisskb/src/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c:1459:10: warning: (near initialization for 'task_info.process_name') [-Wmissing-braces] /kisskb/src/drivers/input/touchscreen/hideep.c: In function 'hideep_update_firmware': /kisskb/src/drivers/input/touchscreen/hideep.c:633:10: warning: 'error' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sctp/output.c: In function 'sctp_packet_config': /kisskb/src/include/linux/compiler.h:188:2: warning: 'sk' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/net/sctp/output.c:94:15: note: 'sk' was declared here /kisskb/src/drivers/slimbus/messaging.c: In function 'slim_do_transfer': /kisskb/src/drivers/slimbus/messaging.c:126:14: warning: 'tid' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/tty/serial/8250/8250_core.c: In function 'serial_unlink_irq_chain': /kisskb/src/drivers/tty/serial/8250/8250_core.c:249:11: warning: 'i' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c: In function 'drm_sched_job_recovery': /kisskb/src/drivers/gpu/drm/scheduler/gpu_scheduler.c:689:20: warning: 'guilty_context' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/backlight/adp8860_bl.c: In function 'adp8860_bl_ambient_light_level_show': /kisskb/src/drivers/video/backlight/adp8860_bl.c:579:10: warning: 'ret_val' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/serial/f81534.c: In function 'f81534_set_register': /kisskb/src/drivers/usb/serial/f81534.c:244:10: warning: 'status' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/usb/serial/f81534.c: In function 'f81534_get_register': /kisskb/src/drivers/usb/serial/f81534.c:283:10: warning: 'status' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/video/fbdev/via/viafbdev.c:1471:12: warning: 'viafb_sup_odev_proc_show' defined but not used [-Wunused-function] /kisskb/src/drivers/mtd/ubi/eba.c: In function 'try_write_vid_and_data': /kisskb/src/drivers/mtd/ubi/eba.c:1001:7: warning: 'opnum' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/drm_atomic.c: In function 'drm_atomic_connector_check': /kisskb/src/drivers/gpu/drm/drm_atomic.c:760:38: warning: 'crtc_state' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c: In function 'g94_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxg94.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c: In function 'gm200_i2c_aux_xfer': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/i2c/auxgm200.c:160:31: warning: 'stat' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c: In function 'gk104_top_oneinit': /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'inst' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/nvkm/subdev/top/gk104.c:102:1: warning: 'type' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/dispnv50/lut.c: In function 'nv50_lut_load': /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'b' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/dispnv50/lut.c:39:18: note: 'b' was declared here /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'g' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/dispnv50/lut.c:39:15: note: 'g' was declared here /kisskb/src/arch/powerpc/include/asm/io.h:176:1: warning: 'r' may be used uninitialized in this function [-Wuninitialized] /kisskb/src/drivers/gpu/drm/nouveau/dispnv50/lut.c:39:12: note: 'r' was declared here WARNING: 4 bad relocations c00000000001446a R_PPC64_ADDR16_HIGHEST .head.text+0x0000000000014484 c00000000001446e R_PPC64_ADDR16_HIGHER .head.text+0x0000000000014484 c000000000014476 R_PPC64_ADDR16_HI .head.text+0x0000000000014484 c00000000001447a R_PPC64_ADDR16_LO .head.text+0x0000000000014484 Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc # Build took: 0:03:07.785504