# git rev-parse -q --verify 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b^{commit} 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b already have revision, skipping fetch # git checkout -q -f -B kisskb 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # git clean -qxdf # < git log -1 # commit 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # Author: Linus Torvalds # Date: Wed Aug 15 19:08:10 2018 -0700 # # ALSA: update dell-wmi mic-mute registration to new world order # # Commit c647f806b8c2 ("ALSA: hda - Allow multiple ADCs for mic mute LED # controls") changed the return value of the snd_hda_gen_add_micmute_led() # without actually updating the callers. # # Admittedly, almost no callers actually cared about the return value. # But one call site very much did: the Dell wmi code. It would see the # registration return zero, which _used_ to mean "failed" but now means # "success", and clear the dell_micmute_led_set_func pointer. # # End result: the successful registration would end up calling the Dell # code that thought it had all failed, and call through a NULL pointer. # # To make matters worse, it ends up being a tail-call, and with the # retpoline sequence you don't even see the caller (dell_micmute_update()) # in the stack trace, so the error ended up way less obvious than it # should have been. # # Fixes: c647f806b8c2 "ALSA: hda - Allow multiple ADCs for mic mute LED controls" # Cc: Takashi Iwai # Signed-off-by: Linus Torvalds # < /opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux-gcc --version # < git log --format=%s --max-count=1 70b20dd7f897c6c14ab9e0d8400aed520ab5f09b # < make -s -j 20 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- randconfig KCONFIG_SEED=0x65BD4224 # Added to kconfig CONFIG_STANDALONE=y # Added to kconfig CONFIG_BUILD_DOCSRC=n # Added to kconfig CONFIG_MODULE_SIG=n # Added to kconfig CONFIG_CPU_BIG_ENDIAN=y # Added to kconfig CONFIG_PPC64=y # Added to kconfig CONFIG_PPC_DISABLE_WERROR=y # Added to kconfig CONFIG_SECTION_MISMATCH_WARN_ONLY=y # Added to kconfig CONFIG_PREVENT_FIRMWARE_BUILD=y # Added to kconfig CONFIG_CC_STACKPROTECTOR_STRONG=n # Added to kconfig CONFIG_GCC_PLUGINS=n # Added to kconfig CONFIG_LD_HEAD_STUB_CATCH=y # make -s -j 20 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- olddefconfig # make -s -j 20 ARCH=powerpc O=/kisskb/build/linus-rand_powerpc-randconfig_powerpc-5.3 CROSS_COMPILE=/opt/cross/kisskb/gcc-5.3.0-nolibc/powerpc64-linux/bin/powerpc64-linux- In file included from /kisskb/src/arch/powerpc/xmon/xmon.c:66:0: /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_powerpc': /kisskb/src/arch/powerpc/xmon/dis-asm.h:20:9: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] printf("%.8x", insn); ^ /kisskb/src/arch/powerpc/xmon/dis-asm.h: In function 'print_insn_spu': /kisskb/src/arch/powerpc/xmon/dis-asm.h:26:9: warning: format '%x' expects argument of type 'unsigned int', but argument 2 has type 'long unsigned int' [-Wformat=] printf("%.8x", insn); ^ /kisskb/src/arch/powerpc/kernel/eeh.c:1752:12: warning: 'proc_eeh_show' defined but not used [-Wunused-function] static int proc_eeh_show(struct seq_file *m, void *v) ^ /kisskb/src/drivers/usb/misc/usbtest.c: In function 'test_queue': /kisskb/src/drivers/usb/misc/usbtest.c:2126:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=] } ^ Completed OK # rm -rf /kisskb/build/linus-rand_powerpc-randconfig_powerpc-5.3 # Build took: 0:02:17.597766